showuon commented on PR #15481:
URL: https://github.com/apache/kafka/pull/15481#issuecomment-2008904600
Backedport to 3.7 and 3.6. @omkreddy , FYI.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
showuon merged PR #15481:
URL: https://github.com/apache/kafka/pull/15481
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
showuon commented on PR #15481:
URL: https://github.com/apache/kafka/pull/15481#issuecomment-2008777656
Failed tests are unrelated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
omkreddy commented on PR #15481:
URL: https://github.com/apache/kafka/pull/15481#issuecomment-2008684718
@showuon Can we merge the PR?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
omkreddy commented on PR #15481:
URL: https://github.com/apache/kafka/pull/15481#issuecomment-2005776638
I am including this to 3.6.2 release plan
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
showuon commented on PR #15481:
URL: https://github.com/apache/kafka/pull/15481#issuecomment-2005672241
Re-triggering the CI build.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
FrankYang0529 commented on code in PR #15481:
URL: https://github.com/apache/kafka/pull/15481#discussion_r1516093537
##
core/src/test/scala/integration/kafka/zk/ZkMigrationIntegrationTest.scala:
##
@@ -271,6 +273,9 @@ class ZkMigrationIntegrationTest {
assertEquals(10,
showuon commented on PR #15481:
URL: https://github.com/apache/kafka/pull/15481#issuecomment-1982498719
Also, please add some test cases for client and IP cases with sanitized
strings. Thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please
showuon commented on code in PR #15481:
URL: https://github.com/apache/kafka/pull/15481#discussion_r1515554131
##
core/src/test/scala/integration/kafka/zk/ZkMigrationIntegrationTest.scala:
##
@@ -271,6 +273,9 @@ class ZkMigrationIntegrationTest {
assertEquals(10,
FrankYang0529 opened a new pull request, #15481:
URL: https://github.com/apache/kafka/pull/15481
*More detailed description of your change,
if necessary. The PR title and PR message become
the squashed commit message, so use a separate
comment to ping reviewers.*
*Summary of
10 matches
Mail list logo
