chia7712 commented on PR #15354:
URL: https://github.com/apache/kafka/pull/15354#issuecomment-2071806320
@jolshan Do you plan to backport this to 3.7? I recently try to backport
other PRs to 3.7 and encounter the same flaky
--
This is an automated message from the Apache Git Service.
To
OmniaGM commented on code in PR #15354:
URL: https://github.com/apache/kafka/pull/15354#discussion_r1489575856
##
core/src/test/scala/unit/kafka/server/LogDirFailureTest.scala:
##
@@ -168,6 +169,10 @@ class LogDirFailureTest extends IntegrationTestHarness {
}
def
OmniaGM commented on code in PR #15354:
URL: https://github.com/apache/kafka/pull/15354#discussion_r1489567388
##
core/src/test/scala/unit/kafka/server/LogDirFailureTest.scala:
##
@@ -168,6 +169,10 @@ class LogDirFailureTest extends IntegrationTestHarness {
}
def
OmniaGM commented on code in PR #15354:
URL: https://github.com/apache/kafka/pull/15354#discussion_r1489565890
##
core/src/test/scala/unit/kafka/server/LogDirFailureTest.scala:
##
@@ -168,6 +169,10 @@ class LogDirFailureTest extends IntegrationTestHarness {
}
def
soarez commented on code in PR #15354:
URL: https://github.com/apache/kafka/pull/15354#discussion_r1489560264
##
core/src/test/scala/unit/kafka/server/LogDirFailureTest.scala:
##
@@ -168,6 +169,10 @@ class LogDirFailureTest extends IntegrationTestHarness {
}
def
jolshan merged PR #15354:
URL: https://github.com/apache/kafka/pull/15354
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
jolshan commented on PR #15354:
URL: https://github.com/apache/kafka/pull/15354#issuecomment-1942725048
I will keep the JIRA open as we try to figure out the fix of the other
errors.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
jolshan commented on PR #15354:
URL: https://github.com/apache/kafka/pull/15354#issuecomment-1942115848
Ok -- I think in order to reduce the build failures we should merge this
change. My understanding is that this doesn't introduce new failures.
I also agree that it seems ok to make
OmniaGM commented on PR #15354:
URL: https://github.com/apache/kafka/pull/15354#issuecomment-1942060678
> Is this reducing our test coverage of the default metadata.log.dir
configuration?
If we want to limited to `LogDirFailureTest` test only that's okay it will
properly have some
gharris1727 commented on PR #15354:
URL: https://github.com/apache/kafka/pull/15354#issuecomment-1942030926
Does this make sense to change across every test suite, not just
LogDirFailureTest?
Is this reducing our test coverage of the default metadata.log.dir
configuration?
Is a
OmniaGM commented on PR #15354:
URL: https://github.com/apache/kafka/pull/15354#issuecomment-1941616164
What I noticed locally that `testIOExceptionDuringCheckpoint` still flaky
because the test try to offline log dir before
`highWatermarkCheckPointThreadStarted` create the high watermark
OmniaGM commented on PR #15354:
URL: https://github.com/apache/kafka/pull/15354#issuecomment-1941610996
> I still see one LogDirFailureTest failure:
>
> ```
> org.apache.kafka.server.fault.FaultHandlerException:
quorumTestHarnessFaultHandler: Error applying topics delta in
jolshan commented on PR #15354:
URL: https://github.com/apache/kafka/pull/15354#issuecomment-1939677736
I still see one LogDirFailureTest failure:
```
org.apache.kafka.server.fault.FaultHandlerException:
quorumTestHarnessFaultHandler: Error applying topics delta in MetadataDelta
jolshan commented on PR #15354:
URL: https://github.com/apache/kafka/pull/15354#issuecomment-1939674788
I filed a JIRA for DescribeConsumerGroupTest
https://issues.apache.org/jira/browse/KAFKA-16245
--
This is an automated message from the Apache Git Service.
To respond to the message,
OmniaGM commented on code in PR #15354:
URL: https://github.com/apache/kafka/pull/15354#discussion_r1486527783
##
core/src/test/scala/integration/kafka/api/IntegrationTestHarness.scala:
##
@@ -70,6 +70,11 @@ abstract class IntegrationTestHarness extends
KafkaServerTestHarness
gaurav-narula commented on code in PR #15354:
URL: https://github.com/apache/kafka/pull/15354#discussion_r1486519713
##
core/src/test/scala/integration/kafka/api/IntegrationTestHarness.scala:
##
@@ -70,6 +70,11 @@ abstract class IntegrationTestHarness extends
OmniaGM commented on code in PR #15354:
URL: https://github.com/apache/kafka/pull/15354#discussion_r1486512687
##
core/src/test/scala/integration/kafka/api/IntegrationTestHarness.scala:
##
@@ -70,6 +70,11 @@ abstract class IntegrationTestHarness extends
KafkaServerTestHarness
jolshan commented on code in PR #15354:
URL: https://github.com/apache/kafka/pull/15354#discussion_r1486510262
##
core/src/test/scala/integration/kafka/api/IntegrationTestHarness.scala:
##
@@ -70,6 +70,11 @@ abstract class IntegrationTestHarness extends
KafkaServerTestHarness
OmniaGM commented on PR #15354:
URL: https://github.com/apache/kafka/pull/15354#issuecomment-1938862746
@jolshan, @gharris1727, @gaurav-narula can you have a look please?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
OmniaGM opened a new pull request, #15354:
URL: https://github.com/apache/kafka/pull/15354
Fix the flakiness of LogDirFailureTest
### Committer Checklist (excluded from commit message)
- [ ] Verify design and implementation
- [ ] Verify test coverage and CI build status
- [
20 matches
Mail list logo
