Re: [PR] KAFKA-16243: Make sure that we do not exceed max poll interval inside poll [kafka]

lucasbru commented on code in PR #15372: URL: https://github.com/apache/kafka/pull/15372#discussion_r1500478736 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/HeartbeatRequestManager.java: ## @@ -232,13 +232,22 @@ public MembershipManager

Re: [PR] KAFKA-16243: Make sure that we do not exceed max poll interval inside poll [kafka]

mjsax commented on code in PR #15372: URL: https://github.com/apache/kafka/pull/15372#discussion_r1500151525 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/HeartbeatRequestManager.java: ## @@ -232,13 +232,22 @@ public MembershipManager membershipManager()

Re: [PR] KAFKA-16243: Make sure that we do not exceed max poll interval inside poll [kafka]

lucasbru merged PR #15372: URL: https://github.com/apache/kafka/pull/15372 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] KAFKA-16243: Make sure that we do not exceed max poll interval inside poll [kafka]

lucasbru commented on code in PR #15372: URL: https://github.com/apache/kafka/pull/15372#discussion_r1494847054 ## core/src/test/scala/integration/kafka/api/PlaintextConsumerTest.scala: ## @@ -265,6 +265,32 @@ class PlaintextConsumerTest extends BaseConsumerTest {

Re: [PR] KAFKA-16243: Make sure that we do not exceed max poll interval inside poll [kafka]

cadonna commented on code in PR #15372: URL: https://github.com/apache/kafka/pull/15372#discussion_r1494650399 ## core/src/test/scala/integration/kafka/api/PlaintextConsumerTest.scala: ## @@ -265,6 +265,32 @@ class PlaintextConsumerTest extends BaseConsumerTest {

Re: [PR] KAFKA-16243: Make sure that we do not exceed max poll interval inside poll [kafka]

lucasbru commented on PR #15372: URL: https://github.com/apache/kafka/pull/15372#issuecomment-1948876670 Hey @mjsax . This PR is right now waiting for @cadonna's review. If you have time, you could take a look to get into the 848 work. -- This is an automated message from the Apache Git

Re: [PR] KAFKA-16243: Make sure that we do not exceed max poll interval inside poll [kafka]

lianetm commented on PR #15372: URL: https://github.com/apache/kafka/pull/15372#issuecomment-1948611367 I like the last commit msg :) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

Re: [PR] KAFKA-16243: Make sure that we do not exceed max poll interval inside poll [kafka]

lucasbru commented on code in PR #15372: URL: https://github.com/apache/kafka/pull/15372#discussion_r1492266247 ## core/src/test/scala/integration/kafka/api/PlaintextConsumerTest.scala: ## @@ -265,6 +265,32 @@ class PlaintextConsumerTest extends BaseConsumerTest {

Re: [PR] KAFKA-16243: Make sure that we do not exceed max poll interval inside poll [kafka]

lianetm commented on PR #15372: URL: https://github.com/apache/kafka/pull/15372#issuecomment-1946894520 thanks for the changes! lgtm. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

Re: [PR] KAFKA-16243: Make sure that we do not exceed max poll interval inside poll [kafka]

lianetm commented on code in PR #15372: URL: https://github.com/apache/kafka/pull/15372#discussion_r1491444058 ## core/src/test/scala/integration/kafka/api/PlaintextConsumerTest.scala: ## @@ -265,6 +265,32 @@ class PlaintextConsumerTest extends BaseConsumerTest {

Re: [PR] KAFKA-16243: Make sure that we do not exceed max poll interval inside poll [kafka]

lucasbru commented on PR #15372: URL: https://github.com/apache/kafka/pull/15372#issuecomment-1945629703 @cadonna could you please have a look? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[PR] KAFKA-16243: Make sure that we do not exceed max poll interval inside poll [kafka]

lucasbru opened a new pull request, #15372: URL: https://github.com/apache/kafka/pull/15372 The consumer keeps a poll timer, which is used to ensure liveness of the application thread. The poll timer automatically updates while the `Consumer.poll(Duration)` method is blocked, while the