jolshan merged PR #15422:
URL: https://github.com/apache/kafka/pull/15422
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.
jolshan commented on PR #15422:
URL: https://github.com/apache/kafka/pull/15422#issuecomment-1960589848
I'll run streams locally as a double check and then merge 👍
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
U
gharris1727 commented on PR #15422:
URL: https://github.com/apache/kafka/pull/15422#issuecomment-1960494013
> The metric should be sufficient to test this. Not sure we need the log.
I didn't read the full test before commenting earlier. I think this is
reasonable then.
The test
jolshan commented on PR #15422:
URL: https://github.com/apache/kafka/pull/15422#issuecomment-1960491986
>This whole appender block is unused now that log messages aren't being
asserted on.
Good point, I can remove
> Can we revert the log message removal instead?
Or bring it
gharris1727 commented on PR #15422:
URL: https://github.com/apache/kafka/pull/15422#issuecomment-1960490363
Thanks for root-causing this so quickly @jolshan I was just seeing it pop up
in my PR builds.
--
This is an automated message from the Apache Git Service.
To respond to the message,
