showuon merged PR #15483:
URL: https://github.com/apache/kafka/pull/15483
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
chia7712 commented on code in PR #15483:
URL: https://github.com/apache/kafka/pull/15483#discussion_r1533141970
##
clients/src/main/java/org/apache/kafka/common/metrics/KafkaMetric.java:
##
@@ -40,15 +48,29 @@ public KafkaMetric(Object lock, MetricName metricName,
mimaison commented on code in PR #15483:
URL: https://github.com/apache/kafka/pull/15483#discussion_r1532394640
##
clients/src/main/java/org/apache/kafka/common/metrics/KafkaMetric.java:
##
@@ -40,15 +48,29 @@ public KafkaMetric(Object lock, MetricName metricName,
chia7712 commented on PR #15483:
URL: https://github.com/apache/kafka/pull/15483#issuecomment-2009231142
the failed tests are shown below, and they pass on my local
```script
./gradlew cleanTest :tools:test --tests
ListConsumerGroupTest.testListConsumerGroupsWithTypesClassicProtocol
johnnychhsu commented on code in PR #15483:
URL: https://github.com/apache/kafka/pull/15483#discussion_r1530243082
##
clients/src/main/java/org/apache/kafka/common/metrics/KafkaMetric.java:
##
@@ -78,6 +111,10 @@ public Measurable measurable() {
}
}
+/**
+
chia7712 commented on code in PR #15483:
URL: https://github.com/apache/kafka/pull/15483#discussion_r1530225439
##
clients/src/main/java/org/apache/kafka/common/metrics/KafkaMetric.java:
##
@@ -78,6 +109,11 @@ public Measurable measurable() {
}
}
+/**
+
chia7712 commented on code in PR #15483:
URL: https://github.com/apache/kafka/pull/15483#discussion_r1530224467
##
clients/src/main/java/org/apache/kafka/common/metrics/KafkaMetric.java:
##
@@ -78,6 +111,10 @@ public Measurable measurable() {
}
}
+/**
+
johnnychhsu commented on code in PR #15483:
URL: https://github.com/apache/kafka/pull/15483#discussion_r1528503006
##
clients/src/main/java/org/apache/kafka/common/metrics/KafkaMetric.java:
##
@@ -78,6 +111,10 @@ public Measurable measurable() {
}
}
+/**
+
chia7712 commented on code in PR #15483:
URL: https://github.com/apache/kafka/pull/15483#discussion_r1527554674
##
clients/src/main/java/org/apache/kafka/common/metrics/KafkaMetric.java:
##
@@ -78,6 +111,10 @@ public Measurable measurable() {
}
}
+/**
+
johnnychhsu commented on code in PR #15483:
URL: https://github.com/apache/kafka/pull/15483#discussion_r1527554056
##
clients/src/main/java/org/apache/kafka/common/metrics/KafkaMetric.java:
##
@@ -40,15 +48,30 @@ public KafkaMetric(Object lock, MetricName metricName,
johnnychhsu commented on code in PR #15483:
URL: https://github.com/apache/kafka/pull/15483#discussion_r1527553634
##
clients/src/main/java/org/apache/kafka/common/metrics/KafkaMetric.java:
##
@@ -40,15 +48,30 @@ public KafkaMetric(Object lock, MetricName metricName,
chia7712 commented on code in PR #15483:
URL: https://github.com/apache/kafka/pull/15483#discussion_r1527537826
##
clients/src/main/java/org/apache/kafka/common/metrics/KafkaMetric.java:
##
@@ -40,15 +48,30 @@ public KafkaMetric(Object lock, MetricName metricName,
johnnychhsu commented on PR #15483:
URL: https://github.com/apache/kafka/pull/15483#issuecomment-2002480150
tested with
```
./gradlew cleanTest core:test --tests ConnectionQuotasTest --tests
ControllerMutationQuotaTest stream:test --tests StandbyTaskTest --tests
StreamTaskTest
johnnychhsu commented on code in PR #15483:
URL: https://github.com/apache/kafka/pull/15483#discussion_r1527503839
##
clients/src/main/java/org/apache/kafka/common/metrics/KafkaMetric.java:
##
@@ -40,15 +48,28 @@ public KafkaMetric(Object lock, MetricName metricName,
chia7712 commented on code in PR #15483:
URL: https://github.com/apache/kafka/pull/15483#discussion_r1521949713
##
clients/src/main/java/org/apache/kafka/common/metrics/KafkaMetric.java:
##
@@ -40,15 +48,28 @@ public KafkaMetric(Object lock, MetricName metricName,
johnnychhsu commented on code in PR #15483:
URL: https://github.com/apache/kafka/pull/15483#discussion_r1521282961
##
clients/src/main/java/org/apache/kafka/common/metrics/KafkaMetric.java:
##
@@ -28,7 +59,14 @@ public final class KafkaMetric implements Metric {
private
johnnychhsu commented on code in PR #15483:
URL: https://github.com/apache/kafka/pull/15483#discussion_r1521280887
##
clients/src/main/java/org/apache/kafka/common/metrics/KafkaMetric.java:
##
@@ -20,6 +20,37 @@
import org.apache.kafka.common.MetricName;
import
mimaison commented on code in PR #15483:
URL: https://github.com/apache/kafka/pull/15483#discussion_r1521121701
##
clients/src/main/java/org/apache/kafka/common/metrics/KafkaMetric.java:
##
@@ -28,7 +59,14 @@ public final class KafkaMetric implements Metric {
private final
showuon commented on PR #15483:
URL: https://github.com/apache/kafka/pull/15483#issuecomment-1990842126
@mimaison , please take a look when available. Thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
showuon commented on code in PR #15483:
URL: https://github.com/apache/kafka/pull/15483#discussion_r1520919788
##
clients/src/main/java/org/apache/kafka/common/metrics/KafkaMetric.java:
##
@@ -20,6 +20,37 @@
import org.apache.kafka.common.MetricName;
import
20 matches
Mail list logo
