chia7712 merged PR #15733:
URL: https://github.com/apache/kafka/pull/15733
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache
soarez commented on PR #15733:
URL: https://github.com/apache/kafka/pull/15733#issuecomment-2060431133
Thanks @chia7712 I'll have another look at this later today
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
UR
chia7712 commented on PR #15733:
URL: https://github.com/apache/kafka/pull/15733#issuecomment-2060429559
@soarez it would be great to get your reviews before merging it :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and us
mwesterby commented on PR #15733:
URL: https://github.com/apache/kafka/pull/15733#issuecomment-2059603416
@chia7712 Thanks again for the review. I've implemented all of your
suggested. Please let me know if you spot anything else I've missed.
--
This is an automated message from the Apach
mwesterby commented on code in PR #15733:
URL: https://github.com/apache/kafka/pull/15733#discussion_r1567721679
##
core/src/main/scala/kafka/tools/StorageTool.scala:
##
@@ -440,8 +440,12 @@ object StorageTool extends Logging {
"Use --ignore-formatted to ignore this dir
mwesterby commented on code in PR #15733:
URL: https://github.com/apache/kafka/pull/15733#discussion_r1567721679
##
core/src/main/scala/kafka/tools/StorageTool.scala:
##
@@ -440,8 +440,12 @@ object StorageTool extends Logging {
"Use --ignore-formatted to ignore this dir
mwesterby commented on code in PR #15733:
URL: https://github.com/apache/kafka/pull/15733#discussion_r1567721679
##
core/src/main/scala/kafka/tools/StorageTool.scala:
##
@@ -440,8 +440,12 @@ object StorageTool extends Logging {
"Use --ignore-formatted to ignore this dir
mwesterby commented on code in PR #15733:
URL: https://github.com/apache/kafka/pull/15733#discussion_r1567721679
##
core/src/main/scala/kafka/tools/StorageTool.scala:
##
@@ -440,8 +440,12 @@ object StorageTool extends Logging {
"Use --ignore-formatted to ignore this dir
mwesterby commented on code in PR #15733:
URL: https://github.com/apache/kafka/pull/15733#discussion_r1567721679
##
core/src/main/scala/kafka/tools/StorageTool.scala:
##
@@ -440,8 +440,12 @@ object StorageTool extends Logging {
"Use --ignore-formatted to ignore this dir
mwesterby commented on code in PR #15733:
URL: https://github.com/apache/kafka/pull/15733#discussion_r1567699963
##
core/src/test/scala/unit/kafka/tools/StorageToolTest.scala:
##
@@ -192,6 +192,66 @@ Found problem:
} finally Utils.delete(tempDir)
}
+ private def runFo
mwesterby commented on code in PR #15733:
URL: https://github.com/apache/kafka/pull/15733#discussion_r1567694543
##
core/src/test/scala/unit/kafka/tools/StorageToolTest.scala:
##
@@ -192,6 +192,66 @@ Found problem:
} finally Utils.delete(tempDir)
}
+ private def runFo
mwesterby commented on PR #15733:
URL: https://github.com/apache/kafka/pull/15733#issuecomment-2059543825
> Also, is my previous comment
(https://github.com/apache/kafka/pull/15733#discussion_r1567431572) valid? the
following test case is based on my comment, and it seems to me that should
chia7712 commented on code in PR #15733:
URL: https://github.com/apache/kafka/pull/15733#discussion_r1567642200
##
core/src/test/scala/unit/kafka/tools/StorageToolTest.scala:
##
@@ -192,6 +192,66 @@ Found problem:
} finally Utils.delete(tempDir)
}
+ private def runFor
mwesterby commented on PR #15733:
URL: https://github.com/apache/kafka/pull/15733#issuecomment-2059463882
> It seems the three new tests have a lot in common:
>
> the setup of MetaProperties, ByteArrayOutputStream and BootstrapMetadata
the invocation of command formatCommand
Is it
chia7712 commented on PR #15733:
URL: https://github.com/apache/kafka/pull/15733#issuecomment-2059291065
> LogManager can accept failed directories in startup. That method is a bit
confusing, but if you look a bit below the line you pointed to, the exception
is caught, the fact the director
soarez commented on PR #15733:
URL: https://github.com/apache/kafka/pull/15733#issuecomment-2059274214
@chia7712 Thanks for reviewing this.
> It seems LogManager can't accept failed directories in startup, right?
LogManager can accept failed directories in startup. That method i
chia7712 commented on code in PR #15733:
URL: https://github.com/apache/kafka/pull/15733#discussion_r1567431572
##
core/src/main/scala/kafka/tools/StorageTool.scala:
##
@@ -440,8 +440,12 @@ object StorageTool extends Logging {
"Use --ignore-formatted to ignore this dire
mwesterby opened a new pull request, #15733:
URL: https://github.com/apache/kafka/pull/15733
Prevents the storage tool from crashing when some of the directories are
unavailable, but others are still available and have not yet been formatted.
Should all directories be unavailable howe
18 matches
Mail list logo
