Re: [PR] KAFKA-16369: Broker may not shut down when SocketServer fails to bind as Address already in use [kafka]

edoardocomar commented on PR #15530: URL: https://github.com/apache/kafka/pull/15530#issuecomment-2004581473 fix cherry picked to 3.6 and 3.7 branches -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] KAFKA-16369: Broker may not shut down when SocketServer fails to bind as Address already in use [kafka]

edoardocomar commented on PR #15530: URL: https://github.com/apache/kafka/pull/15530#issuecomment-2003461536 thanks @showuon ! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

Re: [PR] KAFKA-16369: Broker may not shut down when SocketServer fails to bind as Address already in use [kafka]

edoardocomar merged PR #15530: URL: https://github.com/apache/kafka/pull/15530 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] KAFKA-16369: Broker may not shut down when SocketServer fails to bind as Address already in use [kafka]

edoardocomar commented on code in PR #15530: URL: https://github.com/apache/kafka/pull/15530#discussion_r1528223058 ## core/src/test/scala/unit/kafka/server/KafkaServerTest.scala: ## @@ -42,6 +43,24 @@ class KafkaServerTest extends QuorumTestHarness {

Re: [PR] KAFKA-16369: Broker may not shut down when SocketServer fails to bind as Address already in use [kafka]

showuon commented on code in PR #15530: URL: https://github.com/apache/kafka/pull/15530#discussion_r1528015868 ## core/src/test/scala/unit/kafka/server/KafkaServerTest.scala: ## @@ -42,6 +43,24 @@ class KafkaServerTest extends QuorumTestHarness {

Re: [PR] KAFKA-16369: Broker may not shut down when SocketServer fails to bind as Address already in use [kafka]

showuon commented on code in PR #15530: URL: https://github.com/apache/kafka/pull/15530#discussion_r1528009016 ## core/src/main/scala/kafka/server/KafkaServer.scala: ## @@ -617,14 +617,21 @@ class KafkaServer( } } } -

Re: [PR] KAFKA-16369: Broker may not shut down when SocketServer fails to bind as Address already in use [kafka]

edoardocomar commented on code in PR #15530: URL: https://github.com/apache/kafka/pull/15530#discussion_r1526169481 ## core/src/main/scala/kafka/server/KafkaServer.scala: ## @@ -617,14 +617,21 @@ class KafkaServer( } } } -

Re: [PR] KAFKA-16369: Broker may not shut down when SocketServer fails to bind as Address already in use [kafka]

edoardocomar commented on code in PR #15530: URL: https://github.com/apache/kafka/pull/15530#discussion_r1526169481 ## core/src/main/scala/kafka/server/KafkaServer.scala: ## @@ -617,14 +617,21 @@ class KafkaServer( } } } -

Re: [PR] KAFKA-16369: Broker may not shut down when SocketServer fails to bind as Address already in use [kafka]

edoardocomar commented on code in PR #15530: URL: https://github.com/apache/kafka/pull/15530#discussion_r1526169481 ## core/src/main/scala/kafka/server/KafkaServer.scala: ## @@ -617,14 +617,21 @@ class KafkaServer( } } } -

Re: [PR] KAFKA-16369: Broker may not shut down when SocketServer fails to bind as Address already in use [kafka]

edoardocomar commented on code in PR #15530: URL: https://github.com/apache/kafka/pull/15530#discussion_r1526237310 ## core/src/test/scala/unit/kafka/server/KafkaServerTest.scala: ## @@ -42,6 +42,32 @@ class KafkaServerTest extends QuorumTestHarness {

Re: [PR] KAFKA-16369: Broker may not shut down when SocketServer fails to bind as Address already in use [kafka]

edoardocomar commented on code in PR #15530: URL: https://github.com/apache/kafka/pull/15530#discussion_r1526169481 ## core/src/main/scala/kafka/server/KafkaServer.scala: ## @@ -617,14 +617,21 @@ class KafkaServer( } } } -

Re: [PR] KAFKA-16369: Broker may not shut down when SocketServer fails to bind as Address already in use [kafka]

edoardocomar commented on code in PR #15530: URL: https://github.com/apache/kafka/pull/15530#discussion_r1526169481 ## core/src/main/scala/kafka/server/KafkaServer.scala: ## @@ -617,14 +617,21 @@ class KafkaServer( } } } -

Re: [PR] KAFKA-16369: Broker may not shut down when SocketServer fails to bind as Address already in use [kafka]

showuon commented on code in PR #15530: URL: https://github.com/apache/kafka/pull/15530#discussion_r1525901824 ## core/src/test/scala/unit/kafka/server/KafkaServerTest.scala: ## @@ -42,6 +42,32 @@ class KafkaServerTest extends QuorumTestHarness {

Re: [PR] KAFKA-16369: Broker may not shut down when SocketServer fails to bind as Address already in use [kafka]

edoardocomar commented on PR #15530: URL: https://github.com/apache/kafka/pull/15530#issuecomment-1997572827 PR is ready for review, can anyone please take a look? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[PR] KAFKA-16369: Broker may not shut down when SocketServer fails to bind as Address already in use [kafka]

edoardocomar opened a new pull request, #15530: URL: https://github.com/apache/kafka/pull/15530 Add a Wait for all the SocketServer ports to be open, and the Acceptors to be started The BrokerServer (KRaft mode) had such a wait, which was missing from the KafkaServer (ZK mode). --