dajac commented on PR #16072:
URL: https://github.com/apache/kafka/pull/16072#issuecomment-2133684583
Merged to trunk and 3.7.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
dajac commented on PR #15536:
URL: https://github.com/apache/kafka/pull/15536#issuecomment-2133676133
Addressed by https://github.com/apache/kafka/pull/16072.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
dajac closed pull request #15536: KAFKA-16371: fix lingering pending commit
when handling OFFSET_METADATA_TOO_LARGE
URL: https://github.com/apache/kafka/pull/15536
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
dajac merged PR #16072:
URL: https://github.com/apache/kafka/pull/16072
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
dajac commented on PR #16072:
URL: https://github.com/apache/kafka/pull/16072#issuecomment-213709
Opened: https://issues.apache.org/jira/browse/KAFKA-16846.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
jolshan commented on PR #16072:
URL: https://github.com/apache/kafka/pull/16072#issuecomment-2132557435
@chia7712 He said he would file it on Monday -- so soon :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
chia7712 commented on PR #16072:
URL: https://github.com/apache/kafka/pull/16072#issuecomment-2132395309
> Discussed a bit with David offline. Given that this error should be fatal
for the producer (we can do a followup to make the error clearer there), this
handling makes sense for now.
dajac commented on code in PR #16072:
URL: https://github.com/apache/kafka/pull/16072#discussion_r1614757426
##
core/src/test/scala/unit/kafka/coordinator/group/GroupMetadataManagerTest.scala:
##
@@ -1664,6 +1664,134 @@ class GroupMetadataManagerTest {
assertEquals(0,
jolshan commented on code in PR #16072:
URL: https://github.com/apache/kafka/pull/16072#discussion_r1614757904
##
core/src/test/scala/unit/kafka/coordinator/group/GroupMetadataManagerTest.scala:
##
@@ -1664,6 +1664,134 @@ class GroupMetadataManagerTest {
assertEquals(0,
dajac commented on code in PR #16072:
URL: https://github.com/apache/kafka/pull/16072#discussion_r1614757426
##
core/src/test/scala/unit/kafka/coordinator/group/GroupMetadataManagerTest.scala:
##
@@ -1664,6 +1664,134 @@ class GroupMetadataManagerTest {
assertEquals(0,
jolshan commented on code in PR #16072:
URL: https://github.com/apache/kafka/pull/16072#discussion_r1614738949
##
core/src/test/scala/unit/kafka/coordinator/group/GroupMetadataManagerTest.scala:
##
@@ -1664,6 +1664,134 @@ class GroupMetadataManagerTest {
assertEquals(0,
dajac commented on code in PR #16072:
URL: https://github.com/apache/kafka/pull/16072#discussion_r1614441098
##
core/src/test/scala/unit/kafka/coordinator/group/GroupMetadataManagerTest.scala:
##
@@ -1664,6 +1664,134 @@ class GroupMetadataManagerTest {
assertEquals(0,
jolshan commented on code in PR #16072:
URL: https://github.com/apache/kafka/pull/16072#discussion_r1614071322
##
core/src/test/scala/unit/kafka/coordinator/group/GroupMetadataManagerTest.scala:
##
@@ -1664,6 +1664,134 @@ class GroupMetadataManagerTest {
assertEquals(0,
jolshan commented on code in PR #16072:
URL: https://github.com/apache/kafka/pull/16072#discussion_r1614055528
##
core/src/test/scala/unit/kafka/coordinator/group/GroupMetadataManagerTest.scala:
##
@@ -1664,6 +1664,134 @@ class GroupMetadataManagerTest {
assertEquals(0,
dajac commented on code in PR #16072:
URL: https://github.com/apache/kafka/pull/16072#discussion_r1614001355
##
core/src/test/scala/unit/kafka/coordinator/group/GroupMetadataManagerTest.scala:
##
@@ -1664,6 +1664,134 @@ class GroupMetadataManagerTest {
assertEquals(0,
jolshan commented on code in PR #16072:
URL: https://github.com/apache/kafka/pull/16072#discussion_r1613818130
##
core/src/test/scala/unit/kafka/coordinator/group/GroupMetadataManagerTest.scala:
##
@@ -1664,6 +1664,134 @@ class GroupMetadataManagerTest {
assertEquals(0,
chia7712 commented on code in PR #16072:
URL: https://github.com/apache/kafka/pull/16072#discussion_r1613803124
##
core/src/test/scala/unit/kafka/coordinator/group/GroupMetadataManagerTest.scala:
##
@@ -1664,6 +1664,134 @@ class GroupMetadataManagerTest {
assertEquals(0,
jolshan commented on PR #16072:
URL: https://github.com/apache/kafka/pull/16072#issuecomment-2130038593
> Hum... I am not sure about this one. @jolshan Would you know?
There was a lot of refactoring in this path so we may have just missed this.
It was originally intended for any
dajac commented on PR #16072:
URL: https://github.com/apache/kafka/pull/16072#issuecomment-2129955822
> BTW, I notice that createPutCacheCallback has a input argument
preAppendErrors which is never defined. Is it a unfinished feature or a stuff
we can remove.
Hum... I am not sure
dajac commented on code in PR #16072:
URL: https://github.com/apache/kafka/pull/16072#discussion_r1613744158
##
core/src/test/scala/unit/kafka/coordinator/group/GroupMetadataManagerTest.scala:
##
@@ -1664,6 +1664,134 @@ class GroupMetadataManagerTest {
assertEquals(0,
chia7712 commented on code in PR #16072:
URL: https://github.com/apache/kafka/pull/16072#discussion_r1613735230
##
core/src/test/scala/unit/kafka/coordinator/group/GroupMetadataManagerTest.scala:
##
@@ -1664,6 +1664,134 @@ class GroupMetadataManagerTest {
assertEquals(0,
dajac opened a new pull request, #16072:
URL: https://github.com/apache/kafka/pull/16072
This patch was initially created in
https://github.com/apache/kafka/pull/15536.
When there is a commit for multiple topic partitions and some, but not all,
exceed the offset metadata limit, the
dajac commented on PR #15536:
URL: https://github.com/apache/kafka/pull/15536#issuecomment-2127253314
It would be great if we could also add a unit test for the transactional
offset commit path. Something like:
```
@Test
def
dajac commented on PR #15536:
URL: https://github.com/apache/kafka/pull/15536#issuecomment-2127090825
@kphelps Are you interested in addressing the small comments? I can merge it
afterwards.
--
This is an automated message from the Apache Git Service.
To respond to the message, please
dajac commented on code in PR #15536:
URL: https://github.com/apache/kafka/pull/15536#discussion_r1565639650
##
core/src/test/scala/unit/kafka/coordinator/group/GroupMetadataManagerTest.scala:
##
@@ -1661,6 +1661,65 @@ class GroupMetadataManagerTest {
assertEquals(0,
dajac commented on PR #15536:
URL: https://github.com/apache/kafka/pull/15536#issuecomment-2051891235
Sorry for the delay on this one. I will review it next week.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
kphelps opened a new pull request, #15536:
URL: https://github.com/apache/kafka/pull/15536
When there is a commit for multiple topic partitions and some, but not all,
exceed the offset metadata limit, the pending commit is not properly cleaned up
leading to `UNSTABLE_OFFSET_COMMIT` errors
27 matches
Mail list logo
