Re: [PR] KAFKA-16374; High watermark updates should have a higher priority [kafka]

2024-03-25 Thread via GitHub
dajac merged PR #15534: URL: https://github.com/apache/kafka/pull/15534 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] KAFKA-16374; High watermark updates should have a higher priority [kafka]

2024-03-25 Thread via GitHub
dajac commented on code in PR #15534: URL: https://github.com/apache/kafka/pull/15534#discussion_r1537192799 ## group-coordinator/src/test/java/org/apache/kafka/coordinator/group/runtime/CoordinatorRuntimeTest.java: ## @@ -504,12 +518,6 @@ public void

Re: [PR] KAFKA-16374; High watermark updates should have a higher priority [kafka]

2024-03-22 Thread via GitHub
jolshan commented on code in PR #15534: URL: https://github.com/apache/kafka/pull/15534#discussion_r1536002502 ## group-coordinator/src/test/java/org/apache/kafka/coordinator/group/runtime/CoordinatorRuntimeTest.java: ## @@ -504,12 +518,6 @@ public void

Re: [PR] KAFKA-16374; High watermark updates should have a higher priority [kafka]

2024-03-22 Thread via GitHub
dajac commented on code in PR #15534: URL: https://github.com/apache/kafka/pull/15534#discussion_r1535988740 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/runtime/CoordinatorRuntime.java: ## @@ -495,6 +502,7 @@ private void transitionTo(

Re: [PR] KAFKA-16374; High watermark updates should have a higher priority [kafka]

2024-03-22 Thread via GitHub
jolshan commented on code in PR #15534: URL: https://github.com/apache/kafka/pull/15534#discussion_r1535986083 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/runtime/CoordinatorRuntime.java: ## @@ -495,6 +502,7 @@ private void transitionTo(

Re: [PR] KAFKA-16374; High watermark updates should have a higher priority [kafka]

2024-03-21 Thread via GitHub
jeffkbkim commented on code in PR #15534: URL: https://github.com/apache/kafka/pull/15534#discussion_r1534979427 ## group-coordinator/src/test/java/org/apache/kafka/coordinator/group/runtime/CoordinatorRuntimeTest.java: ## @@ -2591,6 +2599,74 @@ public void

Re: [PR] KAFKA-16374; High watermark updates should have a higher priority [kafka]

2024-03-21 Thread via GitHub
dajac commented on code in PR #15534: URL: https://github.com/apache/kafka/pull/15534#discussion_r1533486994 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/runtime/CoordinatorRuntime.java: ## @@ -1191,30 +1212,37 @@ public void onHighWatermarkUpdated(

Re: [PR] KAFKA-16374; High watermark updates should have a higher priority [kafka]

2024-03-20 Thread via GitHub
jeffkbkim commented on code in PR #15534: URL: https://github.com/apache/kafka/pull/15534#discussion_r1532907721 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/runtime/CoordinatorRuntime.java: ## @@ -1191,30 +1212,37 @@ public void onHighWatermarkUpdated(

Re: [PR] KAFKA-16374; High watermark updates should have a higher priority [kafka]

2024-03-20 Thread via GitHub
jeffkbkim commented on code in PR #15534: URL: https://github.com/apache/kafka/pull/15534#discussion_r1532903183 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/runtime/CoordinatorRuntime.java: ## @@ -1191,30 +1212,37 @@ public void onHighWatermarkUpdated(

Re: [PR] KAFKA-16374; High watermark updates should have a higher priority [kafka]

2024-03-20 Thread via GitHub
dajac commented on code in PR #15534: URL: https://github.com/apache/kafka/pull/15534#discussion_r1532741513 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/runtime/CoordinatorRuntime.java: ## @@ -1191,30 +1212,37 @@ public void onHighWatermarkUpdated(

Re: [PR] KAFKA-16374; High watermark updates should have a higher priority [kafka]

2024-03-20 Thread via GitHub
dajac commented on code in PR #15534: URL: https://github.com/apache/kafka/pull/15534#discussion_r1532739687 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/runtime/CoordinatorRuntime.java: ## @@ -1191,30 +1212,37 @@ public void onHighWatermarkUpdated(

Re: [PR] KAFKA-16374; High watermark updates should have a higher priority [kafka]

2024-03-18 Thread via GitHub
jeffkbkim commented on code in PR #15534: URL: https://github.com/apache/kafka/pull/15534#discussion_r1529191724 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/runtime/CoordinatorRuntime.java: ## @@ -1191,30 +1212,37 @@ public void onHighWatermarkUpdated(

[PR] KAFKA-16374; High watermark updates should have a higher priority [kafka]

2024-03-14 Thread via GitHub
dajac opened a new pull request, #15534: URL: https://github.com/apache/kafka/pull/15534 When the group coordinator is under heavy load, the current mechanism to release pending events based on updated high watermark, which consist in pushing an event at the end of the queue, is bad