Re: [PR] KAFKA-16375: Fix for rejoin while reconciling [kafka]

lucasbru merged PR #15579: URL: https://github.com/apache/kafka/pull/15579 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache

Re: [PR] KAFKA-16375: Fix for rejoin while reconciling [kafka]

dajac commented on code in PR #15579: URL: https://github.com/apache/kafka/pull/15579#discussion_r1537323017 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/MembershipManagerImpl.java: ## @@ -1010,49 +1015,55 @@ private void revokeAndAssign(LocalAssignment

Re: [PR] KAFKA-16375: Fix for rejoin while reconciling [kafka]

lianetm commented on PR #15579: URL: https://github.com/apache/kafka/pull/15579#issuecomment-2015850725 Thanks both for the feedback. I pushed the changes addressing all the suggestions. -- This is an automated message from the Apache Git Service. To respond to the message, please log on

Re: [PR] KAFKA-16375: Fix for rejoin while reconciling [kafka]

lianetm commented on code in PR #15579: URL: https://github.com/apache/kafka/pull/15579#discussion_r1536165527 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/MembershipManagerImpl.java: ## @@ -1010,49 +1015,55 @@ private void revokeAndAssign(LocalAssignment

Re: [PR] KAFKA-16375: Fix for rejoin while reconciling [kafka]

lianetm commented on code in PR #15579: URL: https://github.com/apache/kafka/pull/15579#discussion_r1536155967 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/MembershipManagerImpl.java: ## @@ -1070,29 +1081,27 @@ private SortedSet toTopicPartitionSet(Sorte

Re: [PR] KAFKA-16375: Fix for rejoin while reconciling [kafka]

lianetm commented on code in PR #15579: URL: https://github.com/apache/kafka/pull/15579#discussion_r1536155669 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/MembershipManagerImpl.java: ## @@ -1010,49 +1015,55 @@ private void revokeAndAssign(LocalAssignment

Re: [PR] KAFKA-16375: Fix for rejoin while reconciling [kafka]

lianetm commented on code in PR #15579: URL: https://github.com/apache/kafka/pull/15579#discussion_r1536155346 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/MembershipManagerImpl.java: ## @@ -1010,49 +1015,55 @@ private void revokeAndAssign(LocalAssignment

Re: [PR] KAFKA-16375: Fix for rejoin while reconciling [kafka]

lianetm commented on code in PR #15579: URL: https://github.com/apache/kafka/pull/15579#discussion_r1536040639 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/MembershipManagerImpl.java: ## @@ -1010,49 +1015,55 @@ private void revokeAndAssign(LocalAssignment

Re: [PR] KAFKA-16375: Fix for rejoin while reconciling [kafka]

lianetm commented on code in PR #15579: URL: https://github.com/apache/kafka/pull/15579#discussion_r1536040639 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/MembershipManagerImpl.java: ## @@ -1010,49 +1015,55 @@ private void revokeAndAssign(LocalAssignment

Re: [PR] KAFKA-16375: Fix for rejoin while reconciling [kafka]

lianetm commented on code in PR #15579: URL: https://github.com/apache/kafka/pull/15579#discussion_r1536040639 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/MembershipManagerImpl.java: ## @@ -1010,49 +1015,55 @@ private void revokeAndAssign(LocalAssignment

Re: [PR] KAFKA-16375: Fix for rejoin while reconciling [kafka]

lianetm commented on code in PR #15579: URL: https://github.com/apache/kafka/pull/15579#discussion_r1536040639 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/MembershipManagerImpl.java: ## @@ -1010,49 +1015,55 @@ private void revokeAndAssign(LocalAssignment

Re: [PR] KAFKA-16375: Fix for rejoin while reconciling [kafka]

dajac commented on code in PR #15579: URL: https://github.com/apache/kafka/pull/15579#discussion_r1535964547 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/MembershipManagerImpl.java: ## @@ -1010,49 +1015,55 @@ private void revokeAndAssign(LocalAssignment

Re: [PR] KAFKA-16375: Fix for rejoin while reconciling [kafka]

lianetm commented on code in PR #15579: URL: https://github.com/apache/kafka/pull/15579#discussion_r1535917633 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/MembershipManagerImpl.java: ## @@ -1010,49 +1015,55 @@ private void revokeAndAssign(LocalAssignment

Re: [PR] KAFKA-16375: Fix for rejoin while reconciling [kafka]

lianetm commented on code in PR #15579: URL: https://github.com/apache/kafka/pull/15579#discussion_r1535917633 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/MembershipManagerImpl.java: ## @@ -1010,49 +1015,55 @@ private void revokeAndAssign(LocalAssignment

Re: [PR] KAFKA-16375: Fix for rejoin while reconciling [kafka]

dajac commented on code in PR #15579: URL: https://github.com/apache/kafka/pull/15579#discussion_r1535608892 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/MembershipManagerImpl.java: ## @@ -1010,49 +1015,55 @@ private void revokeAndAssign(LocalAssignment

Re: [PR] KAFKA-16375: Fix for rejoin while reconciling [kafka]

lucasbru commented on code in PR #15579: URL: https://github.com/apache/kafka/pull/15579#discussion_r1535558299 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/MembershipManagerImpl.java: ## @@ -1010,49 +1015,55 @@ private void revokeAndAssign(LocalAssignmen

Re: [PR] KAFKA-16375: Fix for rejoin while reconciling [kafka]

lianetm commented on PR #15579: URL: https://github.com/apache/kafka/pull/15579#issuecomment-2013823539 Hey @lucasbru, could you please take a look at this one when you have a chance? Thanks! -- This is an automated message from the Apache Git Service. To respond to the message, please lo