Re: [PR] KAFKA-16408: Fix handling of '--version' or '--help' for GetOffsetShell [kafka]

2024-03-24 Thread via GitHub
chia7712 commented on PR #15583: URL: https://github.com/apache/kafka/pull/15583#issuecomment-2017179316 backport to 3.7 by https://github.com/apache/kafka/commit/0ebdc37ee7a77b4ef4be4dd8496db8b6b0abcc55 -- This is an automated message from the Apache Git Service. To respond to the

Re: [PR] KAFKA-16408: Fix handling of '--version' or '--help' for GetOffsetShell [kafka]

2024-03-24 Thread via GitHub
chia7712 merged PR #15583: URL: https://github.com/apache/kafka/pull/15583 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] KAFKA-16408: Fix handling of '--version' or '--help' for GetOffsetShell [kafka]

2024-03-24 Thread via GitHub
chia7712 commented on PR #15583: URL: https://github.com/apache/kafka/pull/15583#issuecomment-2016801661 ```sh ./gradlew cleanTest :tools:test --tests MetadataQuorumCommandTest.testDescribeQuorumReplicationSuccessful --tests MetadataQuorumCommandTest.testDescribeQuorumStatusSuccessful

Re: [PR] KAFKA-16408: Fix handling of '--version' or '--help' for GetOffsetShell [kafka]

2024-03-24 Thread via GitHub
wernerdv commented on PR #15583: URL: https://github.com/apache/kafka/pull/15583#issuecomment-2016799378 > @wernerdv could you please attach the new console output from `./bin/kafka-get-offsets.sh --version` Yes, sure. ``` ./bin/kafka-get-offsets.sh --version 3.8.0-SNAPSHOT

Re: [PR] KAFKA-16408: Fix handling of '--version' or '--help' for GetOffsetShell [kafka]

2024-03-24 Thread via GitHub
chia7712 commented on PR #15583: URL: https://github.com/apache/kafka/pull/15583#issuecomment-2016793739 @wernerdv could you please attach the new console output from `./bin/kafka-get-offsets.sh --version` -- This is an automated message from the Apache Git Service. To respond to the

Re: [PR] KAFKA-16408: Fix handling of '--version' or '--help' for GetOffsetShell [kafka]

2024-03-22 Thread via GitHub
wernerdv commented on PR #15583: URL: https://github.com/apache/kafka/pull/15583#issuecomment-2016305593 @gharris1727 Hello. Please, take a look. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[PR] KAFKA-16408: Fix handling of '--version' or '--help' for GetOffsetShell [kafka]

2024-03-22 Thread via GitHub
wernerdv opened a new pull request, #15583: URL: https://github.com/apache/kafka/pull/15583 Added call CommandLineUtils#maybePrintHelpOrVersion before check required args. ### Committer Checklist (excluded from commit message) - [ ] Verify design and implementation - [ ]