Re: [PR] KAFKA-16465: Fix consumer sys test revocation validation [kafka]

2024-04-29 Thread via GitHub
lucasbru merged PR #15778: URL: https://github.com/apache/kafka/pull/15778 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] KAFKA-16465: Fix consumer sys test revocation validation [kafka]

2024-04-26 Thread via GitHub
lianetm commented on code in PR #15778: URL: https://github.com/apache/kafka/pull/15778#discussion_r1581508063 ## tests/kafkatest/tests/client/consumer_test.py: ## @@ -242,16 +242,15 @@ def test_static_consumer_bounce(self, clean_shutdown, static_membership, bounce_

Re: [PR] KAFKA-16465: Fix consumer sys test revocation validation [kafka]

2024-04-26 Thread via GitHub
lucasbru commented on code in PR #15778: URL: https://github.com/apache/kafka/pull/15778#discussion_r1581306529 ## tests/kafkatest/tests/client/consumer_test.py: ## @@ -242,16 +242,15 @@ def test_static_consumer_bounce(self, clean_shutdown, static_membership, bounce_

Re: [PR] KAFKA-16465: Fix consumer sys test revocation validation [kafka]

2024-04-26 Thread via GitHub
lianetm commented on code in PR #15778: URL: https://github.com/apache/kafka/pull/15778#discussion_r1581203195 ## tests/kafkatest/tests/client/consumer_test.py: ## @@ -242,16 +242,15 @@ def test_static_consumer_bounce(self, clean_shutdown, static_membership, bounce_

Re: [PR] KAFKA-16465: Fix consumer sys test revocation validation [kafka]

2024-04-25 Thread via GitHub
lucasbru commented on code in PR #15778: URL: https://github.com/apache/kafka/pull/15778#discussion_r1579343899 ## tests/kafkatest/tests/client/consumer_test.py: ## @@ -242,16 +242,15 @@ def test_static_consumer_bounce(self, clean_shutdown, static_membership, bounce_

Re: [PR] KAFKA-16465: Fix consumer sys test revocation validation [kafka]

2024-04-24 Thread via GitHub
lianetm commented on code in PR #15778: URL: https://github.com/apache/kafka/pull/15778#discussion_r1578363393 ## tests/kafkatest/tests/client/consumer_test.py: ## @@ -242,16 +242,15 @@ def test_static_consumer_bounce(self, clean_shutdown, static_membership, bounce_

Re: [PR] KAFKA-16465: Fix consumer sys test revocation validation [kafka]

2024-04-24 Thread via GitHub
lianetm commented on code in PR #15778: URL: https://github.com/apache/kafka/pull/15778#discussion_r1578363393 ## tests/kafkatest/tests/client/consumer_test.py: ## @@ -242,16 +242,15 @@ def test_static_consumer_bounce(self, clean_shutdown, static_membership, bounce_

Re: [PR] KAFKA-16465: Fix consumer sys test revocation validation [kafka]

2024-04-24 Thread via GitHub
lianetm commented on code in PR #15778: URL: https://github.com/apache/kafka/pull/15778#discussion_r1578363393 ## tests/kafkatest/tests/client/consumer_test.py: ## @@ -242,16 +242,15 @@ def test_static_consumer_bounce(self, clean_shutdown, static_membership, bounce_

Re: [PR] KAFKA-16465: Fix consumer sys test revocation validation [kafka]

2024-04-24 Thread via GitHub
lianetm commented on code in PR #15778: URL: https://github.com/apache/kafka/pull/15778#discussion_r1578363393 ## tests/kafkatest/tests/client/consumer_test.py: ## @@ -242,16 +242,15 @@ def test_static_consumer_bounce(self, clean_shutdown, static_membership, bounce_

Re: [PR] KAFKA-16465: Fix consumer sys test revocation validation [kafka]

2024-04-24 Thread via GitHub
lianetm commented on code in PR #15778: URL: https://github.com/apache/kafka/pull/15778#discussion_r1578363393 ## tests/kafkatest/tests/client/consumer_test.py: ## @@ -242,16 +242,15 @@ def test_static_consumer_bounce(self, clean_shutdown, static_membership, bounce_

Re: [PR] KAFKA-16465: Fix consumer sys test revocation validation [kafka]

2024-04-23 Thread via GitHub
lucasbru commented on code in PR #15778: URL: https://github.com/apache/kafka/pull/15778#discussion_r1575801343 ## tests/kafkatest/tests/client/consumer_test.py: ## @@ -242,16 +242,15 @@ def test_static_consumer_bounce(self, clean_shutdown, static_membership, bounce_

Re: [PR] KAFKA-16465: Fix consumer sys test revocation validation [kafka]

2024-04-22 Thread via GitHub
lianetm commented on PR #15778: URL: https://github.com/apache/kafka/pull/15778#issuecomment-2069255159 Hey @lucasbru , could you take a look when you have a chance? Similar issue to the one on https://github.com/apache/kafka/pull/15661. With this I get successful runs of the test

[PR] KAFKA-16465: Fix consumer sys test revocation validation [kafka]

2024-04-22 Thread via GitHub
lianetm opened a new pull request, #15778: URL: https://github.com/apache/kafka/pull/15778 This fixes a consumer system test that was failing for the new protocol. The failure was because the test was expecting the eager behaviour of partitions being revoked on every rebalance, and it was