mjsax commented on PR #15691:
URL: https://github.com/apache/kafka/pull/15691#issuecomment-2136273221
Yes, Sophie, just this single PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
ableegoldman commented on PR #15691:
URL: https://github.com/apache/kafka/pull/15691#issuecomment-2136212943
Ah thanks Matthias. @fred-ro is this everything we need for KIP-1036?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
mjsax merged PR #15691:
URL: https://github.com/apache/kafka/pull/15691
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
mjsax commented on PR #15691:
URL: https://github.com/apache/kafka/pull/15691#issuecomment-2136172844
Thanks for the KIP an PR @fred-ro! -- Merged to `trunk`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
fred-ro commented on code in PR #15691:
URL: https://github.com/apache/kafka/pull/15691#discussion_r1617602453
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/CompletedFetch.java:
##
@@ -311,25 +312,37 @@ ConsumerRecord parseRecord(Deserializers
fred-ro commented on code in PR #15691:
URL: https://github.com/apache/kafka/pull/15691#discussion_r1617600345
##
clients/src/main/java/org/apache/kafka/common/errors/RecordDeserializationException.java:
##
@@ -17,21 +17,73 @@
package org.apache.kafka.common.errors;
import
fred-ro commented on code in PR #15691:
URL: https://github.com/apache/kafka/pull/15691#discussion_r1617601388
##
clients/src/main/java/org/apache/kafka/common/errors/RecordDeserializationException.java:
##
@@ -17,21 +17,73 @@
package org.apache.kafka.common.errors;
import
mjsax commented on code in PR #15691:
URL: https://github.com/apache/kafka/pull/15691#discussion_r1614074992
##
clients/src/main/java/org/apache/kafka/common/errors/RecordDeserializationException.java:
##
@@ -17,21 +17,73 @@
package org.apache.kafka.common.errors;
import
mjsax commented on code in PR #15691:
URL: https://github.com/apache/kafka/pull/15691#discussion_r1614074321
##
clients/src/main/java/org/apache/kafka/common/errors/RecordDeserializationException.java:
##
@@ -16,29 +16,38 @@
*/
package org.apache.kafka.common.errors;
mjsax commented on code in PR #15691:
URL: https://github.com/apache/kafka/pull/15691#discussion_r1614060982
##
clients/src/main/java/org/apache/kafka/common/errors/RecordDeserializationException.java:
##
@@ -17,21 +17,73 @@
package org.apache.kafka.common.errors;
import
fred-ro commented on code in PR #15691:
URL: https://github.com/apache/kafka/pull/15691#discussion_r1609600830
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/CompletedFetch.java:
##
@@ -311,25 +311,35 @@ ConsumerRecord parseRecord(Deserializers
fvaleri commented on code in PR #15691:
URL: https://github.com/apache/kafka/pull/15691#discussion_r1589379241
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/CompletedFetch.java:
##
@@ -311,25 +311,35 @@ ConsumerRecord parseRecord(Deserializers
AndrewJSchofield commented on code in PR #15691:
URL: https://github.com/apache/kafka/pull/15691#discussion_r1572845716
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/CompletedFetch.java:
##
@@ -311,25 +312,33 @@ ConsumerRecord parseRecord(Deserializers
fred-ro commented on code in PR #15691:
URL: https://github.com/apache/kafka/pull/15691#discussion_r1561429541
##
clients/src/main/java/org/apache/kafka/common/errors/RecordDeserializationException.java:
##
@@ -16,29 +16,38 @@
*/
package org.apache.kafka.common.errors;
fred-ro commented on code in PR #15691:
URL: https://github.com/apache/kafka/pull/15691#discussion_r1561426507
##
clients/src/main/java/org/apache/kafka/common/errors/RecordDeserializationException.java:
##
@@ -16,29 +16,38 @@
*/
package org.apache.kafka.common.errors;
fred-ro commented on code in PR #15691:
URL: https://github.com/apache/kafka/pull/15691#discussion_r1561425249
##
clients/src/main/java/org/apache/kafka/common/errors/RecordDeserializationException.java:
##
@@ -16,29 +16,38 @@
*/
package org.apache.kafka.common.errors;
kirktrue commented on code in PR #15691:
URL: https://github.com/apache/kafka/pull/15691#discussion_r1560342179
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/CompletedFetch.java:
##
@@ -326,7 +327,17 @@ ConsumerRecord parseRecord(Deserializers
fred-ro opened a new pull request, #15691:
URL: https://github.com/apache/kafka/pull/15691
Add raw ConsumerRecord data to RecordDeserialisationException to make DLQ
implementation easier
*Summary of testing strategy (including rationale)
for the feature or bug fix. Unit and/or
18 matches
Mail list logo
