cmccabe commented on PR #15695:
URL: https://github.com/apache/kafka/pull/15695#issuecomment-2050092535
> Should we replace all metadataCache.getControllerId by
getCurrentControllerIdFromOldController if the former is unstable?
The metadata cache is supposed to be used for returning
cmccabe merged PR #15695:
URL: https://github.com/apache/kafka/pull/15695
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
chia7712 commented on PR #15695:
URL: https://github.com/apache/kafka/pull/15695#issuecomment-2049066956
> This PR fixes that by using the controller ID from the
KafkaController.scala, which is obtained directly from the controller znode. It
also adds a new test,
mumrah commented on code in PR #15695:
URL: https://github.com/apache/kafka/pull/15695#discussion_r1560175751
##
core/src/main/scala/kafka/server/KafkaServer.scala:
##
@@ -657,15 +657,19 @@ class KafkaServer(
}
private def createCurrentControllerIdMetric(): Unit = {
-
cmccabe commented on code in PR #15695:
URL: https://github.com/apache/kafka/pull/15695#discussion_r1560167894
##
core/src/main/scala/kafka/server/KafkaServer.scala:
##
@@ -657,15 +657,19 @@ class KafkaServer(
}
private def createCurrentControllerIdMetric(): Unit = {
-
cmccabe commented on code in PR #15695:
URL: https://github.com/apache/kafka/pull/15695#discussion_r1560168052
##
core/src/main/scala/kafka/server/KafkaServer.scala:
##
@@ -657,15 +657,19 @@ class KafkaServer(
}
private def createCurrentControllerIdMetric(): Unit = {
-
mumrah commented on code in PR #15695:
URL: https://github.com/apache/kafka/pull/15695#discussion_r1560161829
##
core/src/main/scala/kafka/server/KafkaServer.scala:
##
@@ -657,15 +657,19 @@ class KafkaServer(
}
private def createCurrentControllerIdMetric(): Unit = {
-
cmccabe opened a new pull request, #15695:
URL: https://github.com/apache/kafka/pull/15695
The CurrentControllerId metric added by KIP-1001 is unreliable in ZK mode.
Sometimes when there is no active ZK-based controller, it still shows the
previous controller ID. Instead, it should show -1
