chia7712 merged PR #15719:
URL: https://github.com/apache/kafka/pull/15719
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
chia7712 commented on PR #15719:
URL: https://github.com/apache/kafka/pull/15719#issuecomment-2067224991
@brandboat please fix the conflicts, thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
chia7712 commented on PR #15719:
URL: https://github.com/apache/kafka/pull/15719#issuecomment-2066133702
@brandboat this PR is great. However, I'd like to merge it after #15569.
#15569 is a huge PR which refactor the `KafkaConfig` and `LogConfig`, and I try
to alleviate the pain of fixing
brandboat commented on PR #15719:
URL: https://github.com/apache/kafka/pull/15719#issuecomment-2066136873
> @brandboat this PR is great. However, I'd like to merge it after
https://github.com/apache/kafka/pull/15569.
https://github.com/apache/kafka/pull/15569 is a huge PR which refactor
brandboat commented on PR #15719:
URL: https://github.com/apache/kafka/pull/15719#issuecomment-2063574931
Thanks for the reminder, soarez ! Already fix the error.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
soarez commented on PR #15719:
URL: https://github.com/apache/kafka/pull/15719#issuecomment-2063477565
Thanks for the changes.
You have some compilation errors:
```
[2024-04-17T15:27:16.786Z] > Task :jmh-benchmarks:compileJava
[2024-04-17T15:27:16.786Z]
brandboat commented on code in PR #15719:
URL: https://github.com/apache/kafka/pull/15719#discussion_r1569022628
##
core/src/test/scala/unit/kafka/log/LogManagerTest.scala:
##
@@ -413,7 +413,7 @@ class LogManagerTest {
assertEquals(numMessages * setSize / segmentBytes,
showuon commented on code in PR #15719:
URL: https://github.com/apache/kafka/pull/15719#discussion_r1568045423
##
core/src/test/scala/unit/kafka/log/LogManagerTest.scala:
##
@@ -413,7 +413,7 @@ class LogManagerTest {
assertEquals(numMessages * setSize / segmentBytes,
chia7712 commented on code in PR #15719:
URL: https://github.com/apache/kafka/pull/15719#discussion_r1567891428
##
core/src/main/java/kafka/server/builders/LogManagerBuilder.java:
##
@@ -55,6 +55,7 @@ public class LogManagerBuilder {
private Time time = Time.SYSTEM;
brandboat commented on code in PR #15719:
URL: https://github.com/apache/kafka/pull/15719#discussion_r1567499221
##
core/src/test/scala/unit/kafka/utils/TestUtils.scala:
##
@@ -1524,7 +1524,8 @@ object TestUtils extends Logging {
logDirFailureChannel = new
soarez commented on code in PR #15719:
URL: https://github.com/apache/kafka/pull/15719#discussion_r1567497368
##
core/src/test/scala/unit/kafka/utils/TestUtils.scala:
##
@@ -1524,7 +1524,8 @@ object TestUtils extends Logging {
logDirFailureChannel = new
brandboat commented on code in PR #15719:
URL: https://github.com/apache/kafka/pull/15719#discussion_r1567464576
##
core/src/test/scala/unit/kafka/utils/TestUtils.scala:
##
@@ -1524,7 +1524,8 @@ object TestUtils extends Logging {
logDirFailureChannel = new
brandboat commented on code in PR #15719:
URL: https://github.com/apache/kafka/pull/15719#discussion_r1567464576
##
core/src/test/scala/unit/kafka/utils/TestUtils.scala:
##
@@ -1524,7 +1524,8 @@ object TestUtils extends Logging {
logDirFailureChannel = new
brandboat commented on code in PR #15719:
URL: https://github.com/apache/kafka/pull/15719#discussion_r1567447761
##
core/src/test/scala/unit/kafka/log/LogManagerTest.scala:
##
@@ -413,7 +413,7 @@ class LogManagerTest {
assertEquals(numMessages * setSize / segmentBytes,
soarez commented on code in PR #15719:
URL: https://github.com/apache/kafka/pull/15719#discussion_r1567422789
##
core/src/test/scala/unit/kafka/utils/TestUtils.scala:
##
@@ -1524,7 +1524,8 @@ object TestUtils extends Logging {
logDirFailureChannel = new
showuon commented on code in PR #15719:
URL: https://github.com/apache/kafka/pull/15719#discussion_r1567254740
##
core/src/main/scala/kafka/server/KafkaConfig.scala:
##
@@ -835,6 +836,7 @@ object KafkaConfig {
.define(CreateTopicPolicyClassNameProp, CLASS, null, LOW,
brandboat opened a new pull request, #15719:
URL: https://github.com/apache/kafka/pull/15719
related to KAFKA-16552,
Introduce a new internal config `log.initial.task.delay.ms` to control
InitialTaskDelayMs in LogManager to speed up tests
### Committer Checklist (excluded from
17 matches
Mail list logo
