chia7712 merged PR #15761:
URL: https://github.com/apache/kafka/pull/15761
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
brandboat commented on code in PR #15761:
URL: https://github.com/apache/kafka/pull/15761#discussion_r1581724166
##
core/src/test/java/kafka/test/ClusterConfigTest.java:
##
@@ -0,0 +1,93 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ *
brandboat commented on code in PR #15761:
URL: https://github.com/apache/kafka/pull/15761#discussion_r1581723855
##
core/src/test/java/kafka/test/ClusterConfigTest.java:
##
@@ -0,0 +1,93 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ *
chia7712 commented on code in PR #15761:
URL: https://github.com/apache/kafka/pull/15761#discussion_r1581597711
##
core/src/test/scala/integration/kafka/server/KafkaServerKRaftRegistrationTest.scala:
##
@@ -71,11 +72,16 @@ class KafkaServerKRaftRegistrationTest {
val
brandboat commented on code in PR #15761:
URL: https://github.com/apache/kafka/pull/15761#discussion_r1580549838
##
core/src/test/java/kafka/test/ClusterTestExtensionsTest.java:
##
@@ -48,14 +51,18 @@ public class ClusterTestExtensionsTest {
// Static methods can
brandboat commented on code in PR #15761:
URL: https://github.com/apache/kafka/pull/15761#discussion_r1580544105
##
core/src/test/java/kafka/test/ClusterConfig.java:
##
@@ -139,28 +151,38 @@ public Map nameTags() {
return tags;
}
-public ClusterConfig
chia7712 commented on code in PR #15761:
URL: https://github.com/apache/kafka/pull/15761#discussion_r1580542830
##
core/src/test/java/kafka/test/ClusterConfig.java:
##
@@ -139,28 +151,38 @@ public Map nameTags() {
return tags;
}
-public ClusterConfig
brandboat commented on code in PR #15761:
URL: https://github.com/apache/kafka/pull/15761#discussion_r1580538394
##
core/src/test/java/kafka/test/ClusterConfig.java:
##
@@ -139,28 +151,38 @@ public Map nameTags() {
return tags;
}
-public ClusterConfig
chia7712 commented on code in PR #15761:
URL: https://github.com/apache/kafka/pull/15761#discussion_r1580536170
##
core/src/test/java/kafka/test/ClusterTestExtensionsTest.java:
##
@@ -48,14 +51,18 @@ public class ClusterTestExtensionsTest {
// Static methods can generate
chia7712 commented on code in PR #15761:
URL: https://github.com/apache/kafka/pull/15761#discussion_r1580535934
##
core/src/test/java/kafka/test/ClusterConfig.java:
##
@@ -139,28 +151,38 @@ public Map nameTags() {
return tags;
}
-public ClusterConfig
brandboat commented on code in PR #15761:
URL: https://github.com/apache/kafka/pull/15761#discussion_r1580532456
##
core/src/test/java/kafka/test/ClusterTestExtensionsTest.java:
##
@@ -48,14 +51,18 @@ public class ClusterTestExtensionsTest {
// Static methods can
brandboat commented on code in PR #15761:
URL: https://github.com/apache/kafka/pull/15761#discussion_r1580532188
##
core/src/test/java/kafka/test/ClusterConfig.java:
##
@@ -139,28 +151,38 @@ public Map nameTags() {
return tags;
}
-public ClusterConfig
chia7712 commented on code in PR #15761:
URL: https://github.com/apache/kafka/pull/15761#discussion_r1580513112
##
core/src/test/scala/integration/kafka/zk/ZkMigrationIntegrationTest.scala:
##
@@ -57,16 +57,18 @@ import org.slf4j.{Logger, LoggerFactory}
import java.util
chia7712 commented on PR #15761:
URL: https://github.com/apache/kafka/pull/15761#issuecomment-2078268366
@brandboat could you please fix the conflicts?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
chia7712 commented on PR #15761:
URL: https://github.com/apache/kafka/pull/15761#issuecomment-2074923817
@brandboat Could you rebase code to trigger QA again? I run those tests on
my local. They pass
--
This is an automated message from the Apache Git Service.
To respond to the message,
brandboat commented on PR #15761:
URL: https://github.com/apache/kafka/pull/15761#issuecomment-2074282565
Failed tests seems related to this pr, I'll check them later.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use
brandboat commented on code in PR #15761:
URL: https://github.com/apache/kafka/pull/15761#discussion_r1577073007
##
core/src/test/java/kafka/testkit/TestKitNodes.java:
##
@@ -198,7 +177,7 @@ public BootstrapMetadata bootstrapMetadata() {
return bootstrapMetadata;
chia7712 commented on code in PR #15761:
URL: https://github.com/apache/kafka/pull/15761#discussion_r1576836597
##
core/src/test/java/kafka/testkit/TestKitNodes.java:
##
@@ -198,7 +177,7 @@ public BootstrapMetadata bootstrapMetadata() {
return bootstrapMetadata;
}
chia7712 commented on code in PR #15761:
URL: https://github.com/apache/kafka/pull/15761#discussion_r1576631689
##
core/src/test/java/kafka/testkit/TestKitNodes.java:
##
@@ -59,87 +63,66 @@ public Builder setCombined(boolean combined) {
}
public Builder
brandboat commented on code in PR #15761:
URL: https://github.com/apache/kafka/pull/15761#discussion_r1576531833
##
core/src/test/scala/unit/kafka/server/ApiVersionsRequestTest.scala:
##
@@ -84,17 +125,38 @@ class ApiVersionsRequestTest(cluster: ClusterInstance)
extends
chia7712 commented on code in PR #15761:
URL: https://github.com/apache/kafka/pull/15761#discussion_r1576492165
##
core/src/test/java/kafka/testkit/BrokerNode.java:
##
@@ -66,17 +69,30 @@ public Builder setNumLogDirectories(int numLogDirectories) {
return this;
brandboat commented on code in PR #15761:
URL: https://github.com/apache/kafka/pull/15761#discussion_r1576432963
##
core/src/test/java/kafka/testkit/BrokerNode.java:
##
@@ -121,16 +146,16 @@ public BrokerNode build(
private final boolean combined;
private final Map
chia7712 commented on code in PR #15761:
URL: https://github.com/apache/kafka/pull/15761#discussion_r1576155040
##
core/src/test/java/kafka/testkit/TestKitNodes.java:
##
@@ -167,11 +186,11 @@ private TestKitNodes(
NavigableMap controllerNodes,
NavigableMap
brandboat commented on PR #15761:
URL: https://github.com/apache/kafka/pull/15761#issuecomment-2072088191
> @brandboat Sorry that I leave more comments below. please take a look.
thanks
Thank you for your patience! I appreciate your input. Already addressed all
comments as above.
brandboat commented on code in PR #15761:
URL: https://github.com/apache/kafka/pull/15761#discussion_r1576056664
##
core/src/test/java/kafka/testkit/BrokerNode.java:
##
@@ -66,11 +74,27 @@ public Builder setNumLogDirectories(int numLogDirectories) {
return this;
chia7712 commented on code in PR #15761:
URL: https://github.com/apache/kafka/pull/15761#discussion_r1575290259
##
core/src/test/java/kafka/testkit/BrokerNode.java:
##
@@ -66,11 +74,27 @@ public Builder setNumLogDirectories(int numLogDirectories) {
return this;
brandboat commented on code in PR #15761:
URL: https://github.com/apache/kafka/pull/15761#discussion_r1575101365
##
core/src/test/java/kafka/test/ClusterConfig.java:
##
@@ -173,63 +199,104 @@ public static class Builder {
private String listenerName;
private
chia7712 commented on code in PR #15761:
URL: https://github.com/apache/kafka/pull/15761#discussion_r1575053494
##
core/src/test/java/kafka/test/ClusterConfig.java:
##
@@ -173,63 +199,104 @@ public static class Builder {
private String listenerName;
private
brandboat commented on code in PR #15761:
URL: https://github.com/apache/kafka/pull/15761#discussion_r1574974316
##
core/src/test/scala/unit/kafka/server/SaslApiVersionsRequestTest.scala:
##
@@ -18,41 +18,58 @@ package kafka.server
import java.net.Socket
import
brandboat commented on code in PR #15761:
URL: https://github.com/apache/kafka/pull/15761#discussion_r1573858499
##
core/src/test/java/kafka/test/ClusterConfig.java:
##
@@ -67,13 +69,16 @@ public class ClusterConfig {
this.listenerName = listenerName;
chia7712 commented on code in PR #15761:
URL: https://github.com/apache/kafka/pull/15761#discussion_r1573857883
##
core/src/test/java/kafka/test/ClusterConfig.java:
##
@@ -67,13 +69,16 @@ public class ClusterConfig {
this.listenerName = listenerName;
brandboat commented on code in PR #15761:
URL: https://github.com/apache/kafka/pull/15761#discussion_r1573855899
##
core/src/test/java/kafka/test/ClusterConfig.java:
##
@@ -67,13 +69,16 @@ public class ClusterConfig {
this.listenerName = listenerName;
brandboat commented on code in PR #15761:
URL: https://github.com/apache/kafka/pull/15761#discussion_r1573852618
##
core/src/test/scala/unit/kafka/server/ApiVersionsRequestTest.scala:
##
@@ -17,48 +17,78 @@
package kafka.server
-import kafka.test.{ClusterConfig,
brandboat commented on code in PR #15761:
URL: https://github.com/apache/kafka/pull/15761#discussion_r1573851263
##
core/src/test/scala/unit/kafka/server/ApiVersionsRequestTest.scala:
##
@@ -17,48 +17,78 @@
package kafka.server
-import kafka.test.{ClusterConfig,
chia7712 commented on code in PR #15761:
URL: https://github.com/apache/kafka/pull/15761#discussion_r1573850549
##
core/src/test/scala/unit/kafka/server/ApiVersionsRequestTest.scala:
##
@@ -17,48 +17,78 @@
package kafka.server
-import kafka.test.{ClusterConfig,
brandboat commented on code in PR #15761:
URL: https://github.com/apache/kafka/pull/15761#discussion_r1573849975
##
core/src/test/scala/unit/kafka/server/ApiVersionsRequestTest.scala:
##
@@ -17,48 +17,78 @@
package kafka.server
-import kafka.test.{ClusterConfig,
chia7712 commented on code in PR #15761:
URL: https://github.com/apache/kafka/pull/15761#discussion_r1573839545
##
core/src/test/java/kafka/test/junit/RaftClusterInvocationContext.java:
##
@@ -290,7 +287,7 @@ public void waitForReadyBrokers() throws
InterruptedException {
37 matches
Mail list logo
