Re: [PR] KAFKA-16647: Remove setMetadataDirectory from BrokerNode/ControllerNode [kafka]

2024-05-01 Thread via GitHub
chia7712 merged PR #15833: URL: https://github.com/apache/kafka/pull/15833 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache

Re: [PR] KAFKA-16647: Remove setMetadataDirectory from BrokerNode/ControllerNode [kafka]

2024-05-01 Thread via GitHub
chia7712 commented on PR #15833: URL: https://github.com/apache/kafka/pull/15833#issuecomment-2089361742 loop the failed tests on my local, and they pass. ``` ./gradlew cleanTest :connect:runtime:test --tests org.apache.kafka.connect.integration.OffsetsApiIntegrationTest.testGetSinkCon

Re: [PR] KAFKA-16647: Remove setMetadataDirectory from BrokerNode/ControllerNode [kafka]

2024-05-01 Thread via GitHub
chia7712 commented on code in PR #15833: URL: https://github.com/apache/kafka/pull/15833#discussion_r1586301225 ## core/src/test/java/kafka/testkit/BrokerNode.java: ## @@ -95,6 +89,9 @@ public BrokerNode build() { if (id == -1) { throw new RuntimeEx

[PR] KAFKA-16647: Remove setMetadataDirectory from BrokerNode/ControllerNode [kafka]

2024-04-30 Thread via GitHub
brandboat opened a new pull request, #15833: URL: https://github.com/apache/kafka/pull/15833 related to https://issues.apache.org/jira/browse/KAFKA-16647 ### Committer Checklist (excluded from commit message) - [ ] Verify design and implementation - [ ] Verify test coverage and