Re: [PR] KAFKA-16688: Use helper method to shutdown ExecutorService [kafka]

2024-05-12 Thread via GitHub
apoorvmittal10 commented on PR #15886: URL: https://github.com/apache/kafka/pull/15886#issuecomment-2106239456 Thanks @gaurav-narula for fixing it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

Re: [PR] KAFKA-16688: Use helper method to shutdown ExecutorService [kafka]

2024-05-10 Thread via GitHub
soarez merged PR #15886: URL: https://github.com/apache/kafka/pull/15886 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] KAFKA-16688: Use helper method to shutdown ExecutorService [kafka]

2024-05-09 Thread via GitHub
chia7712 commented on PR #15886: URL: https://github.com/apache/kafka/pull/15886#issuecomment-2103753542 agree to @soarez observation. I feel this patch can get merged to save all Kafka developers life. #15891 can revert this patch to observe which timer task gets hanging. -- This is

Re: [PR] KAFKA-16688: Use helper method to shutdown ExecutorService [kafka]

2024-05-08 Thread via GitHub
gaurav-narula commented on PR #15886: URL: https://github.com/apache/kafka/pull/15886#issuecomment-2100220810 > Before merging this PR, I want to know which `timerTask` gets hanging when shutdown. Do you have any idea? I don't unfortunately but I see you're trying to investigate that

Re: [PR] KAFKA-16688: Use helper method to shutdown ExecutorService [kafka]

2024-05-07 Thread via GitHub
chia7712 commented on PR #15886: URL: https://github.com/apache/kafka/pull/15886#issuecomment-2099705033 @gaurav-narula thanks for your fix. Before merging this PR, I want to know which `timerTask` gets hanging when shutdown. Do you have any idea? -- This is an automated message from

Re: [PR] KAFKA-16688: Use helper method to shutdown ExecutorService [kafka]

2024-05-07 Thread via GitHub
gaurav-narula commented on PR #15886: URL: https://github.com/apache/kafka/pull/15886#issuecomment-2099506624 CC: @soarez @chia7712 I came across this in the [CI pipeline run](https://ci-builds.apache.org/blue/organizations/jenkins/Kafka%2Fkafka-pr/detail/PR-15885/1/tests) for

[PR] KAFKA-16688: Use helper method to shutdown ExecutorService [kafka]

2024-05-07 Thread via GitHub
gaurav-narula opened a new pull request, #15886: URL: https://github.com/apache/kafka/pull/15886 We observe some thread leaks in CI which point to the executor service thread. This change tries to shutdown the executor service using the helper method in `ThreadUtils`. ### Committer