Re: [PR] KAFKA-7504 Mitigate sendfile(2) blocking in network threads by waming up fetch data [kafka]

2024-02-22 Thread via GitHub
ocadaruma commented on code in PR #14289: URL: https://github.com/apache/kafka/pull/14289#discussion_r1499548503 ## storage/src/main/java/org/apache/kafka/storage/internals/log/FetchDataInfo.java: ## @@ -39,19 +40,40 @@ public FetchDataInfo(LogOffsetMetadata

Re: [PR] KAFKA-7504 Mitigate sendfile(2) blocking in network threads by waming up fetch data [kafka]

2024-02-22 Thread via GitHub
ocadaruma commented on code in PR #14289: URL: https://github.com/apache/kafka/pull/14289#discussion_r1499537446 ## core/src/main/scala/kafka/server/ReplicaManager.scala: ## @@ -1408,6 +1408,16 @@ class ReplicaManager(val config: KafkaConfig, // progress in such cases

Re: [PR] KAFKA-7504 Mitigate sendfile(2) blocking in network threads by waming up fetch data [kafka]

2024-02-18 Thread via GitHub
showuon commented on code in PR #14289: URL: https://github.com/apache/kafka/pull/14289#discussion_r1493974832 ## core/src/main/scala/kafka/server/ReplicaManager.scala: ## @@ -1408,6 +1408,16 @@ class ReplicaManager(val config: KafkaConfig, // progress in such cases

Re: [PR] KAFKA-7504 Mitigate sendfile(2) blocking in network threads by waming up fetch data [kafka]

2024-02-18 Thread via GitHub
ocadaruma commented on code in PR #14289: URL: https://github.com/apache/kafka/pull/14289#discussion_r1493877586 ## clients/src/main/java/org/apache/kafka/common/record/FileRecords.java: ## @@ -421,6 +446,18 @@ private AbstractIterator batchIterator(int start) {

Re: [PR] KAFKA-7504 Mitigate sendfile(2) blocking in network threads by waming up fetch data [kafka]

2024-02-18 Thread via GitHub
ocadaruma commented on code in PR #14289: URL: https://github.com/apache/kafka/pull/14289#discussion_r1493877586 ## clients/src/main/java/org/apache/kafka/common/record/FileRecords.java: ## @@ -421,6 +446,18 @@ private AbstractIterator batchIterator(int start) {

Re: [PR] KAFKA-7504 Mitigate sendfile(2) blocking in network threads by waming up fetch data [kafka]

2024-02-18 Thread via GitHub
ocadaruma commented on code in PR #14289: URL: https://github.com/apache/kafka/pull/14289#discussion_r1493875931 ## clients/src/main/java/org/apache/kafka/common/record/FileRecords.java: ## @@ -421,6 +446,18 @@ private AbstractIterator batchIterator(int start) {

Re: [PR] KAFKA-7504 Mitigate sendfile(2) blocking in network threads by waming up fetch data [kafka]

2024-02-09 Thread via GitHub
divijvaidya commented on code in PR #14289: URL: https://github.com/apache/kafka/pull/14289#discussion_r1484189476 ## clients/src/main/java/org/apache/kafka/common/record/FileRecords.java: ## @@ -421,6 +446,18 @@ private AbstractIterator batchIterator(int start) {