wcarlson5 commented on PR #15414:
URL: https://github.com/apache/kafka/pull/15414#issuecomment-1962002805
I might need to add a couple of unit tests, but I think it could use a
review when you got time @mjsax !
--
This is an automated message from the Apache Git Service.
To respond to
wcarlson5 commented on code in PR #15414:
URL: https://github.com/apache/kafka/pull/15414#discussion_r1501173995
##
streams/src/test/java/org/apache/kafka/streams/integration/GlobalThreadShutDownOrderTest.java:
##
@@ -120,23 +119,11 @@ public void before(final TestInfo
wcarlson5 commented on code in PR #15414:
URL: https://github.com/apache/kafka/pull/15414#discussion_r1498391601
##
streams/src/main/java/org/apache/kafka/streams/kstream/internals/graph/TableSourceNode.java:
##
@@ -105,7 +105,8 @@ public void writeToTopology(final
wcarlson5 commented on code in PR #15414:
URL: https://github.com/apache/kafka/pull/15414#discussion_r1498387326
##
streams/src/main/java/org/apache/kafka/streams/Topology.java:
##
@@ -783,7 +783,8 @@ public synchronized Topology addGlobalStore(final
StoreBuilder storeBu
wcarlson5 opened a new pull request, #15414:
URL: https://github.com/apache/kafka/pull/15414
When custom processors are added via `StreamBuilder#addGlobalStore` they
will now reprocess all records through the custom transformer instead of
loading directly.
We do this so that users
