Re: [PR] KAFKA-8977: Remove MockStreamsMetrics since it is not a mock [kafka]

2024-06-02 Thread via GitHub
chia7712 commented on PR #13931: URL: https://github.com/apache/kafka/pull/13931#issuecomment-2143994107 @joobisb any updates? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment

Re: [PR] KAFKA-8977: Remove MockStreamsMetrics since it is not a mock [kafka]

2024-02-15 Thread via GitHub
cadonna commented on code in PR #13931: URL: https://github.com/apache/kafka/pull/13931#discussion_r1489430066 ## streams/src/test/java/org/apache/kafka/streams/processor/internals/RecordCollectorTest.java: ## @@ -138,11 +150,30 @@ public class RecordCollectorTest { private

Re: [PR] KAFKA-8977: Remove MockStreamsMetrics since it is not a mock [kafka]

2024-02-15 Thread via GitHub
joobisb commented on PR #13931: URL: https://github.com/apache/kafka/pull/13931#issuecomment-1945902179 > @joobisb Could you please fix the compilation errors? @cadonna done -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitH

Re: [PR] KAFKA-8977: Remove MockStreamsMetrics since it is not a mock [kafka]

2024-02-14 Thread via GitHub
cadonna commented on PR #13931: URL: https://github.com/apache/kafka/pull/13931#issuecomment-1943728460 @joobisb Could you please fix the compilation errors? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL abov

Re: [PR] KAFKA-8977: Remove MockStreamsMetrics since it is not a mock [kafka]

2024-02-14 Thread via GitHub
joobisb commented on PR #13931: URL: https://github.com/apache/kafka/pull/13931#issuecomment-1943338949 @cadonna i've addressed the changes and fixed merge conflicts, could you please take a look -- This is an automated message from the Apache Git Service. To respond to the message, p

Re: [PR] KAFKA-8977: Remove MockStreamsMetrics since it is not a mock [kafka]

2023-11-03 Thread via GitHub
github-actions[bot] commented on PR #13931: URL: https://github.com/apache/kafka/pull/13931#issuecomment-1793324234 This PR is being marked as stale since it has not had any activity in 90 days. If you would like to keep this PR alive, please ask a committer for review. If the PR has merge