jsancio merged PR #15478:
URL: https://github.com/apache/kafka/pull/15478
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
jsancio commented on code in PR #15478:
URL: https://github.com/apache/kafka/pull/15478#discussion_r1523954492
##
core/src/main/scala/kafka/raft/KafkaMetadataLog.scala:
##
@@ -348,14 +357,15 @@ final class KafkaMetadataLog private (
snapshotId.offset <=
jsancio commented on code in PR #15478:
URL: https://github.com/apache/kafka/pull/15478#discussion_r1523951275
##
core/src/main/scala/kafka/raft/KafkaMetadataLog.scala:
##
@@ -404,21 +414,33 @@ final class KafkaMetadataLog private (
* all cases.
*
* For the given
mumrah commented on code in PR #15478:
URL: https://github.com/apache/kafka/pull/15478#discussion_r1523630806
##
core/src/main/scala/kafka/raft/KafkaMetadataLog.scala:
##
@@ -404,21 +414,33 @@ final class KafkaMetadataLog private (
* all cases.
*
* For the given
hni61223 commented on code in PR #15478:
URL: https://github.com/apache/kafka/pull/15478#discussion_r1514278368
##
core/src/main/scala/kafka/raft/KafkaMetadataLog.scala:
##
@@ -677,4 +675,38 @@ object KafkaMetadataLog extends Logging {
Snapshots.deleteIfExists(logDir,
hni61223 commented on code in PR #15478:
URL: https://github.com/apache/kafka/pull/15478#discussion_r1514278368
##
core/src/main/scala/kafka/raft/KafkaMetadataLog.scala:
##
@@ -677,4 +675,38 @@ object KafkaMetadataLog extends Logging {
Snapshots.deleteIfExists(logDir,
jsancio opened a new pull request, #15478:
URL: https://github.com/apache/kafka/pull/15478
There are three reasons why KRaft would delete a snapshot. One, it is older
than the retention time. Two, the total number of bytes between the log and the
snapshot excess the configuration. Three,
