Re: [PR] MINOR: Add javadoc to all ConfigDef.Types values [kafka]

2023-10-11 Thread via GitHub
mimaison merged PR #14515: URL: https://github.com/apache/kafka/pull/14515 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] MINOR: Add javadoc to all ConfigDef.Types values [kafka]

2023-10-11 Thread via GitHub
jlprat commented on code in PR #14515: URL: https://github.com/apache/kafka/pull/14515#discussion_r1355074869 ## clients/src/main/java/org/apache/kafka/common/config/ConfigDef.java: ## @@ -802,11 +802,63 @@ else if (value instanceof Class) } /** - * The config

Re: [PR] MINOR: Add javadoc to all ConfigDef.Types values [kafka]

2023-10-09 Thread via GitHub
mimaison commented on code in PR #14515: URL: https://github.com/apache/kafka/pull/14515#discussion_r1350502430 ## clients/src/main/java/org/apache/kafka/common/config/ConfigDef.java: ## @@ -802,11 +802,63 @@ else if (value instanceof Class) } /** - * The config

Re: [PR] MINOR: Add javadoc to all ConfigDef.Types values [kafka]

2023-10-09 Thread via GitHub
mimaison commented on code in PR #14515: URL: https://github.com/apache/kafka/pull/14515#discussion_r1350501171 ## clients/src/main/java/org/apache/kafka/common/config/ConfigDef.java: ## @@ -57,7 +57,7 @@ * defs.define(config_with_default, Type.STRING, default string value,

[PR] MINOR: Add javadoc to all ConfigDef.Types values [kafka]

2023-10-09 Thread via GitHub
mimaison opened a new pull request, #14515: URL: https://github.com/apache/kafka/pull/14515 ### Committer Checklist (excluded from commit message) - [ ] Verify design and implementation - [ ] Verify test coverage and CI build status - [ ] Verify documentation (including