Re: [PR] MINOR: Add test case for follower fetch [kafka]

2024-01-17 Thread via GitHub
showuon merged PR #14212: URL: https://github.com/apache/kafka/pull/14212 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] MINOR: Add test case for follower fetch [kafka]

2024-01-12 Thread via GitHub
divijvaidya commented on PR #14212: URL: https://github.com/apache/kafka/pull/14212#issuecomment-1888902813 Apologies for the delay. This dropped off my radar. I don't fully understand why first fetch call wouldn't move start offset directly to 5 but that's on me. I need to dig a bit more

Re: [PR] MINOR: Add test case for follower fetch [kafka]

2024-01-11 Thread via GitHub
showuon commented on PR #14212: URL: https://github.com/apache/kafka/pull/14212#issuecomment-1888514023 @divijvaidya , do you want to have another look at this PR? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

Re: [PR] MINOR: Add test case for follower fetch [kafka]

2024-01-11 Thread via GitHub
github-actions[bot] commented on PR #14212: URL: https://github.com/apache/kafka/pull/14212#issuecomment-1888380213 This PR is being marked as stale since it has not had any activity in 90 days. If you would like to keep this PR alive, please ask a committer for review. If the PR has

Re: [PR] MINOR: Add test case for follower fetch [kafka]

2023-10-06 Thread via GitHub
nikramakrishnan commented on PR #14212: URL: https://github.com/apache/kafka/pull/14212#issuecomment-1750844756 @showuon @divijvaidya thanks for your reviews! I have addressed all the comments, and believe this PR is ready to be merged. -- This is an automated message from the Apache Git