Re: [PR] MINOR: Change KStreamKstreamOuterJoinTest to use distinct left and right types [kafka]

2024-05-30 Thread via GitHub
gharris1727 commented on code in PR #15513: URL: https://github.com/apache/kafka/pull/15513#discussion_r1621400369 ## streams/src/test/java/org/apache/kafka/streams/kstream/internals/KStreamKStreamOuterJoinTest.java: ## @@ -737,12 +739,12 @@ public void runOuterJoin(final

Re: [PR] MINOR: Change KStreamKstreamOuterJoinTest to use distinct left and right types [kafka]

2024-05-28 Thread via GitHub
cadonna commented on code in PR #15513: URL: https://github.com/apache/kafka/pull/15513#discussion_r1617320224 ## streams/src/test/java/org/apache/kafka/streams/kstream/internals/KStreamKStreamOuterJoinTest.java: ## @@ -737,12 +739,12 @@ public void runOuterJoin(final

[PR] MINOR: Change KStreamKstreamOuterJoinTest to use distinct left and right types [kafka]

2024-03-11 Thread via GitHub
gharris1727 opened a new pull request, #15513: URL: https://github.com/apache/kafka/pull/15513 This test uses the same value types on the left and right, and so wouldn't be sensitive to a mixup between left and right values. So I changed one of the stream types to `Long`, and updated the