Re: [PR] MINOR: Enable kraft test in kafka.api and kafka.network [kafka]

2024-01-10 Thread via GitHub
dengziming commented on code in PR #14595: URL: https://github.com/apache/kafka/pull/14595#discussion_r1448252557 ## core/src/test/scala/integration/kafka/api/RackAwareAutoTopicCreationTest.scala: ## @@ -35,31 +37,37 @@ class RackAwareAutoTopicCreationTest extends

Re: [PR] MINOR: Enable kraft test in kafka.api and kafka.network [kafka]

2024-01-09 Thread via GitHub
dengziming commented on code in PR #14595: URL: https://github.com/apache/kafka/pull/14595#discussion_r1446812841 ## core/src/test/scala/integration/kafka/api/RackAwareAutoTopicCreationTest.scala: ## @@ -35,31 +37,37 @@ class RackAwareAutoTopicCreationTest extends

Re: [PR] MINOR: Enable kraft test in kafka.api and kafka.network [kafka]

2024-01-09 Thread via GitHub
mimaison commented on code in PR #14595: URL: https://github.com/apache/kafka/pull/14595#discussion_r1446558104 ## core/src/test/scala/integration/kafka/api/RackAwareAutoTopicCreationTest.scala: ## @@ -35,31 +37,37 @@ class RackAwareAutoTopicCreationTest extends

Re: [PR] MINOR: Enable kraft test in kafka.api and kafka.network [kafka]

2024-01-05 Thread via GitHub
mimaison commented on PR #14595: URL: https://github.com/apache/kafka/pull/14595#issuecomment-1878961224 Thanks for the PR. It fails compiling: ``` > Task :core:compileTestScala [Error]

Re: [PR] MINOR: Enable kraft test in kafka.api and kafka.network [kafka]

2023-11-07 Thread via GitHub
tinaselenge commented on code in PR #14595: URL: https://github.com/apache/kafka/pull/14595#discussion_r1384847563 ## core/src/test/scala/integration/kafka/api/ProducerSendWhileDeletionTest.scala: ## @@ -1,83 +1,87 @@ /** - * Licensed to the Apache Software Foundation (ASF)

Re: [PR] MINOR: Enable kraft test in kafka.api and kafka.network [kafka]

2023-11-07 Thread via GitHub
tinaselenge commented on code in PR #14595: URL: https://github.com/apache/kafka/pull/14595#discussion_r1384847563 ## core/src/test/scala/integration/kafka/api/ProducerSendWhileDeletionTest.scala: ## @@ -1,83 +1,87 @@ /** - * Licensed to the Apache Software Foundation (ASF)

Re: [PR] MINOR: Enable kraft test in kafka.api and kafka.network [kafka]

2023-11-01 Thread via GitHub
dengziming commented on PR #14595: URL: https://github.com/apache/kafka/pull/14595#issuecomment-1790107126 Hello @cmccabe @jsancio , no flaky is found in the latest 4 builds, please take a look。 -- This is an automated message from the Apache Git Service. To respond to the message,

Re: [PR] MINOR: Enable kraft test in kafka.api and kafka.network [kafka]

2023-11-01 Thread via GitHub
dengziming commented on PR #14595: URL: https://github.com/apache/kafka/pull/14595#issuecomment-1790105902 I triggered the CI 5 times, only `ConsumerBounceTest` is flaky and all other tests succeed, I have reverted `ConsumerBounceTest` and convert it in the future.

[PR] MINOR: Enable kraft test in kafka.api and kafka.network [kafka]

2023-10-19 Thread via GitHub
dengziming opened a new pull request, #14595: URL: https://github.com/apache/kafka/pull/14595 *More detailed description of your change, if necessary. The PR title and PR message become the squashed commit message, so use a separate comment to ping reviewers.* *Summary of