Re: [PR] MINOR: Fix NPE during fetchSnapshot [kafka]

2024-01-29 Thread via GitHub
showuon commented on PR #14615: URL: https://github.com/apache/kafka/pull/14615#issuecomment-1916003844 [KAFKA-16209](https://issues.apache.org/jira/browse/KAFKA-16209) is created for this issue. Closing this stale PR. -- This is an automated message from the Apache Git Service. To

Re: [PR] MINOR: Fix NPE during fetchSnapshot [kafka]

2024-01-29 Thread via GitHub
showuon closed pull request #14615: MINOR: Fix NPE during fetchSnapshot URL: https://github.com/apache/kafka/pull/14615 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

Re: [PR] MINOR: Fix NPE during fetchSnapshot [kafka]

2024-01-25 Thread via GitHub
showuon commented on PR #14615: URL: https://github.com/apache/kafka/pull/14615#issuecomment-1911583945 @Nickstery , are you still able to address the comments? I'll ask for the community's help if you are not available. Thanks. -- This is an automated message from the Apache Git

Re: [PR] MINOR: Fix NPE during fetchSnapshot [kafka]

2024-01-25 Thread via GitHub
github-actions[bot] commented on PR #14615: URL: https://github.com/apache/kafka/pull/14615#issuecomment-1911402809 This PR is being marked as stale since it has not had any activity in 90 days. If you would like to keep this PR alive, please ask a committer for review. If the PR has

Re: [PR] MINOR: Fix NPE during fetchSnapshot [kafka]

2023-10-25 Thread via GitHub
hudeqi commented on code in PR #14615: URL: https://github.com/apache/kafka/pull/14615#discussion_r1372501784 ## storage/src/main/java/org/apache/kafka/storage/internals/log/ProducerStateManager.java: ## @@ -595,7 +595,7 @@ public void deleteSnapshotsBefore(long offset) throws