chia7712 commented on PR #15722:
URL: https://github.com/apache/kafka/pull/15722#issuecomment-2069517654
@emitskevich-blp Thanks for fixing the incorrect docs :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
chia7712 merged PR #15722:
URL: https://github.com/apache/kafka/pull/15722
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
chia7712 commented on PR #15722:
URL: https://github.com/apache/kafka/pull/15722#issuecomment-2069514738
all failed tests pass on my local. merge it
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
emitskevich-blp commented on code in PR #15722:
URL: https://github.com/apache/kafka/pull/15722#discussion_r1573473787
##
clients/src/test/java/org/apache/kafka/common/network/SelectorTest.java:
##
@@ -1012,6 +1013,28 @@ public void testChannelCloseWhileProcessingReceives()
chia7712 commented on code in PR #15722:
URL: https://github.com/apache/kafka/pull/15722#discussion_r1573465932
##
clients/src/test/java/org/apache/kafka/common/network/SelectorTest.java:
##
@@ -1012,6 +1013,28 @@ public void testChannelCloseWhileProcessingReceives()
throws
chia7712 commented on code in PR #15722:
URL: https://github.com/apache/kafka/pull/15722#discussion_r1573465553
##
clients/src/test/java/org/apache/kafka/common/network/SelectorTest.java:
##
@@ -1012,6 +1013,28 @@ public void testChannelCloseWhileProcessingReceives()
throws
emitskevich-blp commented on code in PR #15722:
URL: https://github.com/apache/kafka/pull/15722#discussion_r1573458599
##
clients/src/test/java/org/apache/kafka/common/network/SelectorTest.java:
##
@@ -1012,6 +1013,28 @@ public void testChannelCloseWhileProcessingReceives()
emitskevich-blp commented on code in PR #15722:
URL: https://github.com/apache/kafka/pull/15722#discussion_r1573458599
##
clients/src/test/java/org/apache/kafka/common/network/SelectorTest.java:
##
@@ -1012,6 +1013,28 @@ public void testChannelCloseWhileProcessingReceives()
emitskevich-blp commented on code in PR #15722:
URL: https://github.com/apache/kafka/pull/15722#discussion_r1573458599
##
clients/src/test/java/org/apache/kafka/common/network/SelectorTest.java:
##
@@ -1012,6 +1013,28 @@ public void testChannelCloseWhileProcessingReceives()
emitskevich-blp commented on code in PR #15722:
URL: https://github.com/apache/kafka/pull/15722#discussion_r1573454740
##
clients/src/main/java/org/apache/kafka/common/network/Selector.java:
##
@@ -1281,14 +1281,14 @@ private Meter createMeter(Metrics metrics, String
chia7712 commented on code in PR #15722:
URL: https://github.com/apache/kafka/pull/15722#discussion_r1573445048
##
clients/src/main/java/org/apache/kafka/common/network/Selector.java:
##
@@ -1281,14 +1281,14 @@ private Meter createMeter(Metrics metrics, String
groupName, Map
emitskevich-blp commented on PR #15722:
URL: https://github.com/apache/kafka/pull/15722#issuecomment-2067299812
> we should verify the non-deprecated metrics should have correct doc which
is not marked as "deprecated". Also, that is what you try to fix, right?
Correct, this is the
chia7712 commented on PR #15722:
URL: https://github.com/apache/kafka/pull/15722#issuecomment-2066283854
> Effectively, such test would verify the behavior of deprecated method.
What do you think?
we should verify the non-deprecated metrics should have correct doc which is
not
emitskevich-blp commented on PR #15722:
URL: https://github.com/apache/kafka/pull/15722#issuecomment-2064749720
Is it possible to add unit test?
> I'm not sure whether it's needed here. Effectively, such test would verify
the behavior of deprecated method. What do you think?
We
emitskevich-blp commented on code in PR #15722:
URL: https://github.com/apache/kafka/pull/15722#discussion_r1571063662
##
clients/src/main/java/org/apache/kafka/common/network/Selector.java:
##
@@ -1281,14 +1281,14 @@ private Meter createMeter(Metrics metrics, String
emitskevich-blp commented on code in PR #15722:
URL: https://github.com/apache/kafka/pull/15722#discussion_r1571063662
##
clients/src/main/java/org/apache/kafka/common/network/Selector.java:
##
@@ -1281,14 +1281,14 @@ private Meter createMeter(Metrics metrics, String
emitskevich-blp commented on code in PR #15722:
URL: https://github.com/apache/kafka/pull/15722#discussion_r1569005969
##
clients/src/main/java/org/apache/kafka/common/network/Selector.java:
##
@@ -1281,14 +1281,14 @@ private Meter createMeter(Metrics metrics, String
emitskevich-blp commented on code in PR #15722:
URL: https://github.com/apache/kafka/pull/15722#discussion_r1569005969
##
clients/src/main/java/org/apache/kafka/common/network/Selector.java:
##
@@ -1281,14 +1281,14 @@ private Meter createMeter(Metrics metrics, String
chia7712 commented on code in PR #15722:
URL: https://github.com/apache/kafka/pull/15722#discussion_r1568836486
##
clients/src/main/java/org/apache/kafka/common/network/Selector.java:
##
@@ -1281,14 +1281,14 @@ private Meter createMeter(Metrics metrics, String
groupName, Map
emitskevich-blp commented on PR #15722:
URL: https://github.com/apache/kafka/pull/15722#issuecomment-2059230580
This is potentially related to [KIP-773
changes](https://github.com/apache/kafka/pull/11302)
@jlprat
--
This is an automated message from the Apache Git Service.
To respond
emitskevich-blp commented on PR #15722:
URL: https://github.com/apache/kafka/pull/15722#issuecomment-2059223960
Tests failure is unrelated to PR changes
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
emitskevich-blp opened a new pull request, #15722:
URL: https://github.com/apache/kafka/pull/15722
[Implementation of KIP-773](https://github.com/apache/kafka/pull/11302)
deprecated `iotime-total` and `io-waittime-total` metrics. It wasn't expected
to mark `io-ratio` and `io-wait-ratio`
22 matches
Mail list logo
