Re: [PR] MINOR: Query before creating the internal remote log metadata topic [kafka]

2023-11-24 Thread via GitHub
apoorvmittal10 commented on code in PR #14755: URL: https://github.com/apache/kafka/pull/14755#discussion_r1404599341 ## storage/src/test/java/org/apache/kafka/server/log/remote/metadata/storage/TopicBasedRemoteLogMetadataManagerTest.java: ## @@ -66,6 +69,28 @@ public

Re: [PR] MINOR: Query before creating the internal remote log metadata topic [kafka]

2023-11-24 Thread via GitHub
kamalcph commented on code in PR #14755: URL: https://github.com/apache/kafka/pull/14755#discussion_r1404579784 ## storage/src/test/java/org/apache/kafka/server/log/remote/metadata/storage/TopicBasedRemoteLogMetadataManagerTest.java: ## @@ -66,6 +69,28 @@ public

Re: [PR] MINOR: Query before creating the internal remote log metadata topic [kafka]

2023-11-24 Thread via GitHub
apoorvmittal10 commented on code in PR #14755: URL: https://github.com/apache/kafka/pull/14755#discussion_r1404552551 ## storage/src/test/java/org/apache/kafka/server/log/remote/metadata/storage/TopicBasedRemoteLogMetadataManagerTest.java: ## @@ -66,6 +69,28 @@ public

Re: [PR] MINOR: Query before creating the internal remote log metadata topic [kafka]

2023-11-20 Thread via GitHub
satishd merged PR #14755: URL: https://github.com/apache/kafka/pull/14755 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] MINOR: Query before creating the internal remote log metadata topic [kafka]

2023-11-20 Thread via GitHub
satishd commented on PR #14755: URL: https://github.com/apache/kafka/pull/14755#issuecomment-1818520993 There are unrelated test failures in the Jenkins jobs. Merging it to trunk. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

Re: [PR] MINOR: Query before creating the internal remote log metadata topic [kafka]

2023-11-16 Thread via GitHub
clolov commented on code in PR #14755: URL: https://github.com/apache/kafka/pull/14755#discussion_r1396132873 ## storage/src/main/java/org/apache/kafka/server/log/remote/metadata/storage/TopicBasedRemoteLogMetadataManager.java: ## @@ -446,6 +449,20 @@ private void

Re: [PR] MINOR: Query before creating the internal remote log metadata topic [kafka]

2023-11-15 Thread via GitHub
kamalcph commented on PR #14755: URL: https://github.com/apache/kafka/pull/14755#issuecomment-1813827068 @satishd Addressed your review comments. PTAL. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

Re: [PR] MINOR: Query before creating the internal remote log metadata topic [kafka]

2023-11-15 Thread via GitHub
kamalcph commented on code in PR #14755: URL: https://github.com/apache/kafka/pull/14755#discussion_r1395176822 ## storage/src/main/java/org/apache/kafka/server/log/remote/metadata/storage/TopicBasedRemoteLogMetadataManager.java: ## @@ -477,20 +492,22 @@ private NewTopic

Re: [PR] MINOR: Query before creating the internal remote log metadata topic [kafka]

2023-11-15 Thread via GitHub
satishd commented on code in PR #14755: URL: https://github.com/apache/kafka/pull/14755#discussion_r1395121310 ## storage/src/main/java/org/apache/kafka/server/log/remote/metadata/storage/TopicBasedRemoteLogMetadataManager.java: ## @@ -477,20 +492,22 @@ private NewTopic

Re: [PR] MINOR: Query before creating the internal remote log metadata topic [kafka]

2023-11-15 Thread via GitHub
kamalcph commented on PR #14755: URL: https://github.com/apache/kafka/pull/14755#issuecomment-1812555386 The test failures are unrelated to this PR: ``` Build / JDK 17 and Scala 2.13 / testFailureToFenceEpoch(String).quorum=kraft – kafka.api.TransactionsTest 38s Build / JDK

[PR] MINOR: Query before creating the internal remote log metadata topic [kafka]

2023-11-14 Thread via GitHub
kamalcph opened a new pull request, #14755: URL: https://github.com/apache/kafka/pull/14755 When a node starts (or) restarts, then we send a _CREATE_TOPICS_ request to the controller to create the internal ___remote_log_metadata_ topic if it doesn't exist. Topic creation event is