Re: [PR] MINOR: Remove dead code of metric forward-rate [kafka]

2024-04-10 Thread via GitHub
cadonna merged PR #15686: URL: https://github.com/apache/kafka/pull/15686 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.

Re: [PR] MINOR: Remove dead code of metric forward-rate [kafka]

2024-04-09 Thread via GitHub
chia7712 commented on PR #15686: URL: https://github.com/apache/kafka/pull/15686#issuecomment-2045606629 > Did we decide to completely remove KIP-557 or to just disable it and fix it later? you are right. we didn't do the cleanup for KIP-557. please ignore my comment. -- This is a

Re: [PR] MINOR: Remove dead code of metric forward-rate [kafka]

2024-04-09 Thread via GitHub
cadonna commented on PR #15686: URL: https://github.com/apache/kafka/pull/15686#issuecomment-2045462043 > It seems `skippedIdempotentUpdatesSensor` ( > > https://github.com/apache/kafka/blob/f895ab5145077c5efa10a4a898628d901b01e2c2/streams/src/main/java/org/apache/kafka/streams/proces

Re: [PR] MINOR: Remove dead code of metric forward-rate [kafka]

2024-04-09 Thread via GitHub
chia7712 commented on PR #15686: URL: https://github.com/apache/kafka/pull/15686#issuecomment-2045021546 It seems `skippedIdempotentUpdatesSensor` (https://github.com/apache/kafka/blob/f895ab5145077c5efa10a4a898628d901b01e2c2/streams/src/main/java/org/apache/kafka/streams/processor/internals

[PR] MINOR: Remove dead code of metric forward-rate [kafka]

2024-04-09 Thread via GitHub
cadonna opened a new pull request, #15686: URL: https://github.com/apache/kafka/pull/15686 Kafka Streams announced the removal of metric forward-rate in KIP-444 and removed it completely in AK 3.0. However, we forgot to remove some code for this metric. This commit removes the code to c