cmccabe commented on code in PR #14628:
URL: https://github.com/apache/kafka/pull/14628#discussion_r1411139366
##
core/src/main/scala/kafka/server/KafkaServer.scala:
##
@@ -1048,20 +1054,15 @@ class KafkaServer(
*
* @return The brokerId.
*/
- private def
ijuma commented on code in PR #14628:
URL: https://github.com/apache/kafka/pull/14628#discussion_r1398324375
##
core/src/main/scala/kafka/server/KafkaServer.scala:
##
@@ -1048,20 +1054,15 @@ class KafkaServer(
*
* @return The brokerId.
*/
- private def
cmccabe merged PR #14628:
URL: https://github.com/apache/kafka/pull/14628
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
cmccabe commented on code in PR #14628:
URL: https://github.com/apache/kafka/pull/14628#discussion_r1386983421
##
core/src/main/scala/kafka/server/KafkaServer.scala:
##
@@ -270,10 +271,31 @@ class KafkaServer(
logDirFailureChannel = new
cmccabe commented on code in PR #14628:
URL: https://github.com/apache/kafka/pull/14628#discussion_r1386175030
##
metadata/src/main/java/org/apache/kafka/metadata/properties/MetaPropertiesEnsemble.java:
##
@@ -0,0 +1,575 @@
+/*
+ * Licensed to the Apache Software Foundation
cmccabe commented on code in PR #14628:
URL: https://github.com/apache/kafka/pull/14628#discussion_r1386175030
##
metadata/src/main/java/org/apache/kafka/metadata/properties/MetaPropertiesEnsemble.java:
##
@@ -0,0 +1,575 @@
+/*
+ * Licensed to the Apache Software Foundation
cmccabe commented on code in PR #14628:
URL: https://github.com/apache/kafka/pull/14628#discussion_r1386172972
##
metadata/src/main/java/org/apache/kafka/metadata/properties/MetaPropertiesVersion.java:
##
@@ -0,0 +1,71 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF)
cmccabe commented on code in PR #14628:
URL: https://github.com/apache/kafka/pull/14628#discussion_r1386171452
##
metadata/src/main/java/org/apache/kafka/metadata/properties/MetaPropertiesVersion.java:
##
@@ -0,0 +1,71 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF)
pprovenzano commented on code in PR #14628:
URL: https://github.com/apache/kafka/pull/14628#discussion_r1385811376
##
core/src/main/scala/kafka/server/KafkaServer.scala:
##
@@ -270,10 +271,31 @@ class KafkaServer(
logDirFailureChannel = new
pprovenzano commented on code in PR #14628:
URL: https://github.com/apache/kafka/pull/14628#discussion_r1385811376
##
core/src/main/scala/kafka/server/KafkaServer.scala:
##
@@ -270,10 +271,31 @@ class KafkaServer(
logDirFailureChannel = new
pprovenzano commented on code in PR #14628:
URL: https://github.com/apache/kafka/pull/14628#discussion_r1385810018
##
core/src/main/scala/kafka/server/KafkaServer.scala:
##
@@ -270,10 +271,31 @@ class KafkaServer(
logDirFailureChannel = new
pprovenzano commented on code in PR #14628:
URL: https://github.com/apache/kafka/pull/14628#discussion_r1385810018
##
core/src/main/scala/kafka/server/KafkaServer.scala:
##
@@ -270,10 +271,31 @@ class KafkaServer(
logDirFailureChannel = new
pprovenzano commented on code in PR #14628:
URL: https://github.com/apache/kafka/pull/14628#discussion_r1385805130
##
metadata/src/main/java/org/apache/kafka/metadata/properties/MetaPropertiesEnsemble.java:
##
@@ -0,0 +1,575 @@
+/*
+ * Licensed to the Apache Software Foundation
mumrah commented on code in PR #14628:
URL: https://github.com/apache/kafka/pull/14628#discussion_r1385786809
##
metadata/src/main/java/org/apache/kafka/metadata/properties/MetaPropertiesVersion.java:
##
@@ -0,0 +1,71 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF)
cmccabe commented on PR #14628:
URL: https://github.com/apache/kafka/pull/14628#issuecomment-1800111262
> This PR does not work for ZK. You cannot create the directories in
LogManager.scala but then write the directoryIds later. The directoryIds must
be generated either when LogManager
pprovenzano commented on PR #14628:
URL: https://github.com/apache/kafka/pull/14628#issuecomment-1796843636
This PR does not work for ZK. You cannot create the directories in
LogManager.scala but then write the directoryIds later. The directoryIds must
be generated either when LogManager
cmccabe commented on PR #14628:
URL: https://github.com/apache/kafka/pull/14628#issuecomment-1793043952
I updated this based on part 1 (which is now committed) and the other
changes in trunk.
--
This is an automated message from the Apache Git Service.
To respond to the message, please
cmccabe commented on PR #14628:
URL: https://github.com/apache/kafka/pull/14628#issuecomment-1787946848
This was getting too big, so I split off a part 1 here :
https://github.com/apache/kafka/pull/14678/files
--
This is an automated message from the Apache Git Service.
To respond to the
soarez commented on code in PR #14628:
URL: https://github.com/apache/kafka/pull/14628#discussion_r1377613028
##
core/src/main/scala/kafka/log/LogManager.scala:
##
@@ -267,35 +267,27 @@ class LogManager(logDirs: Seq[File],
/**
* Retrieves the Uuid for the directory,
divijvaidya commented on code in PR #14628:
URL: https://github.com/apache/kafka/pull/14628#discussion_r1374255248
##
metadata/src/main/java/org/apache/kafka/metadata/properties/PropertiesUtils.java:
##
@@ -0,0 +1,102 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF)
cmccabe commented on code in PR #14628:
URL: https://github.com/apache/kafka/pull/14628#discussion_r1373822529
##
core/src/main/scala/kafka/tools/StorageTool.scala:
##
@@ -407,36 +414,41 @@ object StorageTool extends Logging {
if (directories.isEmpty) {
throw new
cmccabe commented on code in PR #14628:
URL: https://github.com/apache/kafka/pull/14628#discussion_r1373824387
##
core/src/main/scala/kafka/log/LogManager.scala:
##
@@ -267,35 +267,27 @@ class LogManager(logDirs: Seq[File],
/**
* Retrieves the Uuid for the directory,
cmccabe commented on code in PR #14628:
URL: https://github.com/apache/kafka/pull/14628#discussion_r1373824387
##
core/src/main/scala/kafka/log/LogManager.scala:
##
@@ -267,35 +267,27 @@ class LogManager(logDirs: Seq[File],
/**
* Retrieves the Uuid for the directory,
cmccabe commented on code in PR #14628:
URL: https://github.com/apache/kafka/pull/14628#discussion_r1373822529
##
core/src/main/scala/kafka/tools/StorageTool.scala:
##
@@ -407,36 +414,41 @@ object StorageTool extends Logging {
if (directories.isEmpty) {
throw new
cmccabe commented on code in PR #14628:
URL: https://github.com/apache/kafka/pull/14628#discussion_r1373820141
##
core/src/main/scala/kafka/server/KafkaServer.scala:
##
@@ -228,23 +226,26 @@ class KafkaServer(
info(s"Cluster ID = $clusterId")
/* load
cmccabe commented on code in PR #14628:
URL: https://github.com/apache/kafka/pull/14628#discussion_r1373816778
##
storage/src/main/java/org/apache/kafka/storage/internals/log/LogDirFailureChannel.java:
##
@@ -57,7 +56,7 @@ public boolean hasOfflineLogDir(String logDir) {
cmccabe commented on code in PR #14628:
URL: https://github.com/apache/kafka/pull/14628#discussion_r1373817350
##
core/src/main/scala/kafka/server/KafkaRaftServer.scala:
##
@@ -135,39 +136,52 @@ object KafkaRaftServer {
* @return A tuple containing the loaded meta
cmccabe commented on code in PR #14628:
URL: https://github.com/apache/kafka/pull/14628#discussion_r1373817350
##
core/src/main/scala/kafka/server/KafkaRaftServer.scala:
##
@@ -135,39 +136,52 @@ object KafkaRaftServer {
* @return A tuple containing the loaded meta
cmccabe commented on code in PR #14628:
URL: https://github.com/apache/kafka/pull/14628#discussion_r1373815484
##
metadata/src/main/java/org/apache/kafka/metadata/properties/MetaPropertiesVersion.java:
##
@@ -0,0 +1,71 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF)
cmccabe commented on code in PR #14628:
URL: https://github.com/apache/kafka/pull/14628#discussion_r1373813203
##
core/src/test/java/kafka/testkit/KafkaClusterTestKit.java:
##
@@ -227,8 +231,12 @@ public KafkaClusterTestKit build() throws Exception {
cmccabe commented on code in PR #14628:
URL: https://github.com/apache/kafka/pull/14628#discussion_r1373812595
##
metadata/src/main/java/org/apache/kafka/metadata/properties/MetaPropertiesEnsemble.java:
##
@@ -0,0 +1,497 @@
+/*
+ * Licensed to the Apache Software Foundation
cmccabe commented on code in PR #14628:
URL: https://github.com/apache/kafka/pull/14628#discussion_r1373810872
##
metadata/src/main/java/org/apache/kafka/metadata/properties/PropertiesUtils.java:
##
@@ -0,0 +1,102 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF)
cmccabe commented on code in PR #14628:
URL: https://github.com/apache/kafka/pull/14628#discussion_r1373808533
##
metadata/src/main/java/org/apache/kafka/metadata/properties/MetaProperties.java:
##
@@ -0,0 +1,266 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under
divijvaidya commented on code in PR #14628:
URL: https://github.com/apache/kafka/pull/14628#discussion_r1373545620
##
metadata/src/main/java/org/apache/kafka/metadata/properties/PropertiesUtils.java:
##
@@ -0,0 +1,102 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF)
cmccabe commented on code in PR #14628:
URL: https://github.com/apache/kafka/pull/14628#discussion_r1373542993
##
metadata/src/main/java/org/apache/kafka/metadata/properties/PropertiesUtils.java:
##
@@ -0,0 +1,102 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF)
cmccabe commented on code in PR #14628:
URL: https://github.com/apache/kafka/pull/14628#discussion_r1373542993
##
metadata/src/main/java/org/apache/kafka/metadata/properties/PropertiesUtils.java:
##
@@ -0,0 +1,102 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF)
cmccabe commented on code in PR #14628:
URL: https://github.com/apache/kafka/pull/14628#discussion_r1373533083
##
metadata/src/main/java/org/apache/kafka/metadata/properties/PropertiesUtils.java:
##
@@ -0,0 +1,102 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF)
cmccabe commented on code in PR #14628:
URL: https://github.com/apache/kafka/pull/14628#discussion_r1373533689
##
metadata/src/main/java/org/apache/kafka/metadata/properties/PropertiesUtils.java:
##
@@ -0,0 +1,102 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF)
cmccabe commented on PR #14628:
URL: https://github.com/apache/kafka/pull/14628#issuecomment-1781560050
> This fails for the case where there are no log directories to start and we
are creating the node and directories for the first time.
Thanks for testing. Yes, this was missing
pprovenzano commented on code in PR #14628:
URL: https://github.com/apache/kafka/pull/14628#discussion_r1372498997
##
metadata/src/main/java/org/apache/kafka/metadata/properties/PropertiesUtils.java:
##
@@ -0,0 +1,102 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF)
soarez commented on code in PR #14628:
URL: https://github.com/apache/kafka/pull/14628#discussion_r1371749943
##
metadata/src/main/java/org/apache/kafka/metadata/properties/MetaProperties.java:
##
@@ -0,0 +1,266 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under
divijvaidya commented on code in PR #14628:
URL: https://github.com/apache/kafka/pull/14628#discussion_r1371459493
##
metadata/src/main/java/org/apache/kafka/metadata/properties/PropertiesUtils.java:
##
@@ -0,0 +1,102 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF)
pprovenzano commented on code in PR #14628:
URL: https://github.com/apache/kafka/pull/14628#discussion_r1371083468
##
core/src/test/java/kafka/testkit/KafkaClusterTestKit.java:
##
@@ -227,8 +231,12 @@ public KafkaClusterTestKit build() throws Exception {
43 matches
Mail list logo