sjhajharia commented on PR #16021:
URL: https://github.com/apache/kafka/pull/16021#issuecomment-2128693543
Hey @chia7712
I have created 5 sub-PRs to address the cleanup module-by-module.
- https://github.com/apache/kafka/pull/16049: Clients Module
-
sjhajharia commented on PR #16021:
URL: https://github.com/apache/kafka/pull/16021#issuecomment-2127460772
Hey @chia7712
Thanks for the comment. I was also in a split brain regarding the same. I
will close this one and create child PRs with one/two modules targetted at a
time for an
sjhajharia closed pull request #16021: [MINOR] Code Cleanup
URL: https://github.com/apache/kafka/pull/16021
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe,
chia7712 commented on PR #16021:
URL: https://github.com/apache/kafka/pull/16021#issuecomment-2127214845
@sjhajharia Thanks for this great contribution. However, we normally do such
refactor one module by one module. For example: #15967, #15955, and #15877
The huge PR is
sjhajharia opened a new pull request, #16021:
URL: https://github.com/apache/kafka/pull/16021
Performing some cleanup on code.
Mainly it addresses cases of using Singleton lists where possible instead of
an Array List and some minor changes to get rid of String Builders
--
This is an
mjsax merged PR #15208:
URL: https://github.com/apache/kafka/pull/15208
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
mjsax commented on PR #15208:
URL: https://github.com/apache/kafka/pull/15208#issuecomment-1894793322
This PR must be cherry-picked to `3.7` and `3.6` branches.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
