jolshan commented on code in PR #15320:
URL: https://github.com/apache/kafka/pull/15320#discussion_r1497943369
##
clients/src/test/java/org/apache/kafka/clients/producer/internals/TransactionManagerTest.java:
##
@@ -2548,6 +2548,23 @@ public void
testRaiseErrorWhenNoPartitionsP
cadonna commented on code in PR #15320:
URL: https://github.com/apache/kafka/pull/15320#discussion_r1497317344
##
clients/src/test/java/org/apache/kafka/clients/producer/internals/TransactionManagerTest.java:
##
@@ -2548,6 +2548,23 @@ public void
testRaiseErrorWhenNoPartitionsP
cadonna commented on code in PR #15320:
URL: https://github.com/apache/kafka/pull/15320#discussion_r1497207704
##
clients/src/test/java/org/apache/kafka/clients/producer/internals/TransactionManagerTest.java:
##
@@ -2548,6 +2548,23 @@ public void
testRaiseErrorWhenNoPartitionsP
cadonna commented on code in PR #15320:
URL: https://github.com/apache/kafka/pull/15320#discussion_r1497201056
##
clients/src/test/java/org/apache/kafka/clients/producer/internals/TransactionManagerTest.java:
##
@@ -2548,6 +2548,23 @@ public void
testRaiseErrorWhenNoPartitionsP
sjhajharia commented on code in PR #15320:
URL: https://github.com/apache/kafka/pull/15320#discussion_r1497137732
##
clients/src/test/java/org/apache/kafka/clients/producer/internals/TransactionManagerTest.java:
##
@@ -2548,6 +2548,23 @@ public void
testRaiseErrorWhenNoPartitio
jolshan merged PR #15320:
URL: https://github.com/apache/kafka/pull/15320
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.
artemlivshits opened a new pull request, #15320:
URL: https://github.com/apache/kafka/pull/15320
There is a test already that checks that transactional messages are not
drained when partition is not added, this change just logically completes the
test to also show that messages can be drain
