showuon commented on PR #15220:
URL: https://github.com/apache/kafka/pull/15220#issuecomment-1911567449
Thanks for the contribution, @drawxy !
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
showuon merged PR #15220:
URL: https://github.com/apache/kafka/pull/15220
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.
showuon commented on PR #15220:
URL: https://github.com/apache/kafka/pull/15220#issuecomment-1911563500
Failed tests are unrelated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific co
drawxy commented on PR #15220:
URL: https://github.com/apache/kafka/pull/15220#issuecomment-1911558398
Hi @divijvaidya and @showuon, I have resolved the compilation issue, but
there are still some failed unit test cases, which are not involved by this PR.
Should I mitigate them all? I am ne
drawxy commented on PR #15220:
URL: https://github.com/apache/kafka/pull/15220#issuecomment-1907259848
> @drawxy can you please fix the failing compilation. Otherwise looks good.
Already fixed by rebasing the trunk branch. @divijvaidya, can you please
help to merge this PR, thanks!
drawxy commented on PR #15220:
URL: https://github.com/apache/kafka/pull/15220#issuecomment-1905997013
> I can see there are thousands of lines changes. Is that expected?
Hi @showuon , sorry for involving tens of commits by rebasing the wrong
branch.
--
This is an automated message
showuon commented on PR #15220:
URL: https://github.com/apache/kafka/pull/15220#issuecomment-1905980778
I can see there are thousands of lines changes. Is that expected?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use
divijvaidya commented on PR #15220:
URL: https://github.com/apache/kafka/pull/15220#issuecomment-1905791005
@drawxy can you please fix the failing compilation. Otherwise looks good.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to Git
drawxy opened a new pull request, #15220:
URL: https://github.com/apache/kafka/pull/15220
After this #13107 PR, an if-else block became unreachable. We need remove
it and make the code clean.
--
This is an automated message from the Apache Git Service.
To respond to the message, please l
