Re: [PR] Remove consumer rejoin to the group's synchronized lock [kafka]

2024-01-05 Thread via GitHub
github-actions[bot] commented on PR #14241: URL: https://github.com/apache/kafka/pull/14241#issuecomment-1879522799 This PR is being marked as stale since it has not had any activity in 90 days. If you would like to keep this PR alive, please ask a committer for review. If the PR has merge

Re: [PR] Remove consumer rejoin to the group's synchronized lock [kafka]

2023-10-06 Thread via GitHub
vamossagar12 commented on code in PR #14241: URL: https://github.com/apache/kafka/pull/14241#discussion_r1349466119 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/AbstractCoordinator.java: ## @@ -459,19 +459,14 @@ boolean joinGroupIfNeeded(final Timer timer

Re: [PR] Remove consumer rejoin to the group's synchronized lock [kafka]

2023-10-06 Thread via GitHub
vamossagar12 commented on PR #14241: URL: https://github.com/apache/kafka/pull/14241#issuecomment-1751607482 Thanks for the interesting PR @haodanchen. If we focus on point number 1, the main point that you are trying to make is that even though the `generationsnapshot` is received in the s