Re: [PR] a slight change. [kafka]

2024-05-07 Thread via GitHub
gongxuanzhang commented on PR #15812: URL: https://github.com/apache/kafka/pull/15812#issuecomment-2099682338 @gharris1727 new pr : https://github.com/apache/kafka/pull/15890 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

Re: [PR] a slight change. [kafka]

2024-05-07 Thread via GitHub
gongxuanzhang commented on PR #15812: URL: https://github.com/apache/kafka/pull/15812#issuecomment-2099569696 @gharris1727 i request a jira acount link gongxuanzhang email: gongxuanzhangm...@gmail.com I need a confirmation. Can I get it from you -- This is an automated message

Re: [PR] a slight change. [kafka]

2024-05-07 Thread via GitHub
gongxuanzhang commented on PR #15812: URL: https://github.com/apache/kafka/pull/15812#issuecomment-2099566070 > @gongxuanzhang Do you want to merge this PR as-is, or do you want to add more fixes to this? I will create new pr linked -- This is an automated message from the Apache

Re: [PR] a slight change. [kafka]

2024-05-07 Thread via GitHub
gongxuanzhang closed pull request #15812: a slight change. URL: https://github.com/apache/kafka/pull/15812 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe,

Re: [PR] a slight change. [kafka]

2024-05-07 Thread via GitHub
gongxuanzhang commented on PR #15812: URL: https://github.com/apache/kafka/pull/15812#issuecomment-2099540536 > @gongxuanzhang Do you want to merge this PR as-is, or do you want to add more fixes to this? I choose the latter and do more thank you for your trust -- This is an

Re: [PR] a slight change. [kafka]

2024-05-07 Thread via GitHub
gharris1727 commented on PR #15812: URL: https://github.com/apache/kafka/pull/15812#issuecomment-2099128163 @gongxuanzhang Do you want to merge this PR as-is, or do you want to add more fixes to this? -- This is an automated message from the Apache Git Service. To respond to the message,

Re: [PR] a slight change. [kafka]

2024-05-07 Thread via GitHub
gongxuanzhang commented on PR #15812: URL: https://github.com/apache/kafka/pull/15812#issuecomment-2098224856 > Hi @gongxuanzhang and thank you for the contribution! > > This is actually an issue in a lot of places, I checked with this checkstyle.xml rule: > > ``` >

Re: [PR] a slight change. [kafka]

2024-04-29 Thread via GitHub
gharris1727 commented on PR #15812: URL: https://github.com/apache/kafka/pull/15812#issuecomment-2083856829 Hi @gongxuanzhang and thank you for the contribution! This is actually an issue in a lot of places, I checked with this checkstyle.xml rule: ``` ``` and