showuon commented on PR #14891:
URL: https://github.com/apache/kafka/pull/14891#issuecomment-1945384353
@jolshan , do you want to have another look? If no, I'm going to merge this
PR this week. Thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message,
Owen-CH-Leung commented on PR #14891:
URL: https://github.com/apache/kafka/pull/14891#issuecomment-1890892504
> > Thanks for your feedback! Do you mean we should keep the existing API
calls like createAndWaitTopic(buildTopicCommandOptionsWithBootstrap(
"--create", "--partitions", "2", "--re
Owen-CH-Leung commented on code in PR #14891:
URL: https://github.com/apache/kafka/pull/14891#discussion_r1451689247
##
tools/src/test/java/org/apache/kafka/tools/TopicCommandIntegrationTest.java:
##
@@ -787,16 +827,28 @@ public void
testDescribeUnderReplicatedPartitionsWhenRea
Owen-CH-Leung commented on code in PR #14891:
URL: https://github.com/apache/kafka/pull/14891#discussion_r1451689158
##
tools/src/test/java/org/apache/kafka/tools/TopicCommandIntegrationTest.java:
##
@@ -472,10 +516,11 @@ public void testCreateAlterTopicWithRackAware(String
quo
Owen-CH-Leung commented on code in PR #14891:
URL: https://github.com/apache/kafka/pull/14891#discussion_r1451688709
##
tools/src/test/java/org/apache/kafka/tools/TopicCommandIntegrationTest.java:
##
@@ -159,100 +166,117 @@ public void close() throws Exception {
@Parameteri
showuon commented on code in PR #14891:
URL: https://github.com/apache/kafka/pull/14891#discussion_r1451667979
##
tools/src/test/java/org/apache/kafka/tools/TopicCommandIntegrationTest.java:
##
@@ -159,100 +166,117 @@ public void close() throws Exception {
@ParameterizedTes
Owen-CH-Leung commented on code in PR #14891:
URL: https://github.com/apache/kafka/pull/14891#discussion_r1451666065
##
tools/src/test/java/org/apache/kafka/tools/TopicCommandIntegrationTest.java:
##
@@ -159,100 +166,117 @@ public void close() throws Exception {
@Parameteri
jolshan commented on PR #14891:
URL: https://github.com/apache/kafka/pull/14891#issuecomment-1889665664
> Thanks for your feedback! Do you mean we should keep the existing API
calls like createAndWaitTopic(buildTopicCommandOptionsWithBootstrap(
"--create", "--partitions", "2", "--replicatio
showuon commented on code in PR #14891:
URL: https://github.com/apache/kafka/pull/14891#discussion_r1450086585
##
tools/src/test/java/org/apache/kafka/tools/TopicCommandIntegrationTest.java:
##
@@ -472,10 +516,11 @@ public void testCreateAlterTopicWithRackAware(String
quorum) t
Owen-CH-Leung commented on PR #14891:
URL: https://github.com/apache/kafka/pull/14891#issuecomment-1839853774
> Hm.. given this is the TopicCommandIntegrationTest I think we should
keep the parts testing the topic command tool.
Thanks for your feedback! Do you mean we should keep
jolshan commented on PR #14891:
URL: https://github.com/apache/kafka/pull/14891#issuecomment-1839383581
Hm.. given this is the TopicCommandIntegrationTest I think we should
keep the parts testing the topic command tool.
--
This is an automated message from the Apache Git Service.
To
Owen-CH-Leung commented on PR #14891:
URL: https://github.com/apache/kafka/pull/14891#issuecomment-1837314777
@divijvaidya Can I ask for your help to trigger the test a few more times
and see if the tests are still flaky ? Previously I noticd that
`testDescribeUnderReplicatedPartitionsWhenR
Owen-CH-Leung commented on PR #14891:
URL: https://github.com/apache/kafka/pull/14891#issuecomment-1837314577
> I don't think we want to directly call `TestUtils.createTopicWithAdmin` in
this test for most cases. I didn't read through all of the tests, but I would
imagine that most of these
splett2 commented on PR #14891:
URL: https://github.com/apache/kafka/pull/14891#issuecomment-1837054475
I don't think we want to directly call `TestUtils.createTopicWithAdmin` in
this test for most cases. I didn't read through all of the tests, but I would
imagine that most of these integra
Owen-CH-Leung opened a new pull request, #14891:
URL: https://github.com/apache/kafka/pull/14891
As per
[KAFKA-15140](https://issues.apache.org/jira/browse/KAFKA-15140?jql=project%20%3D%20KAFKA%20AND%20fixVersion%20%3D%203.7.0%20%20AND%20status%20not%20in%20(resolved%2C%20closed)%20ORDER%20B
15 matches
Mail list logo
