[ 
https://issues.apache.org/jira/browse/KAFKA-16190?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17818979#comment-17818979
 ] 

Quoc Phong Dang edited comment on KAFKA-16190 at 2/21/24 1:11 AM:
------------------------------------------------------------------

[~kirktrue] Thank you and sorry for the dely, It takes my sometime to look into 
the KIP and trying to navigate the code. I'm trying to see how should i know if 
a consumer is rejoin.


was (Author: JIRAUSER303789):
[~kirktrue] Thank you and sorry for the dely, It takes my sometime to look into 
the KIP and trying to navigate the code. I'm not so sure the file I'm trying to 
change is the correct one, can you point me out the location need to be done it 
would be helpful.

> Member should send full heartbeat when rejoining
> ------------------------------------------------
>
>                 Key: KAFKA-16190
>                 URL: https://issues.apache.org/jira/browse/KAFKA-16190
>             Project: Kafka
>          Issue Type: Sub-task
>          Components: clients, consumer
>            Reporter: Lianet Magrans
>            Assignee: Quoc Phong Dang
>            Priority: Critical
>              Labels: client-transitions-issues, kip-848-client-support, newbie
>             Fix For: 3.8.0
>
>
> The heartbeat request builder should make sure that all fields are sent in 
> the heartbeat request when the consumer rejoins (currently the 
> HeartbeatRequestManager request builder is reset on failure scenarios, which 
> should cover the fence+rejoin sequence). 
> Note that the existing HeartbeatRequestManagerTest.testHeartbeatState misses 
> this exact case given that it does explicitly change the subscription when it 
> gets fenced. We should ensure we test a consumer that keeps it same initial 
> subscription when it rejoins after being fenced.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to