[ 
https://issues.apache.org/jira/browse/KAFKA-16416?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17830387#comment-17830387
 ] 

Luke Chen edited comment on KAFKA-16416 at 3/25/24 7:53 AM:
------------------------------------------------------------

Also, in the readme, we said:

> Change the log4j setting in either 
> {{clients/src/test/resources/log4j.properties}} or 
> {{core/src/test/resources/log4j.properties}}

 

But in this case, it only works if the 
{{clients/src/test/resources/log4j.properties}} changed since it's under 
`clients` project. The "or {{{}core/src/test/resources/log4j.properties{}}}" is 
another misleading. We should make it clear to help new users.


was (Author: showuon):
Also, in the readme, we said:

> Change the log4j setting in either 
> {{clients/src/test/resources/log4j.properties}} or 
> {{core/src/test/resources/log4j.properties}}

 

But in this case, it only works if the 
{{clients/src/test/resources/log4j.properties}} since it's under `clients` 
project. The "or {{{}core/src/test/resources/log4j.properties{}}}" is another 
misleading. We should make it clear to help new users.

> Use NetworkClientTest to replace RequestResponseTest to be the example of 
> log4j output
> --------------------------------------------------------------------------------------
>
>                 Key: KAFKA-16416
>                 URL: https://issues.apache.org/jira/browse/KAFKA-16416
>             Project: Kafka
>          Issue Type: Improvement
>            Reporter: Chia-Ping Tsai
>            Assignee: Cheng-Kai, Zhang
>            Priority: Trivial
>              Labels: newbie
>
> https://github.com/apache/kafka/blob/trunk/README.md#running-a-particular-unitintegration-test-with-log4j-output
> `RequestResponseTest` does not produce log4j output even though we set the 
> log level to info, so it could misdirect users. Hence, we should use another 
> test class which can produce log output to replace `RequestResponseTest`. For 
> example: NetworkClientTest



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to