[
https://issues.apache.org/jira/browse/KAFKA-12220?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17440831#comment-17440831
]
Liam Clarke commented on KAFKA-12220:
-
Hi [~chia7712] and [~ijuma] - I hit Powermock/Easymock issues
[
https://issues.apache.org/jira/browse/KAFKA-12220?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17273244#comment-17273244
]
Chia-Ping Tsai commented on KAFKA-12220:
[~ijuma] How about splitting PR by package?
[
https://issues.apache.org/jira/browse/KAFKA-12220?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17267412#comment-17267412
]
Chia-Ping Tsai commented on KAFKA-12220:
{quote}
One question: are we replacing `PowerMock` and
[
https://issues.apache.org/jira/browse/KAFKA-12220?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17267409#comment-17267409
]
Ismael Juma commented on KAFKA-12220:
-
One question: are we replacing `PowerMock` and `EasyMock` or
[
https://issues.apache.org/jira/browse/KAFKA-12220?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17267406#comment-17267406
]
Ismael Juma commented on KAFKA-12220:
-
Also, I would start with `streams` since there are less
[
https://issues.apache.org/jira/browse/KAFKA-12220?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17267405#comment-17267405
]
Ismael Juma commented on KAFKA-12220:
-
That doesn't seem too bad, I would do one PR per module
[
https://issues.apache.org/jira/browse/KAFKA-12220?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17267143#comment-17267143
]
Chia-Ping Tsai commented on KAFKA-12220:
search "@RunWith(PowerMockRunner.class)"
29 results in
[
https://issues.apache.org/jira/browse/KAFKA-12220?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17267142#comment-17267142
]
Ismael Juma commented on KAFKA-12220:
-
I think that will result in too many PRs. How many classes
[
https://issues.apache.org/jira/browse/KAFKA-12220?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17267138#comment-17267138
]
Chia-Ping Tsai commented on KAFKA-12220:
the most usages of PowerMock is in stream and