[
https://issues.apache.org/jira/browse/KAFKA-5233?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16352966#comment-16352966
]
ASF GitHub Bot commented on KAFKA-5233:
---
guozhangwang closed pull request #3678: KAFKA-5233 follow
[
https://issues.apache.org/jira/browse/KAFKA-5233?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16140959#comment-16140959
]
Guozhang Wang commented on KAFKA-5233:
--
[~mihbor] I have another pr for other related doc changes:
[
https://issues.apache.org/jira/browse/KAFKA-5233?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16129646#comment-16129646
]
Guozhang Wang commented on KAFKA-5233:
--
Thanks [~mihbor]!
> Changes to punctuate semantics (KIP-138)
[
https://issues.apache.org/jira/browse/KAFKA-5233?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16129556#comment-16129556
]
Michal Borowiecki commented on KAFKA-5233:
--
Hi [~guozhang],
I had a look at KStreamTestDriver
[
https://issues.apache.org/jira/browse/KAFKA-5233?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16129533#comment-16129533
]
ASF GitHub Bot commented on KAFKA-5233:
---
GitHub user mihbor opened a pull request:
[
https://issues.apache.org/jira/browse/KAFKA-5233?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16107653#comment-16107653
]
Guozhang Wang commented on KAFKA-5233:
--
I agree with both of your regarding keeping the unit tests
[
https://issues.apache.org/jira/browse/KAFKA-5233?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16106404#comment-16106404
]
Matthias J. Sax commented on KAFKA-5233:
I agree with [~mihbor] that we might want to keep the old
[
https://issues.apache.org/jira/browse/KAFKA-5233?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16106084#comment-16106084
]
Michal Borowiecki commented on KAFKA-5233:
--
Yes, my line of thinking was that although
[
https://issues.apache.org/jira/browse/KAFKA-5233?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16105814#comment-16105814
]
Guozhang Wang commented on KAFKA-5233:
--
[~mihbor] While reviewing some other PRs I realized that
