[jira] [Commented] (KAFKA-5973) ShutdownableThread catching errors can lead to partial hard to diagnose broker failure

2017-11-06 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-5973?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16240971#comment-16240971 ] Ted Yu commented on KAFKA-5973: --- Currently not - there is no consensus for the solution. >

[jira] [Commented] (KAFKA-5973) ShutdownableThread catching errors can lead to partial hard to diagnose broker failure

2017-11-06 Thread Rajini Sivaram (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-5973?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16240958#comment-16240958 ] Rajini Sivaram commented on KAFKA-5973: --- [~tedyu] Are you still working on this one? >

[jira] [Commented] (KAFKA-5973) ShutdownableThread catching errors can lead to partial hard to diagnose broker failure

2017-10-05 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-5973?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16193918#comment-16193918 ] Ted Yu commented on KAFKA-5973: --- bq. which to kill itself, which to kill the whole process In description,

[jira] [Commented] (KAFKA-5973) ShutdownableThread catching errors can lead to partial hard to diagnose broker failure

2017-10-05 Thread Guozhang Wang (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-5973?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16193905#comment-16193905 ] Guozhang Wang commented on KAFKA-5973: -- I'm in favor of both action items, i.e. 1) making a pass over

[jira] [Commented] (KAFKA-5973) ShutdownableThread catching errors can lead to partial hard to diagnose broker failure

2017-09-27 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-5973?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16182962#comment-16182962 ] ASF GitHub Bot commented on KAFKA-5973: --- Github user tedyu closed the pull request at:

[jira] [Commented] (KAFKA-5973) ShutdownableThread catching errors can lead to partial hard to diagnose broker failure

2017-09-27 Thread Roger Hoover (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-5973?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16182867#comment-16182867 ] Roger Hoover commented on KAFKA-5973: - [~ijuma] Great points. A stable metric solves the issue of

[jira] [Commented] (KAFKA-5973) ShutdownableThread catching errors can lead to partial hard to diagnose broker failure

2017-09-27 Thread Ismael Juma (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-5973?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16182856#comment-16182856 ] Ismael Juma commented on KAFKA-5973: A few things to think about before we devise a solution: 1. What

[jira] [Commented] (KAFKA-5973) ShutdownableThread catching errors can lead to partial hard to diagnose broker failure

2017-09-27 Thread Ismael Juma (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-5973?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16182839#comment-16182839 ] Ismael Juma commented on KAFKA-5973: [~theduderog], hmm, I don't understand why. If there is a metric,

[jira] [Commented] (KAFKA-5973) ShutdownableThread catching errors can lead to partial hard to diagnose broker failure

2017-09-27 Thread Roger Hoover (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-5973?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16182794#comment-16182794 ] Roger Hoover commented on KAFKA-5973: - [~ijuma] You're right that failing more aggressively could

[jira] [Commented] (KAFKA-5973) ShutdownableThread catching errors can lead to partial hard to diagnose broker failure

2017-09-27 Thread Ismael Juma (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-5973?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16182705#comment-16182705 ] Ismael Juma commented on KAFKA-5973: Because of the statefulness of Kafka brokers, you may not want to

[jira] [Commented] (KAFKA-5973) ShutdownableThread catching errors can lead to partial hard to diagnose broker failure

2017-09-27 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-5973?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16182694#comment-16182694 ] Ted Yu commented on KAFKA-5973: --- [~damianguy] [~guozhang]: Can you take a look ? Thanks >

[jira] [Commented] (KAFKA-5973) ShutdownableThread catching errors can lead to partial hard to diagnose broker failure

2017-09-26 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-5973?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16181184#comment-16181184 ] Ted Yu commented on KAFKA-5973: --- [~tcrayford-heroku] [~theduderog]: What do you think of the PR ? >

[jira] [Commented] (KAFKA-5973) ShutdownableThread catching errors can lead to partial hard to diagnose broker failure

2017-09-26 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-5973?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16181043#comment-16181043 ] ASF GitHub Bot commented on KAFKA-5973: --- GitHub user tedyu opened a pull request:

[jira] [Commented] (KAFKA-5973) ShutdownableThread catching errors can lead to partial hard to diagnose broker failure

2017-09-25 Thread Roger Hoover (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-5973?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16179910#comment-16179910 ] Roger Hoover commented on KAFKA-5973: - I guess there's a 4th option too: 4) Restart failed threads - I

[jira] [Commented] (KAFKA-5973) ShutdownableThread catching errors can lead to partial hard to diagnose broker failure

2017-09-25 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-5973?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16179702#comment-16179702 ] Ted Yu commented on KAFKA-5973: --- Interesting. Looks like the following class is not used: