[jira] [Commented] (KAFKA-6011) AppInfoParser should only use metrics API and should not register JMX mbeans directly

2017-10-05 Thread Rajini Sivaram (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-6011?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16192956#comment-16192956 ] Rajini Sivaram commented on KAFKA-6011: --- [~ewencp] Yes, It is odd to have both {{client-id=}} and

[jira] [Commented] (KAFKA-6011) AppInfoParser should only use metrics API and should not register JMX mbeans directly

2017-10-04 Thread Ewen Cheslack-Postava (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-6011?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16192105#comment-16192105 ] Ewen Cheslack-Postava commented on KAFKA-6011: -- [~rsivaram] Fair point, I see that we have

[jira] [Commented] (KAFKA-6011) AppInfoParser should only use metrics API and should not register JMX mbeans directly

2017-10-04 Thread Rajini Sivaram (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-6011?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16191994#comment-16191994 ] Rajini Sivaram commented on KAFKA-6011: --- The id that is passed to {{AppInfoParser}} by

[jira] [Commented] (KAFKA-6011) AppInfoParser should only use metrics API and should not register JMX mbeans directly

2017-10-04 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-6011?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16191965#comment-16191965 ] ASF GitHub Bot commented on KAFKA-6011: --- GitHub user tedyu opened a pull request:

[jira] [Commented] (KAFKA-6011) AppInfoParser should only use metrics API and should not register JMX mbeans directly

2017-10-04 Thread Ismael Juma (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-6011?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16191938#comment-16191938 ] Ismael Juma commented on KAFKA-6011: I agree that it was a mistake to use JMX directly although I