[jira] [Commented] (KAFKA-8106) Remove unnecessary decompression operation when logValidator do validation.

2019-03-31 Thread hackerwin7 (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-8106?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16806375#comment-16806375 ] hackerwin7 commented on KAFKA-8106: --- [~wlwolf87] `MaxTimestamp` I think we can not use it to validation

[jira] [Commented] (KAFKA-8106) Remove unnecessary decompression operation when logValidator do validation.

2019-03-31 Thread Ve Lee (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-8106?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16806363#comment-16806363 ] Ve Lee commented on KAFKA-8106: --- {{RecordBatch =>}} {{  }}{{FirstOffset => int64}} {{  }}{{Length =>

[jira] [Commented] (KAFKA-8106) Remove unnecessary decompression operation when logValidator do validation.

2019-03-31 Thread hackerwin7 (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-8106?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16806352#comment-16806352 ] hackerwin7 commented on KAFKA-8106: --- [~wlwolf87] Currently the the broker decompress to validate record

[jira] [Commented] (KAFKA-8106) Remove unnecessary decompression operation when logValidator do validation.

2019-03-31 Thread Flower.min (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-8106?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16806337#comment-16806337 ] Flower.min commented on KAFKA-8106: --- [~hackerwin7]I agree with idea of [~qiaochao911] , Maybe we can

[jira] [Commented] (KAFKA-8106) Remove unnecessary decompression operation when logValidator do validation.

2019-03-31 Thread Ve Lee (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-8106?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16806336#comment-16806336 ] Ve Lee commented on KAFKA-8106: --- [~hackerwin7] First, you have to be clear that the parameters of the

[jira] [Commented] (KAFKA-8106) Remove unnecessary decompression operation when logValidator do validation.

2019-03-31 Thread Flower.min (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-8106?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16806334#comment-16806334 ] Flower.min commented on KAFKA-8106: --- [~junrao] Of course,we need read timestamp and offset from record

[jira] [Commented] (KAFKA-8106) Remove unnecessary decompression operation when logValidator do validation.

2019-03-30 Thread hackerwin7 (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-8106?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16805757#comment-16805757 ] hackerwin7 commented on KAFKA-8106: --- [~junrao], can we batches for this to prevent the record level

[jira] [Commented] (KAFKA-8106) Remove unnecessary decompression operation when logValidator do validation.

2019-03-29 Thread Jun Rao (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-8106?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16805539#comment-16805539 ] Jun Rao commented on KAFKA-8106: [~Flower.min], one of the validation that the broker has to do is to

[jira] [Commented] (KAFKA-8106) Remove unnecessary decompression operation when logValidator do validation.

2019-03-28 Thread hackerwin7 (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-8106?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16804532#comment-16804532 ] hackerwin7 commented on KAFKA-8106: --- Maybe we can put the record level validation to client endpoint or

[jira] [Commented] (KAFKA-8106) Remove unnecessary decompression operation when logValidator do validation.

2019-03-28 Thread hackerwin7 (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-8106?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16804003#comment-16804003 ] hackerwin7 commented on KAFKA-8106: --- The `validateRecord()` is placed in every branch of

[jira] [Commented] (KAFKA-8106) Remove unnecessary decompression operation when logValidator do validation.

2019-03-23 Thread qiaochao (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-8106?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16799597#comment-16799597 ] qiaochao commented on KAFKA-8106: - In the scene of inPlaceAssignment,I think the server should set the

[jira] [Commented] (KAFKA-8106) Remove unnecessary decompression operation when logValidator do validation.

2019-03-21 Thread Flower.min (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-8106?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16797927#comment-16797927 ] Flower.min commented on KAFKA-8106: --- _*We only don't decompress key and value of a record, it still can

[jira] [Commented] (KAFKA-8106) Remove unnecessary decompression operation when logValidator do validation.

2019-03-20 Thread Flower.min (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-8106?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16797016#comment-16797016 ] Flower.min commented on KAFKA-8106: --- we suggest that removing unnecessary decompression operation when

[jira] [Commented] (KAFKA-8106) Remove unnecessary decompression operation when logValidator do validation.

2019-03-18 Thread Manikumar (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-8106?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16795714#comment-16795714 ] Manikumar commented on KAFKA-8106: -- [~Flower.min] Instructions for the submitting code changes are

[jira] [Commented] (KAFKA-8106) Remove unnecessary decompression operation when logValidator do validation.

2019-03-18 Thread Flower.min (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-8106?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16795688#comment-16795688 ] Flower.min commented on KAFKA-8106: ---  We do performance testing again with package include of

[jira] [Commented] (KAFKA-8106) Remove unnecessary decompression operation when logValidator do validation.

2019-03-16 Thread Flower.min (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-8106?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16794193#comment-16794193 ] Flower.min commented on KAFKA-8106: --- I and My team modify some code of Kafka  and I need permission to