[ 
https://issues.apache.org/jira/browse/KAFKA-7811?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

lambdaliu updated KAFKA-7811:
-----------------------------
    Description: 
In KafkaConsumer#commitSync, we have the following logic:
{code:java}
public void commitAsync(OffsetCommitCallback callback) {
    acquireAndEnsureOpen();
    try {
        commitAsync(subscriptions.allConsumed(), callback);
    } finally {
        release();
    }
}
{code}
This function calls another commitAsync which also call `acquireAndEnsureOpen`.

 

  was:
In KafkaConsumer#commitSync, we have the following logic:

 
{code:java}
public void commitAsync(OffsetCommitCallback callback) {
    acquireAndEnsureOpen();
    try {
        commitAsync(subscriptions.allConsumed(), callback);
    } finally {
        release();
    }
}
{code}
This function calls another commitAsync which also call `acquireAndEnsureOpen`.

 


> Avoid unnecessary lock acquire when KafkaConsumer commit offsets
> ----------------------------------------------------------------
>
>                 Key: KAFKA-7811
>                 URL: https://issues.apache.org/jira/browse/KAFKA-7811
>             Project: Kafka
>          Issue Type: Improvement
>          Components: clients
>    Affects Versions: 0.10.2.2, 0.11.0.3, 1.0.2, 1.1.1, 2.0.1, 2.1.0
>            Reporter: lambdaliu
>            Assignee: lambdaliu
>            Priority: Major
>
> In KafkaConsumer#commitSync, we have the following logic:
> {code:java}
> public void commitAsync(OffsetCommitCallback callback) {
>     acquireAndEnsureOpen();
>     try {
>         commitAsync(subscriptions.allConsumed(), callback);
>     } finally {
>         release();
>     }
> }
> {code}
> This function calls another commitAsync which also call 
> `acquireAndEnsureOpen`.
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to