Re: [PR] KAFKA-12679: Handle lock exceptions in state updater [kafka]

2025-06-23 Thread via GitHub
cadonna commented on PR #12875: URL: https://github.com/apache/kafka/pull/12875#issuecomment-2997379357 @lucasbru that sounds like a good idea. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

Re: [PR] KAFKA-12679: Handle lock exceptions in state updater [kafka]

2025-06-23 Thread via GitHub
lucasbru commented on PR #12875: URL: https://github.com/apache/kafka/pull/12875#issuecomment-2996985442 @cadonna could we just check if the state store is even open before attempting to grab the lock to close it? -- This is an automated message from the Apache Git Service. To respond to

Re: [PR] KAFKA-12679: Handle lock exceptions in state updater [kafka]

2025-06-23 Thread via GitHub
cadonna commented on PR #12875: URL: https://github.com/apache/kafka/pull/12875#issuecomment-2996966634 Yeah, I understand. The issue is that not being able to acquire the log when closing a task might be an error in other situations. Downgrading the log message to a WARN or INFO might need

Re: [PR] KAFKA-12679: Handle lock exceptions in state updater [kafka]

2025-06-23 Thread via GitHub
a-dudko commented on PR #12875: URL: https://github.com/apache/kafka/pull/12875#issuecomment-2996933103 @cadonna actually not all _"Reattempting..."_ info logs are followed by the error meaning it is mostly resolved correctly afterwards, so sorry for the misleading comment. We don't see any

Re: [PR] KAFKA-12679: Handle lock exceptions in state updater [kafka]

2025-06-23 Thread via GitHub
cadonna commented on PR #12875: URL: https://github.com/apache/kafka/pull/12875#issuecomment-2996879605 Both should actually be harmless. The first is just an info because the lock on the state directory of the task could still be taken by a different stream thread on the same Streams cl

Re: [PR] KAFKA-12679: Handle lock exceptions in state updater [kafka]

2025-06-23 Thread via GitHub
a-dudko commented on PR #12875: URL: https://github.com/apache/kafka/pull/12875#issuecomment-2996565101 We are using version 3.9.1 now and we see plenty of the logs like `stream-thread [service-e7c3de52-cf29-49c3-8f9d-1eea119ea532-StreamThread-1] Encountered lock exception. Reattempting l