mimaison merged PR #16193:
URL: https://github.com/apache/kafka/pull/16193
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
mimaison commented on PR #16193:
URL: https://github.com/apache/kafka/pull/16193#issuecomment-2153146374
None of the test failures are related, merging to trunk
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
mimaison commented on code in PR #16193:
URL: https://github.com/apache/kafka/pull/16193#discussion_r1629709460
##
clients/src/test/java/org/apache/kafka/clients/admin/MockAdminClient.java:
##
@@ -728,20 +725,14 @@ synchronized public ListConsumerGroupOffsetsResult
mimaison commented on code in PR #16193:
URL: https://github.com/apache/kafka/pull/16193#discussion_r1629232827
##
clients/src/test/java/org/apache/kafka/clients/admin/MockAdminClient.java:
##
@@ -1335,10 +1335,6 @@ public synchronized void
updateConsumerGroupOffsets(final Map
mimaison commented on code in PR #16193:
URL: https://github.com/apache/kafka/pull/16193#discussion_r1629232827
##
clients/src/test/java/org/apache/kafka/clients/admin/MockAdminClient.java:
##
@@ -1335,10 +1335,6 @@ public synchronized void
updateConsumerGroupOffsets(final Map
chia7712 commented on code in PR #16193:
URL: https://github.com/apache/kafka/pull/16193#discussion_r1628424360
##
clients/src/test/java/org/apache/kafka/clients/admin/MockAdminClient.java:
##
@@ -1335,10 +1335,6 @@ public synchronized void
updateConsumerGroupOffsets(final Map
mimaison merged PR #15705:
URL: https://github.com/apache/kafka/pull/15705
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
mimaison commented on PR #15705:
URL: https://github.com/apache/kafka/pull/15705#issuecomment-2059036435
None of the test failures seem related, merging to trunk.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
mimaison commented on code in PR #15705:
URL: https://github.com/apache/kafka/pull/15705#discussion_r1565764251
##
clients/src/main/java/org/apache/kafka/clients/admin/internals/CoordinatorStrategy.java:
##
@@ -136,8 +136,8 @@ private CoordinatorKey
requireSingletonAndType(Set
mimaison commented on code in PR #15705:
URL: https://github.com/apache/kafka/pull/15705#discussion_r1565721043
##
clients/src/main/java/org/apache/kafka/common/utils/BufferSupplier.java:
##
@@ -79,12 +79,8 @@ public ByteBuffer get(int size) {
@Override
public
mimaison commented on code in PR #15705:
URL: https://github.com/apache/kafka/pull/15705#discussion_r1565719621
##
clients/src/main/java/org/apache/kafka/common/memory/GarbageCollectedMemoryPool.java:
##
@@ -37,13 +37,13 @@ public class GarbageCollectedMemoryPool extends
mimaison commented on code in PR #15705:
URL: https://github.com/apache/kafka/pull/15705#discussion_r1565718889
##
clients/src/main/java/org/apache/kafka/common/network/SslChannelBuilder.java:
##
@@ -60,7 +58,6 @@ public SslChannelBuilder(Mode mode,
this.mode = mode;
chia7712 commented on code in PR #15705:
URL: https://github.com/apache/kafka/pull/15705#discussion_r1562938471
##
clients/src/main/java/org/apache/kafka/common/memory/GarbageCollectedMemoryPool.java:
##
@@ -37,13 +37,13 @@ public class GarbageCollectedMemoryPool extends
13 matches
Mail list logo