[jira] [Commented] (KAFKA-10090) Misleading warnings: The configuration was supplied but isn't a known config

2020-06-07 Thread Chia-Ping Tsai (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10090?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17127648#comment-17127648 ] Chia-Ping Tsai commented on KAFKA-10090: [~rwruck] Let me take over this :) > M

[jira] [Assigned] (KAFKA-10090) Misleading warnings: The configuration was supplied but isn't a known config

2020-06-07 Thread Chia-Ping Tsai (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10090?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chia-Ping Tsai reassigned KAFKA-10090: -- Assignee: Chia-Ping Tsai > Misleading warnings: The configuration was supplied but is

[GitHub] [kafka] chia7712 opened a new pull request #8826: KAFKA-10090 Misleading warnings: The configuration was supplied but i…

2020-06-07 Thread GitBox
chia7712 opened a new pull request #8826: URL: https://github.com/apache/kafka/pull/8826 https://issues.apache.org/jira/browse/KAFKA-10090 ### Committer Checklist (excluded from commit message) - [ ] Verify design and implementation - [ ] Verify test coverage and CI build statu

[jira] [Commented] (KAFKA-6435) Application Reset Tool might delete incorrect internal topics

2020-06-07 Thread Joel Wee (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-6435?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17127673#comment-17127673 ] Joel Wee commented on KAFKA-6435: - Hi [~bchen225242] and [~mjsax], is this issue still wo

[GitHub] [kafka] rhauch commented on pull request #8270: KAFKA-9216: Enforce connect internal topic configuration at startup

2020-06-07 Thread GitBox
rhauch commented on pull request #8270: URL: https://github.com/apache/kafka/pull/8270#issuecomment-640234740 ok to test This is an automated message from the Apache Git Service. To respond to the message, please log on to Gi

[GitHub] [kafka] rhauch commented on pull request #8270: KAFKA-9216: Enforce connect internal topic configuration at startup

2020-06-07 Thread GitBox
rhauch commented on pull request #8270: URL: https://github.com/apache/kafka/pull/8270#issuecomment-640234683 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

[jira] [Commented] (KAFKA-6435) Application Reset Tool might delete incorrect internal topics

2020-06-07 Thread Boyang Chen (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-6435?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17127684#comment-17127684 ] Boyang Chen commented on KAFKA-6435: [~JoelWee] Thanks for your interest! Feel free t

[jira] [Created] (KAFKA-10114) Kafka producer stuck after broker crash

2020-06-07 Thread Itamar Benjamin (Jira)
Itamar Benjamin created KAFKA-10114: --- Summary: Kafka producer stuck after broker crash Key: KAFKA-10114 URL: https://issues.apache.org/jira/browse/KAFKA-10114 Project: Kafka Issue Type: Bug

[jira] [Updated] (KAFKA-10114) Kafka producer stuck after broker crash

2020-06-07 Thread Ismael Juma (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10114?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ismael Juma updated KAFKA-10114: Priority: Critical (was: Major) > Kafka producer stuck after broker crash > -

[jira] [Commented] (KAFKA-6435) Application Reset Tool might delete incorrect internal topics

2020-06-07 Thread Guozhang Wang (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-6435?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17127715#comment-17127715 ] Guozhang Wang commented on KAFKA-6435: -- What about just adding a `--internal-topics`

[GitHub] [kafka] guozhangwang commented on pull request #8815: HOTFIX: fix validity check in sticky assignor tests

2020-06-07 Thread GitBox
guozhangwang commented on pull request #8815: URL: https://github.com/apache/kafka/pull/8815#issuecomment-640248563 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub a

[jira] [Commented] (KAFKA-10091) Improve task idling

2020-06-07 Thread Guozhang Wang (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10091?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17127720#comment-17127720 ] Guozhang Wang commented on KAFKA-10091: --- Thanks John. I think you're concerning ab

[GitHub] [kafka] hachikuji commented on a change in pull request #8822: KAFKA-10113; Specify fetch offsets correctly in LogTruncationException

2020-06-07 Thread GitBox
hachikuji commented on a change in pull request #8822: URL: https://github.com/apache/kafka/pull/8822#discussion_r436386913 ## File path: clients/src/main/java/org/apache/kafka/clients/consumer/internals/Fetcher.java ## @@ -852,14 +835,28 @@ public void onFailure(RuntimeExcept

[GitHub] [kafka] hachikuji commented on a change in pull request #8822: KAFKA-10113; Specify fetch offsets correctly in LogTruncationException

2020-06-07 Thread GitBox
hachikuji commented on a change in pull request #8822: URL: https://github.com/apache/kafka/pull/8822#discussion_r436387154 ## File path: clients/src/main/java/org/apache/kafka/clients/consumer/internals/SubscriptionState.java ## @@ -480,6 +480,17 @@ public synchronized boolea

[GitHub] [kafka] hachikuji commented on a change in pull request #8822: KAFKA-10113; Specify fetch offsets correctly in LogTruncationException

2020-06-07 Thread GitBox
hachikuji commented on a change in pull request #8822: URL: https://github.com/apache/kafka/pull/8822#discussion_r436387869 ## File path: clients/src/main/java/org/apache/kafka/clients/consumer/internals/SubscriptionState.java ## @@ -1050,4 +1062,43 @@ public String toString()

[jira] [Commented] (KAFKA-10114) Kafka producer stuck after broker crash

2020-06-07 Thread Jason Gustafson (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10114?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17127730#comment-17127730 ] Jason Gustafson commented on KAFKA-10114: - [~ibinyami] Thanks for the report. Ca

[GitHub] [kafka] hachikuji commented on a change in pull request #8802: MINOR: Fix fetch session epoch comment in `FetchRequest.json`

2020-06-07 Thread GitBox
hachikuji commented on a change in pull request #8802: URL: https://github.com/apache/kafka/pull/8802#discussion_r436389230 ## File path: clients/src/main/resources/common/message/FetchRequest.json ## @@ -49,7 +49,7 @@ "fields": [ { "name": "ReplicaId", "type": "int32",

[jira] [Commented] (KAFKA-10091) Improve task idling

2020-06-07 Thread John Roesler (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10091?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17127733#comment-17127733 ] John Roesler commented on KAFKA-10091: -- Thanks Guozhang. That would certainly be ea

[GitHub] [kafka] hachikuji commented on a change in pull request #8822: KAFKA-10113; Specify fetch offsets correctly in LogTruncationException

2020-06-07 Thread GitBox
hachikuji commented on a change in pull request #8822: URL: https://github.com/apache/kafka/pull/8822#discussion_r436390686 ## File path: clients/src/main/java/org/apache/kafka/clients/consumer/internals/Fetcher.java ## @@ -1325,23 +1323,15 @@ private CompletedFetch initializ

[GitHub] [kafka] hachikuji commented on a change in pull request #8822: KAFKA-10113; Specify fetch offsets correctly in LogTruncationException

2020-06-07 Thread GitBox
hachikuji commented on a change in pull request #8822: URL: https://github.com/apache/kafka/pull/8822#discussion_r436391255 ## File path: clients/src/test/java/org/apache/kafka/clients/consumer/internals/FetcherTest.java ## @@ -3856,12 +3857,16 @@ private void testOffsetValid

[GitHub] [kafka] kkonstantine commented on pull request #8805: KAFKA-9848: Avoid triggering scheduled rebalance delay when task assignment fails but Connect workers remain in the group

2020-06-07 Thread GitBox
kkonstantine commented on pull request #8805: URL: https://github.com/apache/kafka/pull/8805#issuecomment-640268366 Latest build: jdk8 and jdk11 green jdk14 one unrelated failure at: `kafka.api.PlaintextAdminIntegrationTest.testAlterReplicaLogDirs` --

[GitHub] [kafka] kkonstantine merged pull request #8270: KAFKA-9216: Enforce internal config topic settings for Connect workers during startup

2020-06-07 Thread GitBox
kkonstantine merged pull request #8270: URL: https://github.com/apache/kafka/pull/8270 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[jira] [Commented] (KAFKA-8177) Allow for separate connect instances to have sink connectors with the same name

2020-06-07 Thread Paul Whalen (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-8177?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17127741#comment-17127741 ] Paul Whalen commented on KAFKA-8177: Sorry, I missed this comment. That sounds like

[jira] [Resolved] (KAFKA-8177) Allow for separate connect instances to have sink connectors with the same name

2020-06-07 Thread Paul Whalen (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-8177?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Paul Whalen resolved KAFKA-8177. Resolution: Resolved > Allow for separate connect instances to have sink connectors with the same

[GitHub] [kafka] kkonstantine opened a new pull request #8827: KAFKA-9849: Fix issue with worker.unsync.backoff.ms creating zombie workers when incremental cooperative rebalancing is used

2020-06-07 Thread GitBox
kkonstantine opened a new pull request #8827: URL: https://github.com/apache/kafka/pull/8827 tbd ### Committer Checklist (excluded from commit message) - [ ] Verify design and implementation - [ ] Verify test coverage and CI build status - [ ] Verify documentation (including

[jira] [Updated] (KAFKA-9216) Enforce connect internal topic configuration at startup

2020-06-07 Thread Konstantine Karantasis (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-9216?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Konstantine Karantasis updated KAFKA-9216: -- Fix Version/s: 2.5.1 2.4.2 2.6.0

[jira] [Resolved] (KAFKA-9216) Enforce connect internal topic configuration at startup

2020-06-07 Thread Konstantine Karantasis (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-9216?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Konstantine Karantasis resolved KAFKA-9216. --- Resolution: Fixed > Enforce connect internal topic configuration at startup >

[jira] [Assigned] (KAFKA-7833) StreamsBuilder should throw an exception if addGlobalStore and addStateStore is called for the same store builder

2020-06-07 Thread Matthias J. Sax (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-7833?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matthias J. Sax reassigned KAFKA-7833: -- Assignee: Rob Meng > StreamsBuilder should throw an exception if addGlobalStore and ad

[jira] [Commented] (KAFKA-7833) StreamsBuilder should throw an exception if addGlobalStore and addStateStore is called for the same store builder

2020-06-07 Thread Matthias J. Sax (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-7833?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17127754#comment-17127754 ] Matthias J. Sax commented on KAFKA-7833: Thanks for the PR. Will take a look. Al

[GitHub] [kafka] hachikuji commented on a change in pull request #8795: KAFKA-10095: Simplify calls in LogCleanerManagerTest

2020-06-07 Thread GitBox
hachikuji commented on a change in pull request #8795: URL: https://github.com/apache/kafka/pull/8795#discussion_r436401217 ## File path: core/src/test/scala/unit/kafka/log/LogCleanerManagerTest.scala ## @@ -571,12 +571,12 @@ class LogCleanerManagerTest extends Logging { c

[GitHub] [kafka] cmccabe commented on a change in pull request #8640: MINOR: equals() should check _unknownTaggedFields

2020-06-07 Thread GitBox
cmccabe commented on a change in pull request #8640: URL: https://github.com/apache/kafka/pull/8640#discussion_r436401514 ## File path: clients/src/test/java/org/apache/kafka/common/message/MessageTest.java ## @@ -962,4 +962,23 @@ private void verifyWriteSucceeds(short version

[GitHub] [kafka] cmccabe commented on a change in pull request #8640: MINOR: equals() should check _unknownTaggedFields

2020-06-07 Thread GitBox
cmccabe commented on a change in pull request #8640: URL: https://github.com/apache/kafka/pull/8640#discussion_r436401747 ## File path: generator/src/main/java/org/apache/kafka/message/MessageDataGenerator.java ## @@ -2033,15 +2033,21 @@ private void generateClassEquals(String

[jira] [Assigned] (KAFKA-6435) Application Reset Tool might delete incorrect internal topics

2020-06-07 Thread Joel Wee (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-6435?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Joel Wee reassigned KAFKA-6435: --- Assignee: Joel Wee > Application Reset Tool might delete incorrect internal topics > ---

[GitHub] [kafka] ijuma commented on a change in pull request #8640: MINOR: equals() should check _unknownTaggedFields

2020-06-07 Thread GitBox
ijuma commented on a change in pull request #8640: URL: https://github.com/apache/kafka/pull/8640#discussion_r436401914 ## File path: clients/src/test/java/org/apache/kafka/common/message/MessageTest.java ## @@ -962,4 +962,23 @@ private void verifyWriteSucceeds(short version,

[GitHub] [kafka] ijuma commented on a change in pull request #8640: MINOR: equals() should check _unknownTaggedFields

2020-06-07 Thread GitBox
ijuma commented on a change in pull request #8640: URL: https://github.com/apache/kafka/pull/8640#discussion_r436401965 ## File path: generator/src/main/java/org/apache/kafka/message/MessageDataGenerator.java ## @@ -2033,15 +2033,21 @@ private void generateClassEquals(String c

[GitHub] [kafka] mjsax commented on pull request #8825: KAFKA-7833: Add StateStore name conflict check in InternalStreamsBuilder

2020-06-07 Thread GitBox
mjsax commented on pull request #8825: URL: https://github.com/apache/kafka/pull/8825#issuecomment-640280224 Thanks for the PR. I looked into the code and the check to verify if names are overlapping is actually in `InternalTopologyBuilder` -- thus, the fix should there. In `Interna

[GitHub] [kafka] hachikuji commented on a change in pull request #8783: KAFKA-10063 UnsupportedOperation when querying cleaner metrics after …

2020-06-07 Thread GitBox
hachikuji commented on a change in pull request #8783: URL: https://github.com/apache/kafka/pull/8783#discussion_r436402304 ## File path: core/src/main/scala/kafka/log/LogCleaner.scala ## @@ -112,9 +112,19 @@ class LogCleaner(initialConfig: CleanerConfig, private[log] val

[GitHub] [kafka] hachikuji closed pull request #8770: Update quickstart.html

2020-06-07 Thread GitBox
hachikuji closed pull request #8770: URL: https://github.com/apache/kafka/pull/8770 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [kafka] hachikuji commented on pull request #8770: Update quickstart.html

2020-06-07 Thread GitBox
hachikuji commented on pull request #8770: URL: https://github.com/apache/kafka/pull/8770#issuecomment-640280937 I'm going to go ahead and close this. If we have missed something, please reopen and let us know. This is an au

[GitHub] [kafka] hachikuji commented on a change in pull request #8741: KAFKA-9332 change how to get joinGroupTimeoutMs

2020-06-07 Thread GitBox
hachikuji commented on a change in pull request #8741: URL: https://github.com/apache/kafka/pull/8741#discussion_r436402832 ## File path: clients/src/main/java/org/apache/kafka/clients/consumer/internals/AbstractCoordinator.java ## @@ -519,7 +519,7 @@ public void onFailure(Run

[jira] [Commented] (KAFKA-10091) Improve task idling

2020-06-07 Thread Matthias J. Sax (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10091?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17127766#comment-17127766 ] Matthias J. Sax commented on KAFKA-10091: - I agree with John, blocking "forever"

[GitHub] [kafka] hachikuji closed pull request #8741: KAFKA-9332 change how to get joinGroupTimeoutMs

2020-06-07 Thread GitBox
hachikuji closed pull request #8741: URL: https://github.com/apache/kafka/pull/8741 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [kafka] hachikuji commented on pull request #8741: KAFKA-9332 change how to get joinGroupTimeoutMs

2020-06-07 Thread GitBox
hachikuji commented on pull request #8741: URL: https://github.com/apache/kafka/pull/8741#issuecomment-640281800 Thanks for the patch. I'm going to close this since the code was changed separately. I don't think there's a strong reason to port the change back to 2.0, but let us know if the

[GitHub] [kafka] hachikuji commented on a change in pull request #8685: KAFKA-10014 Always try to close all channels in Selector#close

2020-06-07 Thread GitBox
hachikuji commented on a change in pull request #8685: URL: https://github.com/apache/kafka/pull/8685#discussion_r436403355 ## File path: clients/src/main/java/org/apache/kafka/common/network/Selector.java ## @@ -363,23 +363,14 @@ public void wakeup() { @Override publ

[jira] [Commented] (KAFKA-6435) Application Reset Tool might delete incorrect internal topics

2020-06-07 Thread Matthias J. Sax (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-6435?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17127772#comment-17127772 ] Matthias J. Sax commented on KAFKA-6435: I don't have a strong preference. Disall

[jira] [Commented] (KAFKA-10114) Kafka producer stuck after broker crash

2020-06-07 Thread Itamar Benjamin (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10114?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17127773#comment-17127773 ] Itamar Benjamin commented on KAFKA-10114: - Hi [~hachikuji], Thanks for looking i

[GitHub] [kafka] hachikuji commented on a change in pull request #8664: KAFKA-9716: Clarify meaning of compression rate metrics

2020-06-07 Thread GitBox
hachikuji commented on a change in pull request #8664: URL: https://github.com/apache/kafka/pull/8664#discussion_r436403864 ## File path: clients/src/main/java/org/apache/kafka/clients/producer/internals/SenderMetricsRegistry.java ## @@ -84,7 +84,7 @@ public SenderMetricsRegis

[jira] [Reopened] (KAFKA-9216) Enforce connect internal topic configuration at startup

2020-06-07 Thread Randall Hauch (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-9216?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Randall Hauch reopened KAFKA-9216: -- The previous PR only checked the number of partitions, so I'm going to reopen this to add another

[GitHub] [kafka] hachikuji commented on a change in pull request #8660: MINOR: fix stream javadoc

2020-06-07 Thread GitBox
hachikuji commented on a change in pull request #8660: URL: https://github.com/apache/kafka/pull/8660#discussion_r436405018 ## File path: build.gradle ## @@ -1065,6 +1065,7 @@ project(':clients') { include "**/org/apache/kafka/common/security/auth/*" include "**/org/a

[GitHub] [kafka] hachikuji commented on a change in pull request #8660: MINOR: fix stream javadoc

2020-06-07 Thread GitBox
hachikuji commented on a change in pull request #8660: URL: https://github.com/apache/kafka/pull/8660#discussion_r436405018 ## File path: build.gradle ## @@ -1065,6 +1065,7 @@ project(':clients') { include "**/org/apache/kafka/common/security/auth/*" include "**/org/a

[GitHub] [kafka] hachikuji commented on a change in pull request #8552: [MINOR]: Fix some java docs and move repeated `if conditioni` to the method

2020-06-07 Thread GitBox
hachikuji commented on a change in pull request #8552: URL: https://github.com/apache/kafka/pull/8552#discussion_r436405820 ## File path: core/src/main/scala/kafka/controller/ReplicaStateMachine.scala ## @@ -423,9 +414,10 @@ class ZkReplicaStateMachine(config: KafkaConfig,

[GitHub] [kafka] rhauch opened a new pull request #8828: KAFKA-9216: Enforce that Connect’s internal topics use `compact` cleanup policy

2020-06-07 Thread GitBox
rhauch opened a new pull request #8828: URL: https://github.com/apache/kafka/pull/8828 Supplements #8270 This change adds a check to the KafkaConfigBackingStore, KafkaOffsetBackingStore, and KafkaStatusBackingStore to use the admin client to verify that the internal topics are comp

[GitHub] [kafka] hachikuji commented on a change in pull request #8579: KAFKA-9930: Prevent ReplicaFetcherThread from throwing UnknownTopicOrPartitionException upon topic creation and deletion.

2020-06-07 Thread GitBox
hachikuji commented on a change in pull request #8579: URL: https://github.com/apache/kafka/pull/8579#discussion_r436406760 ## File path: core/src/main/scala/kafka/server/AbstractFetcherThread.scala ## @@ -382,6 +382,11 @@ abstract class AbstractFetcherThread(name: String,

[GitHub] [kafka] hachikuji commented on a change in pull request #8579: KAFKA-9930: Prevent ReplicaFetcherThread from throwing UnknownTopicOrPartitionException upon topic creation and deletion.

2020-06-07 Thread GitBox
hachikuji commented on a change in pull request #8579: URL: https://github.com/apache/kafka/pull/8579#discussion_r436406760 ## File path: core/src/main/scala/kafka/server/AbstractFetcherThread.scala ## @@ -382,6 +382,11 @@ abstract class AbstractFetcherThread(name: String,

[jira] [Commented] (KAFKA-9216) Enforce connect internal topic configuration at startup

2020-06-07 Thread Randall Hauch (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-9216?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17127789#comment-17127789 ] Randall Hauch commented on KAFKA-9216: -- [~kkonstantine], thanks for reviewing and me

[GitHub] [kafka] rhauch commented on pull request #8069: KAFKA-9374: Make connector interactions asynchronous

2020-06-07 Thread GitBox
rhauch commented on pull request #8069: URL: https://github.com/apache/kafka/pull/8069#issuecomment-640287934 Green builds, except for JDK 11 which failed to run due to unrelated build issues. This is an automated message fr

[GitHub] [kafka] hachikuji commented on pull request #8404: MINOR: Add ImportOrder settings to checkstyle/checkstyle.xml

2020-06-07 Thread GitBox
hachikuji commented on pull request #8404: URL: https://github.com/apache/kafka/pull/8404#issuecomment-640288084 Thanks, I think this makes sense. I also get a bit annoyed with the constant import shuffling. I'd like to hear some feedback from others though before we consider merging this.

[GitHub] [kafka] hachikuji commented on a change in pull request #8579: KAFKA-9930: Prevent ReplicaFetcherThread from throwing UnknownTopicOrPartitionException upon topic creation and deletion.

2020-06-07 Thread GitBox
hachikuji commented on a change in pull request #8579: URL: https://github.com/apache/kafka/pull/8579#discussion_r436406760 ## File path: core/src/main/scala/kafka/server/AbstractFetcherThread.scala ## @@ -382,6 +382,11 @@ abstract class AbstractFetcherThread(name: String,

[GitHub] [kafka] hachikuji commented on pull request #59: Adding ability to provide a prefix for the destination topic name. This ...

2020-06-07 Thread GitBox
hachikuji commented on pull request #59: URL: https://github.com/apache/kafka/pull/59#issuecomment-640289214 Closing this since it is addressed by MM2. Please reopen if you believe it is still valuable. This is an automated

[GitHub] [kafka] hachikuji closed pull request #59: Adding ability to provide a prefix for the destination topic name. This ...

2020-06-07 Thread GitBox
hachikuji closed pull request #59: URL: https://github.com/apache/kafka/pull/59 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [kafka] hachikuji closed pull request #69: KAFKA-2092: New partitioning for better load balancing

2020-06-07 Thread GitBox
hachikuji closed pull request #69: URL: https://github.com/apache/kafka/pull/69 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [kafka] hachikuji commented on pull request #69: KAFKA-2092: New partitioning for better load balancing

2020-06-07 Thread GitBox
hachikuji commented on pull request #69: URL: https://github.com/apache/kafka/pull/69#issuecomment-640289625 Adding new partitioning logic will require a KIP. The process is documented here: https://cwiki.apache.org/confluence/display/KAFKA/Kafka+Improvement+Proposals. I am going to close

[jira] [Created] (KAFKA-10115) Incorporate errors.tolerance with the Errant Record Reporter

2020-06-07 Thread Aakash Shah (Jira)
Aakash Shah created KAFKA-10115: --- Summary: Incorporate errors.tolerance with the Errant Record Reporter Key: KAFKA-10115 URL: https://issues.apache.org/jira/browse/KAFKA-10115 Project: Kafka I

[GitHub] [kafka] hachikuji commented on pull request #254: KAFKA-2588 ReplicaManager partitionCount metric should actually be re…

2020-06-07 Thread GitBox
hachikuji commented on pull request #254: URL: https://github.com/apache/kafka/pull/254#issuecomment-640290639 Thanks for the patch. I'm going to close this for now since it requires a KIP, but please consider reopening if you (or anyone else) has time to submit a proposal. (The change doe

[GitHub] [kafka] hachikuji closed pull request #254: KAFKA-2588 ReplicaManager partitionCount metric should actually be re…

2020-06-07 Thread GitBox
hachikuji closed pull request #254: URL: https://github.com/apache/kafka/pull/254 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to th

[jira] [Updated] (KAFKA-2341) Need Standard Deviation Metrics in MetricsBench

2020-06-07 Thread Jason Gustafson (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-2341?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jason Gustafson updated KAFKA-2341: --- Labels: needs-kip (was: ) > Need Standard Deviation Metrics in MetricsBench > --

[GitHub] [kafka] hachikuji commented on pull request #80: KAFKA-2341 Add standard deviation as metric

2020-06-07 Thread GitBox
hachikuji commented on pull request #80: URL: https://github.com/apache/kafka/pull/80#issuecomment-640290926 I'm going to close this due to inactivity. Note that this change will require a KIP since it affects the public metrics API: https://cwiki.apache.org/confluence/display/KAFKA/Kafka+

[GitHub] [kafka] hachikuji closed pull request #80: KAFKA-2341 Add standard deviation as metric

2020-06-07 Thread GitBox
hachikuji closed pull request #80: URL: https://github.com/apache/kafka/pull/80 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[jira] [Created] (KAFKA-10116) GraalVM native-image prototype

2020-06-07 Thread Ismael Juma (Jira)
Ismael Juma created KAFKA-10116: --- Summary: GraalVM native-image prototype Key: KAFKA-10116 URL: https://issues.apache.org/jira/browse/KAFKA-10116 Project: Kafka Issue Type: Improvement

[GitHub] [kafka] aakashnshah opened a new pull request #8829: KAFKA-10115: Incorporate errors.tolerance with the Errant Record Reporter

2020-06-07 Thread GitBox
aakashnshah opened a new pull request #8829: URL: https://github.com/apache/kafka/pull/8829 Currently, the errant record reporter doesn't take into account the value of `errors.tolerance.` Added a check if the reporter is within the tolerance limits; if not, then a `ConnectException` is th

[jira] [Comment Edited] (KAFKA-9216) Enforce connect internal topic configuration at startup

2020-06-07 Thread Randall Hauch (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-9216?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17127789#comment-17127789 ] Randall Hauch edited comment on KAFKA-9216 at 6/7/20, 10:58 PM: ---

[jira] [Updated] (KAFKA-9468) config.storage.topic partition count issue is hard to debug

2020-06-07 Thread Randall Hauch (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-9468?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Randall Hauch updated KAFKA-9468: - Fix Version/s: 2.5.1 2.4.2 2.6.0 2.3.2 >

[jira] [Commented] (KAFKA-9468) config.storage.topic partition count issue is hard to debug

2020-06-07 Thread Randall Hauch (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-9468?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17127796#comment-17127796 ] Randall Hauch commented on KAFKA-9468: -- This issue should be fixed by KAFKA-9216, si

[jira] [Resolved] (KAFKA-9468) config.storage.topic partition count issue is hard to debug

2020-06-07 Thread Randall Hauch (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-9468?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Randall Hauch resolved KAFKA-9468. -- Assignee: Randall Hauch Resolution: Fixed > config.storage.topic partition count issue is

[GitHub] [kafka] robin5540 commented on pull request #8825: KAFKA-7833: Add StateStore name conflict check in InternalStreamsBuilder

2020-06-07 Thread GitBox
robin5540 commented on pull request #8825: URL: https://github.com/apache/kafka/pull/8825#issuecomment-640293871 @mjsax Makes sense. I'll push out the change tonight 👍 This is an automated message from the Apache Git Service

[GitHub] [kafka] rhauch commented on a change in pull request #8829: KAFKA-10115: Incorporate errors.tolerance with the Errant Record Reporter

2020-06-07 Thread GitBox
rhauch commented on a change in pull request #8829: URL: https://github.com/apache/kafka/pull/8829#discussion_r436411235 ## File path: connect/runtime/src/main/java/org/apache/kafka/connect/runtime/errors/RetryWithToleranceOperator.java ## @@ -87,6 +87,12 @@ public RetryWithTo

[GitHub] [kafka] ijuma opened a new pull request #8830: KAFKA-10116: GraalVM native-image prototype

2020-06-07 Thread GitBox
ijuma opened a new pull request #8830: URL: https://github.com/apache/kafka/pull/8830 I can generate a native image with the added task, but it exists soon after start-up. ### Committer Checklist (excluded from commit message) - [ ] Verify design and implementation - [ ] Ver

[GitHub] [kafka] rhauch commented on a change in pull request #8829: KAFKA-10115: Incorporate errors.tolerance with the Errant Record Reporter

2020-06-07 Thread GitBox
rhauch commented on a change in pull request #8829: URL: https://github.com/apache/kafka/pull/8829#discussion_r436411235 ## File path: connect/runtime/src/main/java/org/apache/kafka/connect/runtime/errors/RetryWithToleranceOperator.java ## @@ -87,6 +87,12 @@ public RetryWithTo

[GitHub] [kafka] rhauch commented on a change in pull request #8829: KAFKA-10115: Incorporate errors.tolerance with the Errant Record Reporter

2020-06-07 Thread GitBox
rhauch commented on a change in pull request #8829: URL: https://github.com/apache/kafka/pull/8829#discussion_r436411235 ## File path: connect/runtime/src/main/java/org/apache/kafka/connect/runtime/errors/RetryWithToleranceOperator.java ## @@ -87,6 +87,12 @@ public RetryWithTo

[GitHub] [kafka] rhauch commented on a change in pull request #8829: KAFKA-10115: Incorporate errors.tolerance with the Errant Record Reporter

2020-06-07 Thread GitBox
rhauch commented on a change in pull request #8829: URL: https://github.com/apache/kafka/pull/8829#discussion_r436411235 ## File path: connect/runtime/src/main/java/org/apache/kafka/connect/runtime/errors/RetryWithToleranceOperator.java ## @@ -87,6 +87,12 @@ public RetryWithTo

[GitHub] [kafka] ijuma commented on pull request #8404: MINOR: Add ImportOrder settings to checkstyle/checkstyle.xml

2020-06-07 Thread GitBox
ijuma commented on pull request #8404: URL: https://github.com/apache/kafka/pull/8404#issuecomment-640295614 I think this would be good. A couple of things: 1. This will generate a massive diff. 2. It would be good to have ways to format correctly automatically. It will be really

[GitHub] [kafka] ijuma commented on pull request #8684: KAFKA-10012 Reducing memory overhead associated with strings in Metri…

2020-06-07 Thread GitBox
ijuma commented on pull request #8684: URL: https://github.com/apache/kafka/pull/8684#issuecomment-640295811 @hachikuji feel free to merge, my main concern was the `intern` calls that have been removed. We should update the commit message to remove the bit about interning before merging.

[jira] [Created] (KAFKA-10117) TimingWheel addOverflowWheel

2020-06-07 Thread Rhett.Wang (Jira)
Rhett.Wang created KAFKA-10117: -- Summary: TimingWheel addOverflowWheel Key: KAFKA-10117 URL: https://issues.apache.org/jira/browse/KAFKA-10117 Project: Kafka Issue Type: Wish Componen

[jira] [Commented] (KAFKA-10062) Add a method to retrieve the current timestamp as known by the Streams app

2020-06-07 Thread Sumant (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10062?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17127807#comment-17127807 ] Sumant commented on KAFKA-10062: Hi [~wbottrell], I am also a newbie to this project and

[jira] [Commented] (KAFKA-10062) Add a method to retrieve the current timestamp as known by the Streams app

2020-06-07 Thread William Bottrell (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10062?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17127811#comment-17127811 ] William Bottrell commented on KAFKA-10062: -- [~sumantrana] yeah, I plan on worki

[GitHub] [kafka] kkonstantine commented on a change in pull request #8828: KAFKA-9216: Enforce that Connect’s internal topics use `compact` cleanup policy

2020-06-07 Thread GitBox
kkonstantine commented on a change in pull request #8828: URL: https://github.com/apache/kafka/pull/8828#discussion_r436421647 ## File path: connect/runtime/src/main/java/org/apache/kafka/connect/util/TopicAdmin.java ## @@ -375,6 +383,152 @@ public boolean createTopic(NewTopic

[GitHub] [kafka] hachikuji merged pull request #8684: KAFKA-10012 Reducing memory overhead associated with strings in Metri…

2020-06-07 Thread GitBox
hachikuji merged pull request #8684: URL: https://github.com/apache/kafka/pull/8684 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[jira] [Resolved] (KAFKA-10012) Reducing memory overhead associated with strings in MetricName

2020-06-07 Thread Jason Gustafson (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10012?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jason Gustafson resolved KAFKA-10012. - Fix Version/s: 2.6.0 Resolution: Fixed > Reducing memory overhead associated with

[GitHub] [kafka] sh-abhi commented on pull request #6229: KAFKA-6786: Removing additional configs for StreamsBrokerDownResilienceTest

2020-06-07 Thread GitBox
sh-abhi commented on pull request #6229: URL: https://github.com/apache/kafka/pull/6229#issuecomment-640318293 @bbejeck I'm having some difficulty doing a rebase successfully after trying some different approaches based on some references I found online. Any suggestions, or should I just o

[GitHub] [kafka] jiameixie opened a new pull request #8831: KAFKA-8657:Client-side automatic topic creation on Producer

2020-06-07 Thread GitBox
jiameixie opened a new pull request #8831: URL: https://github.com/apache/kafka/pull/8831 Add support to configure allow.auto.create.topics.enable on producer client. This patch is based on https://github.com/apache/kafka/pull/7075, with rebase to current HEAD and add new test cases

[GitHub] [kafka] prehistoric-penguin commented on pull request #6403: KAFKA-6188; Fix windows clean log fail caused shut down

2020-06-07 Thread GitBox
prehistoric-penguin commented on pull request #6403: URL: https://github.com/apache/kafka/pull/6403#issuecomment-640324519 > Not sure if this PR was ever merged. If yes, which release I need to download to get the fix? > If not, please reconsider. We really need to support Windows for so

[GitHub] [kafka] chia7712 commented on a change in pull request #8660: MINOR: fix stream javadoc

2020-06-07 Thread GitBox
chia7712 commented on a change in pull request #8660: URL: https://github.com/apache/kafka/pull/8660#discussion_r436429969 ## File path: build.gradle ## @@ -1065,6 +1065,7 @@ project(':clients') { include "**/org/apache/kafka/common/security/auth/*" include "**/org/ap

[GitHub] [kafka] chia7712 commented on pull request #8660: MINOR: fix stream javadoc

2020-06-07 Thread GitBox
chia7712 commented on pull request #8660: URL: https://github.com/apache/kafka/pull/8660#issuecomment-640324949 > One other question I had is whether we should consider making doc failures also fail the build? +1000 It seems to me the fixes to doc errors is too verbose as doc

[jira] [Assigned] (KAFKA-10062) Add a method to retrieve the current timestamp as known by the Streams app

2020-06-07 Thread Matthias J. Sax (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10062?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matthias J. Sax reassigned KAFKA-10062: --- Assignee: William Bottrell > Add a method to retrieve the current timestamp as know

[jira] [Commented] (KAFKA-10062) Add a method to retrieve the current timestamp as known by the Streams app

2020-06-07 Thread Matthias J. Sax (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10062?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17127836#comment-17127836 ] Matthias J. Sax commented on KAFKA-10062: - [~wbottrell] I added you to the list

[jira] [Created] (KAFKA-10118) Improve stickiness verification for AbstractStickyAssignorTest

2020-06-07 Thread Luke Chen (Jira)
Luke Chen created KAFKA-10118: - Summary: Improve stickiness verification for AbstractStickyAssignorTest Key: KAFKA-10118 URL: https://issues.apache.org/jira/browse/KAFKA-10118 Project: Kafka Iss

[jira] [Updated] (KAFKA-10118) Improve stickiness verification for AbstractStickyAssignorTest

2020-06-07 Thread Luke Chen (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10118?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Luke Chen updated KAFKA-10118: -- Description: In KAFKA-9987 , we implemented an optimized sticky partition assignor algorithm (i.e. {{

[jira] [Updated] (KAFKA-10118) Improve stickiness verification for AbstractStickyAssignorTest

2020-06-07 Thread Luke Chen (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10118?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Luke Chen updated KAFKA-10118: -- Description: In KAFKA-9987 , we implemented an optimized sticky partition assignor algorithm (i.e. {{

[GitHub] [kafka] aakashnshah commented on a change in pull request #8829: KAFKA-10115: Incorporate errors.tolerance with the Errant Record Reporter

2020-06-07 Thread GitBox
aakashnshah commented on a change in pull request #8829: URL: https://github.com/apache/kafka/pull/8829#discussion_r436437989 ## File path: connect/runtime/src/main/java/org/apache/kafka/connect/runtime/errors/RetryWithToleranceOperator.java ## @@ -87,6 +87,12 @@ public RetryW

[GitHub] [kafka] showuon commented on pull request #8788: MINOR: Remove unused isSticky assert out from tests only do constrainedAssign

2020-06-07 Thread GitBox
showuon commented on pull request #8788: URL: https://github.com/apache/kafka/pull/8788#issuecomment-640337271 Thanks for the comment, @ableegoldman . Yes, I agree we should improve the stickiness verification, but I haven't got a better idea for that so far. I've created a ticket to track

  1   2   >