chia7712 opened a new pull request #8913:
URL: https://github.com/apache/kafka/pull/8913
We have to call ```KafkaStreams#cleanUp``` to reset local state before
starting application up the second run.
issue: https://issues.apache.org/jira/browse/KAFKA-10191
### Committer
chia7712 commented on pull request #8913:
URL: https://github.com/apache/kafka/pull/8913#issuecomment-647940047
@ableegoldman Could you take a look?
This is an automated message from the Apache Git Service.
To respond to the
Chia-Ping Tsai created KAFKA-10194:
--
Summary: run the reset tool between stopping StreamsOptimizedTest
and starting the new one
Key: KAFKA-10194
URL: https://issues.apache.org/jira/browse/KAFKA-10194
[
https://issues.apache.org/jira/browse/KAFKA-10191?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Chia-Ping Tsai updated KAFKA-10191:
---
Summary: fix flaky StreamsOptimizedTest - call KafkaStreams#cleanUp before
starting the
[
https://issues.apache.org/jira/browse/KAFKA-10191?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17142662#comment-17142662
]
Chia-Ping Tsai commented on KAFKA-10191:
{quote}
run the reset tool between stopping the
chia7712 commented on pull request #8901:
URL: https://github.com/apache/kafka/pull/8901#issuecomment-647991744
retest this please
This is an automated message from the Apache Git Service.
To respond to the message, please
cadonna commented on a change in pull request #8892:
URL: https://github.com/apache/kafka/pull/8892#discussion_r444067825
##
File path:
streams/src/test/java/org/apache/kafka/streams/processor/internals/StreamsPartitionAssignorTest.java
##
@@ -1953,6 +1975,54 @@ public void
cadonna commented on pull request #8914:
URL: https://github.com/apache/kafka/pull/8914#issuecomment-648076302
Call for review: @abbccdda @mjsax @vvcephei @guozhangwang @ableegoldman
This is an automated message from the
[
https://issues.apache.org/jira/browse/KAFKA-9693?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17142857#comment-17142857
]
João Oliveirinha commented on KAFKA-9693:
-
Has anyone been able to reproduce this and identify
[
https://issues.apache.org/jira/browse/KAFKA-9693?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17142857#comment-17142857
]
João Oliveirinha edited comment on KAFKA-9693 at 6/23/20, 11:36 AM:
viktorsomogyi commented on a change in pull request #4090:
URL: https://github.com/apache/kafka/pull/4090#discussion_r444167834
##
File path: core/src/main/scala/kafka/utils/Json.scala
##
@@ -65,6 +63,16 @@ object Json {
catch { case e: JsonProcessingException => Left(e)
viktorsomogyi commented on a change in pull request #4090:
URL: https://github.com/apache/kafka/pull/4090#discussion_r444167954
##
File path: core/src/test/scala/unit/kafka/admin/ReassignPartitionsUnitTest.scala
##
@@ -641,4 +642,21 @@ class ReassignPartitionsUnitTest {
viktorsomogyi commented on a change in pull request #4090:
URL: https://github.com/apache/kafka/pull/4090#discussion_r444168086
##
File path: core/src/main/scala/kafka/admin/ReassignPartitionsCommand.scala
##
@@ -1609,14 +1610,15 @@ object ReassignPartitionsCommand extends
[
https://issues.apache.org/jira/browse/KAFKA-9693?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17142857#comment-17142857
]
João Oliveirinha edited comment on KAFKA-9693 at 6/23/20, 11:38 AM:
dajac opened a new pull request #8915:
URL: https://github.com/apache/kafka/pull/8915
Small optimization in building LeaderAndIsrRequest to avoid iterating twice
on the partitions.
### Committer Checklist (excluded from commit message)
- [ ] Verify design and implementation
-
dajac commented on pull request #8915:
URL: https://github.com/apache/kafka/pull/8915#issuecomment-648155793
@hachikuji Could you take a look at this one please?
This is an automated message from the Apache Git Service.
To
dajac commented on pull request #8916:
URL: https://github.com/apache/kafka/pull/8916#issuecomment-648155548
@cmccabe What do you think about adding those?
This is an automated message from the Apache Git Service.
To respond
dajac opened a new pull request #8916:
URL: https://github.com/apache/kafka/pull/8916
At the moment, the only way available to get the supported versions of a
Message is to look at the number of defined schemas, assuming that the lowest
version is 0. This PR adds static constants with the
cadonna commented on pull request #8914:
URL: https://github.com/apache/kafka/pull/8914#issuecomment-648176140
Hold on! I found some issues with this PR.
This is an automated message from the Apache Git Service.
To respond
dengziming created KAFKA-10195:
--
Summary: Move offset management codes from ConsumerCoordinator to
a new class
Key: KAFKA-10195
URL: https://issues.apache.org/jira/browse/KAFKA-10195
Project: Kafka
chia7712 commented on pull request #8901:
URL: https://github.com/apache/kafka/pull/8901#issuecomment-647991641
```
15:06:25 org.apache.kafka.connect.mirror.MirrorConnectorsIntegrationTest >
testReplication FAILED
15:06:25 java.lang.RuntimeException: Could not find enough
Ikxyz edited a comment on pull request #6403:
URL: https://github.com/apache/kafka/pull/6403#issuecomment-648069247
You tried your best man nice job... it's a shame they refuse to give these
issues the right amount of attention it deserves... Glad Microsoft stepped up
Thanks for all
Ikxyz commented on pull request #6403:
URL: https://github.com/apache/kafka/pull/6403#issuecomment-648069247
You tried your best man nice job... it's a shame they refuse to these issues
the right amount of attention it deserves... Glad Microsoft stepped up
Thanks for all the help
[
https://issues.apache.org/jira/browse/KAFKA-9693?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
João Oliveirinha updated KAFKA-9693:
Attachment: image-2020-06-23-12-24-46-548.png
> Kafka latency spikes caused by log segment
[
https://issues.apache.org/jira/browse/KAFKA-9693?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
João Oliveirinha updated KAFKA-9693:
Attachment: image-2020-06-23-12-24-58-788.png
> Kafka latency spikes caused by log segment
cadonna opened a new pull request #8914:
URL: https://github.com/apache/kafka/pull/8914
During Streams' system tests the PIDs of the Streams
clients are collected. The method the collects the PIDs
swallows any exception that might be thrown by the
`ssh_capture()` function.
michael-carter-instaclustr commented on pull request #8844:
URL: https://github.com/apache/kafka/pull/8844#issuecomment-648002707
OK, I've made the changes that we discussed.
This is an automated message from the Apache Git
[
https://issues.apache.org/jira/browse/KAFKA-10195?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17142811#comment-17142811
]
dengziming commented on KAFKA-10195:
[~bchen225242], [~guozhang],[~hachikuji]
Hi, please take a
cadonna commented on a change in pull request #8902:
URL: https://github.com/apache/kafka/pull/8902#discussion_r444319623
##
File path:
streams/src/main/java/org/apache/kafka/streams/state/internals/MeteredKeyValueStore.java
##
@@ -103,8 +104,12 @@ public void init(final
[
https://issues.apache.org/jira/browse/KAFKA-10192?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17143052#comment-17143052
]
Boyang Chen commented on KAFKA-10192:
-
Failed again:
chia7712 commented on pull request #8657:
URL: https://github.com/apache/kafka/pull/8657#issuecomment-648254987
> Could you rebase your PR?
done
This is an automated message from the Apache Git Service.
To respond to
junrao commented on pull request #8657:
URL: https://github.com/apache/kafka/pull/8657#issuecomment-648259565
Thanks. Triggering another round of system tests.
This is an automated message from the Apache Git Service.
To
[
https://issues.apache.org/jira/browse/KAFKA-10192?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Chris Egerton reassigned KAFKA-10192:
-
Assignee: Chris Egerton
> Flaky test BlockingConnectorTest#testBlockInConnectorStop
>
[
https://issues.apache.org/jira/browse/KAFKA-10192?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17143092#comment-17143092
]
Chris Egerton commented on KAFKA-10192:
---
[~bchen225242] I have a hypothesis for why these tests
[
https://issues.apache.org/jira/browse/KAFKA-10140?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17143094#comment-17143094
]
Chia-Ping Tsai commented on KAFKA-10140:
The plugin component, like JmxReporter, does not offer
skaundinya15 commented on pull request #8894:
URL: https://github.com/apache/kafka/pull/8894#issuecomment-648280522
@showuon no more comments
> Hi @ryannedolan @skaundinya15 , do you have any other comments? I think we
should merge this PR soon since the tests fails today's test
skaundinya15 edited a comment on pull request #8894:
URL: https://github.com/apache/kafka/pull/8894#issuecomment-648280522
> Hi @ryannedolan @skaundinya15 , do you have any other comments? I think we
should merge this PR soon since the tests fails today's test again. Thanks.
[
https://issues.apache.org/jira/browse/KAFKA-9693?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17143037#comment-17143037
]
Jun Rao commented on KAFKA-9693:
[~joliveirinha]: Thanks for the info. I am not sure that we fully
abbccdda commented on pull request #8845:
URL: https://github.com/apache/kafka/pull/8845#issuecomment-648242282
Also failed:
```
kafka.api.PlaintextAdminIntegrationTest.testAlterReplicaLogDirs
org.scalatest.exceptions.TestFailedException: only 0 messages are produced
within
abbccdda commented on pull request #8845:
URL: https://github.com/apache/kafka/pull/8845#issuecomment-648241834
retest this please
This is an automated message from the Apache Git Service.
To respond to the message, please
cadonna commented on a change in pull request #8902:
URL: https://github.com/apache/kafka/pull/8902#discussion_r444321079
##
File path:
streams/src/main/java/org/apache/kafka/streams/state/internals/MeteredKeyValueStore.java
##
@@ -103,8 +104,12 @@ public void init(final
cadonna commented on a change in pull request #8902:
URL: https://github.com/apache/kafka/pull/8902#discussion_r444321667
##
File path:
streams/src/main/java/org/apache/kafka/streams/processor/internals/ProcessorContextImpl.java
##
@@ -103,7 +102,6 @@ public
[
https://issues.apache.org/jira/browse/KAFKA-10140?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17143094#comment-17143094
]
Chia-Ping Tsai edited comment on KAFKA-10140 at 6/23/20, 4:49 PM:
--
The
[
https://issues.apache.org/jira/browse/KAFKA-10191?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17143105#comment-17143105
]
Sophie Blee-Goldman commented on KAFKA-10191:
-
Cool. Since this is failing pretty regularly,
[
https://issues.apache.org/jira/browse/KAFKA-10194?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Sophie Blee-Goldman updated KAFKA-10194:
Labels: newbie (was: )
> run the reset tool between stopping
[
https://issues.apache.org/jira/browse/KAFKA-10194?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Sophie Blee-Goldman updated KAFKA-10194:
Component/s: system tests
streams
> run the reset tool between
abbccdda merged pull request #8901:
URL: https://github.com/apache/kafka/pull/8901
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
junrao commented on pull request #8657:
URL: https://github.com/apache/kafka/pull/8657#issuecomment-648254407
@chia7712 : I think the client compatibility test failures are probably
because you haven't rebased the PR. #8841 was fixed 6 days ago. Could you
rebase your PR?
[
https://issues.apache.org/jira/browse/KAFKA-10173?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17143075#comment-17143075
]
John Roesler commented on KAFKA-10173:
--
Hi [~karsten.schnitter] ,
Thanks for your efforts. I'm
cadonna commented on pull request #8902:
URL: https://github.com/apache/kafka/pull/8902#issuecomment-648271480
@ableegoldman could you also have a look at this PR since I think I changed
some code you are quite familiar with.
[
https://issues.apache.org/jira/browse/KAFKA-8416?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17143022#comment-17143022
]
Bill Bejeck commented on KAFKA-8416:
Hi, [~ableegoldman] thanks for the reminder.
I think we're
cadonna commented on a change in pull request #8902:
URL: https://github.com/apache/kafka/pull/8902#discussion_r444325329
##
File path:
streams/src/main/java/org/apache/kafka/streams/processor/internals/ProcessorContextImpl.java
##
@@ -120,7 +118,7 @@ public void
junrao commented on pull request #8657:
URL: https://github.com/apache/kafka/pull/8657#issuecomment-648249808
There were still lots of client compatibility related failures
[
https://issues.apache.org/jira/browse/KAFKA-10173?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17143066#comment-17143066
]
Karsten Schnitter commented on KAFKA-10173:
---
Hi [~vvcephei],
the original message is lost due
cadonna commented on a change in pull request #8902:
URL: https://github.com/apache/kafka/pull/8902#discussion_r444334835
##
File path:
streams/src/test/java/org/apache/kafka/streams/kstream/internals/graph/TableSourceNodeTest.java
##
@@ -0,0 +1,58 @@
+/*
+ * Licensed to the
d8tltanc commented on pull request #8683:
URL: https://github.com/apache/kafka/pull/8683#issuecomment-648288498
@dajac @rajinisivaram Thanks for the second round of review. I've addressed
your comments and adopted your suggestions. Please let me know if you have more
thoughts on this PR.
[
https://issues.apache.org/jira/browse/KAFKA-10192?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17143135#comment-17143135
]
Chris Egerton commented on KAFKA-10192:
---
I think what might be happening is that the worker is
[
https://issues.apache.org/jira/browse/KAFKA-10140?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17143153#comment-17143153
]
Ismael Juma commented on KAFKA-10140:
-
I understand now. Yeah, I ran into this issue before when
[
https://issues.apache.org/jira/browse/KAFKA-9846?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17143158#comment-17143158
]
Vinoth Chandar commented on KAFKA-9846:
---
Probably don't have time this week.. But if y'all can take
[
https://issues.apache.org/jira/browse/KAFKA-10105?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17143168#comment-17143168
]
Gokul Ramanan Subramanian commented on KAFKA-10105:
---
[~ableegoldman], we are unable to
[
https://issues.apache.org/jira/browse/KAFKA-9846?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17143228#comment-17143228
]
Sophie Blee-Goldman commented on KAFKA-9846:
Ok no worries. I don't think it's critical, just
[
https://issues.apache.org/jira/browse/KAFKA-10140?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17143108#comment-17143108
]
Ismael Juma commented on KAFKA-10140:
-
We should check why alterConfigs handles this correctly and
[
https://issues.apache.org/jira/browse/KAFKA-10140?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17143112#comment-17143112
]
Chia-Ping Tsai commented on KAFKA-10140:
alterConfigs does not support APPEND and SUBTRACT so it
ableegoldman commented on a change in pull request #8913:
URL: https://github.com/apache/kafka/pull/8913#discussion_r444383211
##
File path:
streams/src/test/java/org/apache/kafka/streams/tests/StreamsOptimizedTest.java
##
@@ -130,6 +130,8 @@ public static void main(final
cyrusv opened a new pull request #8918:
URL: https://github.com/apache/kafka/pull/8918
This very simply reduces the log level for these very frequently logged,
very infrequently useful log messages to debug level.
My experience operating these connectors is that these logs make reading
ableegoldman commented on a change in pull request #8913:
URL: https://github.com/apache/kafka/pull/8913#discussion_r444368127
##
File path:
streams/src/main/java/org/apache/kafka/streams/processor/internals/assignment/ClientState.java
##
@@ -303,7 +303,8 @@ public void
nizhikov opened a new pull request #8917:
URL: https://github.com/apache/kafka/pull/8917
After 8b22b8159673bfe22d8ac5dcd4e4312d4f2c863c `security_config` properties
are modified during `setup_node`: tls_version patched according to the node jdk
version. But python `@property` decorator
chia7712 commented on a change in pull request #8913:
URL: https://github.com/apache/kafka/pull/8913#discussion_r444374011
##
File path:
streams/src/test/java/org/apache/kafka/streams/tests/StreamsOptimizedTest.java
##
@@ -130,6 +130,8 @@ public static void main(final
chia7712 commented on a change in pull request #8913:
URL: https://github.com/apache/kafka/pull/8913#discussion_r444373556
##
File path:
streams/src/main/java/org/apache/kafka/streams/processor/internals/assignment/ClientState.java
##
@@ -303,7 +303,8 @@ public void
guozhangwang commented on pull request #8900:
URL: https://github.com/apache/kafka/pull/8900#issuecomment-648298106
test this
This is an automated message from the Apache Git Service.
To respond to the message, please log on
ableegoldman commented on a change in pull request #8712:
URL: https://github.com/apache/kafka/pull/8712#discussion_r444555724
##
File path:
streams/src/main/java/org/apache/kafka/streams/processor/internals/InternalTopicManager.java
##
@@ -98,9 +98,10 @@ public
mjsax commented on a change in pull request #8920:
URL: https://github.com/apache/kafka/pull/8920#discussion_r444554053
##
File path: docs/streams/developer-guide/processor-api.html
##
@@ -49,6 +49,7 @@
Defining and creating a
State Store
skaundinya15 commented on a change in pull request #8846:
URL: https://github.com/apache/kafka/pull/8846#discussion_r444631685
##
File path:
clients/src/main/java/org/apache/kafka/clients/CommonClientConfigs.java
##
@@ -84,6 +84,9 @@
public static final String
satishbellapu commented on pull request #8921:
URL: https://github.com/apache/kafka/pull/8921#issuecomment-648602105
@omkreddy cc
This is an automated message from the Apache Git Service.
To respond to the message, please
skaundinya15 commented on a change in pull request #8846:
URL: https://github.com/apache/kafka/pull/8846#discussion_r444631685
##
File path:
clients/src/main/java/org/apache/kafka/clients/CommonClientConfigs.java
##
@@ -84,6 +84,9 @@
public static final String
[
https://issues.apache.org/jira/browse/KAFKA-10179?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17143238#comment-17143238
]
Sophie Blee-Goldman commented on KAFKA-10179:
-
[~desai.p.rohan] I'm not sure I understand
mimaison commented on a change in pull request #8604:
URL: https://github.com/apache/kafka/pull/8604#discussion_r444504939
##
File path: core/src/main/scala/kafka/tools/ConsoleConsumer.scala
##
@@ -560,16 +561,15 @@ class LoggingMessageFormatter extends MessageFormatter
with
abbccdda merged pull request #8174:
URL: https://github.com/apache/kafka/pull/8174
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
[
https://issues.apache.org/jira/browse/KAFKA-9846?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17143275#comment-17143275
]
Vinoth Chandar commented on KAFKA-9846:
---
Sounds good. Close this as "Wont fix" then?
> Race
ableegoldman commented on pull request #8900:
URL: https://github.com/apache/kafka/pull/8900#issuecomment-648404327
One unrelated failure: `PlaintextProducerSendTest.testNonBlockingProducer`
This is an automated message from
[
https://issues.apache.org/jira/browse/KAFKA-10195?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
dengziming updated KAFKA-10195:
---
Attachment: image-2020-06-24-10-47-44-733.png
> Move offset management codes from
[
https://issues.apache.org/jira/browse/KAFKA-10177?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Sophie Blee-Goldman updated KAFKA-10177:
Summary: Replace/improve Percentiles metrics (was: Replace/improve/remove
[
https://issues.apache.org/jira/browse/KAFKA-10195?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
dengziming updated KAFKA-10195:
---
Description:
ConsumerCoordinator has 2 main functions:
# partitions assignment
# offset
[
https://issues.apache.org/jira/browse/KAFKA-10195?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
dengziming updated KAFKA-10195:
---
Description:
ConsumerCoordinator has 2 main functions:
# partitions assignment
# offset
[
https://issues.apache.org/jira/browse/KAFKA-10177?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Sophie Blee-Goldman updated KAFKA-10177:
Description:
There's an existing – but seemingly unused – implementation of
[
https://issues.apache.org/jira/browse/KAFKA-9678?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Sanjana Kaundinya resolved KAFKA-9678.
--
Resolution: Duplicate
> Introduce bounded exponential backoff in clients
>
[
https://issues.apache.org/jira/browse/KAFKA-9800?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17124340#comment-17124340
]
Sanjana Kaundinya edited comment on KAFKA-9800 at 6/24/20, 4:24 AM:
[
https://issues.apache.org/jira/browse/KAFKA-9678?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17143505#comment-17143505
]
Sanjana Kaundinya commented on KAFKA-9678:
--
The work for this is being done by [~d8tltanc] in
[
https://issues.apache.org/jira/browse/KAFKA-9800?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17124340#comment-17124340
]
Sanjana Kaundinya edited comment on KAFKA-9800 at 6/24/20, 4:24 AM:
mjsax commented on a change in pull request #8900:
URL: https://github.com/apache/kafka/pull/8900#discussion_r444516858
##
File path:
streams/src/main/java/org/apache/kafka/streams/processor/internals/StreamsMetadataState.java
##
@@ -152,9 +152,9 @@ public StreamsMetadata
ableegoldman commented on a change in pull request #8900:
URL: https://github.com/apache/kafka/pull/8900#discussion_r444522543
##
File path:
streams/src/main/java/org/apache/kafka/streams/processor/internals/StreamsMetadataState.java
##
@@ -152,9 +152,9 @@ public
ableegoldman commented on a change in pull request #8900:
URL: https://github.com/apache/kafka/pull/8900#discussion_r444525997
##
File path:
streams/src/main/java/org/apache/kafka/streams/processor/internals/TaskManager.java
##
@@ -679,92 +675,166 @@ private void
ableegoldman opened a new pull request #8919:
URL: https://github.com/apache/kafka/pull/8919
Hotfix for patching this in older branches
This is an automated message from the Apache Git Service.
To respond to the message,
abbccdda merged pull request #8845:
URL: https://github.com/apache/kafka/pull/8845
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
ableegoldman commented on pull request #8919:
URL: https://github.com/apache/kafka/pull/8919#issuecomment-648455230
cc @mjsax
This is an automated message from the Apache Git Service.
To respond to the message, please log
abbccdda commented on pull request #8585:
URL: https://github.com/apache/kafka/pull/8585#issuecomment-648460501
Only known flaky test failures:
```
org.apache.kafka.connect.mirror.MirrorConnectorsIntegrationTest.testReplication
ableegoldman commented on a change in pull request #8902:
URL: https://github.com/apache/kafka/pull/8902#discussion_r444552897
##
File path:
streams/src/main/java/org/apache/kafka/streams/processor/internals/AbstractProcessorStateManager.java
##
@@ -0,0 +1,33 @@
+/*
+ *
guozhangwang commented on pull request #8900:
URL: https://github.com/apache/kafka/pull/8900#issuecomment-648472153
LGTM! I will merge after green jenkins.
This is an automated message from the Apache Git Service.
To respond
mjsax commented on a change in pull request #8900:
URL: https://github.com/apache/kafka/pull/8900#discussion_r444517907
##
File path:
streams/src/main/java/org/apache/kafka/streams/processor/internals/TaskManager.java
##
@@ -679,92 +675,166 @@ private void cleanupTask(final
mjsax commented on a change in pull request #8900:
URL: https://github.com/apache/kafka/pull/8900#discussion_r444517746
##
File path:
streams/src/main/java/org/apache/kafka/streams/processor/internals/TaskManager.java
##
@@ -679,92 +675,166 @@ private void cleanupTask(final
1 - 100 of 132 matches
Mail list logo
