[GitHub] [kafka] vgvineet4 commented on a change in pull request #9254: KAFKA-10462: Added support to pass headers in producerPerformance script

2020-09-20 Thread GitBox
vgvineet4 commented on a change in pull request #9254: URL: https://github.com/apache/kafka/pull/9254#discussion_r491690401 ## File path: tools/src/main/java/org/apache/kafka/tools/ProducerPerformance.java ## @@ -132,12 +138,16 @@ public static void main(String[] args) throws E

[GitHub] [kafka] huangyiminghappy commented on pull request #9304: KAFKA-10502:TimestampRouter may occur threadlocal leak

2020-09-20 Thread GitBox
huangyiminghappy commented on pull request #9304: URL: https://github.com/apache/kafka/pull/9304#issuecomment-695813133 @hachikuji would you help to review this pr. This is an automated message from the Apache Git S

[GitHub] [kafka] guozhangwang commented on a change in pull request #9130: KAFKA-10492; Core Kafka Raft Implementation (KIP-595)

2020-09-20 Thread GitBox
guozhangwang commented on a change in pull request #9130: URL: https://github.com/apache/kafka/pull/9130#discussion_r491745941 ## File path: clients/src/main/java/org/apache/kafka/common/protocol/ApiKeys.java ## @@ -415,4 +444,10 @@ public void visit(Type field) { retu

[jira] [Commented] (KAFKA-9075) Extend documentation for usage of GlobalKTable vs KTable

2020-09-20 Thread Ankit Kumar (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-9075?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17199158#comment-17199158 ] Ankit Kumar commented on KAFKA-9075: Happy to pick this up, if no one else is working

[GitHub] [kafka] abbccdda commented on pull request #9270: [WIP] KAFKA-10284: Group membership update due to static member rejoin should be persisted

2020-09-20 Thread GitBox
abbccdda commented on pull request #9270: URL: https://github.com/apache/kafka/pull/9270#issuecomment-695909047 retest this please This is an automated message from the Apache Git Service. To respond to the message, please lo

[jira] [Comment Edited] (KAFKA-10273) Connect Converters should produce actionable error messages

2020-09-20 Thread Ankit Kumar (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10273?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17199182#comment-17199182 ] Ankit Kumar edited comment on KAFKA-10273 at 9/21/20, 5:58 AM: ---

[jira] [Commented] (KAFKA-10273) Connect Converters should produce actionable error messages

2020-09-20 Thread Ankit Kumar (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10273?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17199182#comment-17199182 ] Ankit Kumar commented on KAFKA-10273: - Hey [~gharris1727]/[~rhauch],   If no one i